Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Mateusz Kurek
@mkurek
@msuszko it's now raw django approach to admin filters - we're only overwriting default filters classes for some fields types. Your custom filter should work fine now (maybe you should inherit from other class than before). See https://docs.djangoproject.com/en/1.8/ref/contrib/admin/#django.contrib.admin.ModelAdmin.list_filter for details
✪ vi4m Marcin Kliks
@vi4m
we removed Ralph.* prefix from filters classes, you can subclass as documented above
Michał Suszko
@msuszko
When you register filter using FieldListFilter.register with take_priority=True I have no way to use subclassed filter in my app
Mateusz Kurek
@mkurek
yes, but you filter will be specified by class, not by field name, so our registration doesn't matter here
Michał Suszko
@msuszko
@mkurek I've used list_filter = [('field_name', MyCustomChoicesListFilter)] but had to fix AdminSearchFieldsMixin (#1823)
och
Mateusz Kurek
@mkurek
Wouldn't list_filter = [MyCustomChoicesListFilter] work?
Michał Suszko
@msuszko
@mkurek No: (admin.E114) The value of 'list_filter[0]' must not inherit from 'FieldListFilter'.
Mateusz Kurek
@mkurek
@msuszko you're right. I give :ok: to your PR
Michał Suszko
@msuszko
Guys, what is octodocker?
✪ vi4m Marcin Kliks
@vi4m
it allows you to actually run pull request changes before merging
testing on real instance
Michał Suszko
@msuszko
I'm using Gerrit, Jenkins and Docker for that. Is Octodocker released as OSS?
✪ vi4m Marcin Kliks
@vi4m
We will release it as OSS after some polishing
Michał Suszko
@msuszko
Data center asset has no relation to person. I'd like to bind administrators to assets. Are you considering adding something similar?
damian1976
@damian1976
This kind of relation was implemented in 2.x. I don't remember why but it seems it's been abandoned in 3.x. Guys should (or not) confirm that.
Mateusz Kurek
@mkurek
@msuszko this could be done right now but not directly - you could assign Service to Asset, Team to Service, and User to Team - is this flow ok for you?
✪ vi4m Marcin Kliks
@vi4m
i would rather stay with current model object, but change how it's displayed
previously we were showing "Support Group" inline, on ther Device view which was sufficient
Mateusz Kurek
@mkurek
@vi4m of course - my question was rather if @msuszko could assign some service to asset and them user to this team (which could be one-person-only in extreme case)
and i forgot about business owners and technical owners, which could be assigned to service - so there is no need to involve team here :)
damian1976
@damian1976
I think @msuszko rather meant "User Info" section in Asset add/edit form, not Support Group. Please correct me if I'm wrong.
Michał Suszko
@msuszko
@mkurek could you assign person to a support?
Mateusz Kurek
@mkurek
@msuszko afaik no - why you want to assign a person to a support?
Michał Suszko
@msuszko
@damian1976 Yes, I'm looking for assigning person to a data center asset as it is done with back office asset
damian1976
@damian1976
@mkurek, once you described me why in 3.x this info has been discarded. I don't remember the reasons why.
Michał Suszko
@msuszko
My security department is looking for a way to address vulnerability scan results, they need to identify person administering system with specific IP
Mateusz Kurek
@mkurek
@msuszko @damian1976 it useless (at least from our point of view) to assign single person to a single person - we rather prefer to assign person to service and then this service to asset; advantage of this flow is when the person is gone or the owner is changed - then you're just replacing it in one place, not in every asset; the only problem which I see here is when there is more than one person administering servers within one service - is it your case @msuszko (and @damian1976 too)?
damian1976
@damian1976
It happens quite often. But from my point of view - a single person is enough. In the worst case this person can contact another person or provide the info who is really responsible for given servers.
So the given flow should be ok for me.
✪ vi4m Marcin Kliks
@vi4m
@msuszko we are in the middle of integration of similar product (security scanner) which will integrate with ralph
to dump scan results to the Security Tab
✪ vi4m Marcin Kliks
@vi4m
@msuszko what's the use case behing assigning each admin to each asset ? can't you identify service (for example data dabases: service name"DB", 4 assets assigned to this service, service owner: John)
when you grow bigger(more servers, more people) you will likely end up with this "service" oriented idea
Michał Suszko
@msuszko
@vi4m I'm quite big at the moment, and there is infrastructure support department with teams for each software/technology. Still, formal approach is to identify one person directly responsible for a host even he can share this with coworkers
Anyway, there is no way to add people though support either. One can only attach support to an asset.
✪ vi4m Marcin Kliks
@vi4m
we can think about that, how to solve it correctly
Michał Suszko
@msuszko
I could use support groups, the problem is there are no groups nor other way to attach people to support.
and most fields in support doesn't apply to sysops teams
✪ vi4m Marcin Kliks
@vi4m
no msuszko, current 'support' tab is a different beast from 'support groups'
the only way to set the person responsible for a server is to assign it to the asset's service
what will happen when we add another field for similar purpose - for example "Supporting person" "Responsible person"
✪ vi4m Marcin Kliks
@vi4m
we can assign it independent from service owner, but when this person leaves company, we have to change it in number of places
what's your idea for it?
Mateusz Kurek
@mkurek
@msuszko so it'll be ok for you to attach Team to support? if yes then maybe you'll create PR for that (it should be only a couple of lines + migration) and we'll make sure that it is fine for us too (I don't see any objections now)?
Michał Suszko
@msuszko
I could implement it and submit pull request, just need to agree with you on the details
✪ vi4m Marcin Kliks
@vi4m
@mkurek keep it mind, that the Support wich is visible at Support tab is for asset manfuacturer support terms, which is not we're talking about here.
Michał Suszko
@msuszko
Ah, i see. You ment ralph.acconts.models.Team and Asset.support_team
Mateusz Kurek
@mkurek
yeah, but rather ralph.assets.models.assets.Service.support_team
Michał Suszko
@msuszko
At the moment RalphUser can be member of one team only. Is this intended?