by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Mateusz Kurek
@mkurek
yes; i guess that your users belong to more than one team?
Michał Suszko
@msuszko
usually, yes
We have tree organization structure, and each employee is in one department/unit, but this is different than support teams.
Michał Suszko
@msuszko
hmm models.PositiveIntegerField is to small to store ip address for Network.min_ip and .max.ip
why don'y you use GenericIPAddressField?
Michał Suszko
@msuszko
PositiveIntegerField is just IntegerField with > 0 constraint, so max value is 2^31 and last address you can store in it is 127.255.255.255
✪ vi4m Marcin Kliks
@vi4m
looks like really shitty bug - we should use only GenericIPAddressField
Michał Suszko
@msuszko
I have test env with 806 networks and 2342 IPs and ralph.data_center.models.networks.get_network_tree has been running for 10 minutes before I interrupted it, so it needs better algorithm probably
@vi4m we spent some time discussing how to squeeze our current CMDB (asset <-> administrator) mess into Ralph's model, and one support team for an asset could work for us, but one team for a person is a problem
✪ vi4m Marcin Kliks
@vi4m
@msuszko could you propose some REP with possible solutions? i'm sure we can adapt some solution which is elegant and flexible
either extending asset model(to obey team requirement)
and leaving just concrete support person - as a 1 scenario
or changing user/team structure
we will decide then
Michał Suszko
@msuszko
OK
Michał Suszko
@msuszko
djangorestframework 3.3 is out
✪ vi4m Marcin Kliks
@vi4m
Cool!
✪ vi4m Marcin Kliks
@vi4m
@msuszko what about the IP address field? are you going to fix it?
Michał Suszko
@msuszko
@vi4m I can fix it later today. What is you approach on migrations? Shouold I update latest one?
Mateusz Kurek
@mkurek
@msuszko no - just create a new one
Michał Suszko
@msuszko
fine
Pierre-Yves Dubreucq
@pydubreucq
Hi all, I would like to know if you have a better view of Ralph 3.0 release date ?
Michał Suszko
@msuszko
When one is not an admin he can't see (HTTP_403) tabs on DataCenterAssetAdmin despite having permissions granted (i.e. data_center.can_view_extra_datacenterassetcomponents)
This is actually quite tricky. ralph.lib.permissions.views.view_permission_dispatch.wraps returns HttpResponseForbidden because it looks for account.can_view_extra_datacenterassetcomponents
view_permission_dispatch wraps dispatch method twice: one time for RalphDetailView, and second time for RalphExtraViewMixin
as RalphExtraViewMixin consumes views and model arguments it dsappears from kwargs and becomes .models
Michał Suszko
@msuszko
second wrapper can;t find models in kwargs, and looks for accounts. permission instead od data_center.
Mateusz Kurek
@mkurek
@pydubreucq probably beginning of the December; @msuszko - could you create an issue for that? and we'll greatly appreciate pull request for that if you know where and what to fix :)
MarcinJanowski
@MarcinJanowski
Hello, what progress is with Ralph 3? :)
✪ vi4m Marcin Kliks
@vi4m
in short: almost everything for back office is ready (generating pdf documents, transitions, permissions), and we are working on domains contracts management, and admin logbook(operations log)
scan is not ready yet
MarcinJanowski
@MarcinJanowski
@vi4m : When is planned release?
Michał Suszko
@msuszko
@mkurek why don't you check permissions in RalphExtraViewMixin.dispatch? metaclass does .dispatch wrapping on RalphDetailView and all subclasses
MarcinJanowski
@MarcinJanowski
@vi4m: Is any docker image with updated Ralph 3?
✪ vi4m Marcin Kliks
@vi4m
previously we issued some deb packages
do you prefer deb or docker package?
MarcinJanowski
@MarcinJanowski
deb
✪ vi4m Marcin Kliks
@vi4m
ok then, i will issue a new one
MarcinJanowski
@MarcinJanowski
Nice ;) I should looking for it tomorrow?
✪ vi4m Marcin Kliks
@vi4m
i want to have this one: allegro/ralph#1855 and this one: allegro/ralph#1856 ready
MarcinJanowski
@MarcinJanowski
ok
Mateusz Kurek
@mkurek
@msuszko i don't know but i'm looking for this code now and PermissionViewMetaClass should be used in RalphExtraViewMixintoo - what do you think? Will this resolve your problem?
Michał Suszko
@msuszko
@mkurek it would wrap one more .dispatch making it slightly less efficient, and not solving the problem
wrapping RalphDetailView.dispatch is fine, but metaclass wraps any RalphDetailView sublasseses .dispatch as well
moving wrapper from PermissionViewMetaClass straight to RalphExtraViewMixin.dispatch would work, but you need view list to initialize permissions
Michał Suszko
@msuszko
@mkurek there are two problems: there is no way of knowing which View subclass is an abstract and which will be used, and setting .model attribute through .dispatch method
Mateusz Kurek
@mkurek
@msuszko i could try to solve this on friday, but could you please create an issue for that with specific instructions, symptoms what's working wrong and how to repeat the error locally?
Michał Suszko
@msuszko
ok, tomorrow
Mateusz Kurek
@mkurek
ok