by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 14:11
    drujensen commented #1219
  • 14:08
    drujensen commented #1219
  • 14:05
    andrewc910 commented #1219
  • 12:41
    andrewc910 commented #1219
  • Aug 07 18:14
    eliasjpr commented #1061
  • Aug 07 17:57
    eliasjpr labeled #1228
  • Aug 07 17:57
    eliasjpr labeled #1228
  • Aug 07 17:57
    eliasjpr labeled #1228
  • Aug 07 17:57
    eliasjpr opened #1228
  • Aug 07 17:54
    eliasjpr synchronize #1061
  • Aug 07 17:42
    eliasjpr closed #320
  • Aug 07 17:42
    eliasjpr commented #320
  • Aug 07 17:36
    eliasjpr commented #696
  • Aug 07 17:35
    eliasjpr closed #265
  • Aug 07 17:35
    eliasjpr commented #265
  • Aug 07 17:28
    eliasjpr reopened #358
  • Aug 07 17:28
    eliasjpr closed #358
  • Aug 07 17:28
    eliasjpr commented #358
  • Aug 07 17:27
    eliasjpr closed #698
  • Aug 07 17:27
    eliasjpr commented #698
Elias Perez
@eliasjpr
The plugin support will open a lot of possibilities and will unblock this issue as well amberframework/amber#1189
Dru Jensen
@drujensen
I think @damianham would love if someone added support for the render macro to check the view directory but if the template is not found, to check in the current directory. This will support the more modular layout.
where you place the model/view/controller/assets all in the same folder
Elias Perez
@eliasjpr
We can make this a config variable root_view_path and have that be used by render
Dru Jensen
@drujensen
Good idea. Avoids the extra call
Elias Perez
@eliasjpr
@drujensen do you have a few minutes, I am trying to triage some of the open issues there seems some of them to have been already resolved
Meraj
@imeraj
@drujensen I am just starting with Amber and I read the guide here - https://docs.amberframework.org/amber/guides/models . From this it seems Jennifer is more closer to ActiveRecord. Being a rails developer I wanted to give it a try first.
Meraj
@imeraj
Hello, what's the status of GraphQL support for Amber? I tried to play with https://ziprandom.github.io/graphql-crystal/ but could not integrate with Amber. There is no Rails style generator I can see. Is the support coming anytime soon?
Dru Jensen
@drujensen
@imeraj thanks for the insight. Regarding graphql, I haven’t heard of anyone trying to integrate it yet but there are several issues open requesting support.
Meraj
@imeraj_gitlab
Ok, thank you @drujensen . I think this will add much value to the framework to have this support soon.
Mark Smith
@mark_smith_gitlab
Hello guys, I am trying to run my webapp application build with amberframework inside a FreeBSD jail. Sadly I cannot make quartzmailer work since it doesn't send the mail and the webapp crashes. I'm still using the 0.34 amber with 0.6 quartz mailer and on linux everything works perfectly
So I was assuming that freebsd maybe lacks some dependency
For the test I even tried setting the mailerver to 127.0.0.1 on the port 2525 and made netcat listening on that port, but nothing happens, the app still crashes
I am running out of ideas, has anyone encountered a similar issue?
Dru Jensen
@drujensen
@mark_smith_gitlab I have not. Have you tried running inside a docker container?
docker-compose up -d
I use mail catcher for development
Elias Perez
@eliasjpr
@drujensen In regards to Amber cluster option I am in agreement with you that we should consider removing it and instead document an alternative approach such as:
Amber.env = "production"
Amber::Server.start

System.cpu_count.times do |i|
  Process.fork do
    Amber::Server.start
  end
end

sleep
Damian Hamill
@damianham
@drujensen Yes if Andrew's plugin implementation is the preferred option with the core team I have no problem with that so it has my blessing :). I haven't tried it out - I use my plugin implementation in 3 projects now and it works very well for me. Dru you are absolutely right - if the base render macro could support rendering assets in the current folder - making my render_module shard redundant - I would be delighted. I suppose that before deciding on which plugin implementation to adopt some members of the core team should try both of them out and see which they find the easiest to work with. There are pros and cons to both implementations.
Dru Jensen
@drujensen
Thanks @damianham
Elias Perez
@eliasjpr
@damianham I would like to work with you to add support for modular approach and still use the render macro. Let me know when you have some time we can hop on a hangout or something and walk thru the solution
Damian Hamill
@damianham
@eliasjpr sure thing bro. Very busy at the moment but at least I am in UK timezone at the moment so it will be easier to do a google meet. Let me know what times you are usually available and I will try to slot it in.
Andrew
@andrewc910

@imeraj_gitlab @drujensen I have successfully integrated graphql. Specifically https://ziprandom.github.io/graphql-crystal/

I have a fork that is a bit more updated. I believe i need to version bump it though. https://github.com/andrewc910/graphql-crystal/tree/types-cleanup
And the PR if you want to see what has changed: ziprandom/graphql-crystal#43
It's not much but at least it's a bit more up-to-date.

@damianham @drujensen I can move the plugin PR along later this week. I was just waiting for a consensus. I know i still need to port @damianham specs & write some documentation. It seems everyone agrees on src/plugins/{plugin_name}. I do have a clarification question that will be asked in the PR now.

Andrew
@andrewc910
Questions are in the PR. If those can be answered for me, I can finish the PR and open a PR on the docs about how to create/work with plugins. Once those are out of the way, I can go about making mochi an authentication plugin & create a graphql one :)
Dru Jensen
@drujensen
@andrewc910 this is excellent news. thanks for the contribution. The plugin architecture will help with future integrations. Happy to see the progress @damianham and you have made.
Elias Perez
@eliasjpr
WOOA! Graphq :heart_eyes:
@andrewc910 @drujensen @damianham @elorest would you guys be willing to hop on a hangout to discuss and get alignment plugins PR? - I feel that a quick 20 minute hangout we can sort the differences
Also @andrewc910 src/plugins/{plugin_name} is a destination directory? I was under the impression that we were going to use shards to install the plugins
Andrew
@andrewc910
@eliasjpr I am open anytime. Just let me know.
From what I understand, shards will be used to fetch the plugin/shard from the remote repo. Then amber install plugin_name can be ran to move/process the files into the users actual project directory.
I say plugin/shard because it will always technically be a shard since we plan on using shards to fetch. However, I imagine some plugins will be a full shard + plugin while others will just be a plugin (bridge). An example for both: for my authentication shard, I plan on putting the plugin section directly in the main shard. Mochi is specifically tailored for amber so no sense in making a separate plugin shard. However, the crystal-graphql is made to be generic. Instead of putting the plugin boilerplate into that shard, I'll create a new shard thats specifically made to be an amber plugin.
Dru Jensen
@drujensen
Ok. I misunderstood. So the amber install doesn’t update the local shard.yml and install the shard for you?
Andrew
@andrewc910
@drujensen this is what you said a month ago:
Dru Jensen
@drujensen
Oh no
Andrew
@andrewc910
Thanks for this @andrewc910! I always disliked fetching the repository instead of using the shards built-in support. Also happy to see the recursive symlink removed. 💯
Dru Jensen
@drujensen
Right. Whew. You scared me. Lol
Andrew
@andrewc910
Maybe I misunderstood. But I thought "using the shards built-in support" meant use shards to fetch the remote repo
If I misunderstood, please let me know. However, I think a hangouts/zoom call would be best 😅
Dru Jensen
@drujensen
Yes. I was still expecting the amber install to add the shard to the shard.yml for you
Instead of a manual step.
Andrew
@andrewc910
OHH! I see.
Dru Jensen
@drujensen
Maybe that is not possible
Andrew
@andrewc910
I think it is? Can't we just use crystal to run a bash command?
I, the user, run "amber install andrewc910/mochi", in our cli plugin code, we take the argument and run "shards install argument", then run the plugin specific code.
Oh wait, you can't do "shards install user:repo". So we would have to manually edit the shard.yml and then run "shards install"? That seems error prone

I was thinking the flow would be something more akin to rails. Rails you do:
Add gem to gemfile, run bundler, run rails cli for the plugin.

So that would be, add shard to shard.yml, install, run amber cli. Again, maybe i am not fully understanding the approach.

Dru Jensen
@drujensen
Yeah, no worries. It can be added later. Or maybe we can add it to the shards project? I like the shards install command better.
Andrew
@andrewc910

I believe a user should be able to do "shards install user:repo" but that is a conversation for another day.

I think we should go with the rails flow for a few reasons:

  1. the concept seems to work fine for the rails community
  2. Removing the manual shard.yml step can be a future refinement rather than a feature blocker
  3. Without the shards functionality, manually editing the shard.yml seems error-prone, but if we have a variety of plugins available, it can be easily tested in a feature branch.