Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 20 2016 01:59
    caspervonb opened #187
  • Jan 19 2016 14:16
    caspervonb synchronize #186
  • Jan 19 2016 14:16

    caspervonb on reorganize-docs

    doc: move getting-started guide… (compare)

  • Jan 19 2016 14:11
    caspervonb opened #186
  • Jan 19 2016 14:08

    caspervonb on reorganize-docs

    doc: rename man -> doc Having … doc: separate docs into sub-fol… (compare)

  • Jan 19 2016 13:14
    caspervonb opened #185
  • Jan 19 2016 13:14

    caspervonb on change-readme-banner

    doc: use banner image from medi… (compare)

  • Jan 19 2016 12:56
    caspervonb closed #184
  • Jan 19 2016 12:56
    caspervonb commented #184
  • Jan 16 2016 21:45
    caspervonb opened #184
  • Jan 15 2016 16:10
    caspervonb opened #183
  • Jan 15 2016 01:21
    caspervonb closed #182
  • Jan 15 2016 01:21
    caspervonb closed #128
  • Jan 15 2016 01:21

    caspervonb on master

    doc: add contributing document … (compare)

  • Jan 15 2016 01:17

    caspervonb on contributing

    doc: add contributing document … (compare)

  • Jan 15 2016 01:17
    caspervonb synchronize #182
  • Jan 14 2016 18:22
    caspervonb opened #182
  • Jan 14 2016 18:19

    caspervonb on contributing

    doc: add contributing document … (compare)

  • Jan 14 2016 17:01
    caspervonb opened #181
  • Jan 13 2016 04:41
    rgbkrk commented #101
Casper Beyer
@caspervonb
Because you can connect to existing processes, with events on the global object it'll just magically work with minimal plumbing
Casper Beyer
@caspervonb
Dunno what about just renaming them? fileChange and scriptChange
PR welcome with any decision TBH, these things make me totally OCD, I don't like the prefix but i have no rationale to reject it :P
Barney Carroll
@barneycarroll
Hehe
What about — just throwing it out there — a single amok event, where the type is communicated through event.type?
(Also, why kalium? Amok is an awesome name!)
Casper Beyer
@caspervonb
I'm totally for making a wicked berserker style character illustration the logo, but the name gets called out a lot on social media.
Hmph, single event leads to more complex code paths, better not?
Barney Carroll
@barneycarroll
I think it's better than throwing in a million top level APIs that are kinda namespaced by convention. Chances are you'll want all your Amok logic in one place. This also allows for space for the API to grow and add complexity.
Plus WRT complex code paths, I think a lot of the time people will want to run similar functions for different events, eg if( type === 'patch' || type === 'change' )
BTW the mythology of 'running amok' says that the subject is possessed by an evil tiger
Denis Savenok
@designeng
@caspervonb There's a message
2015-11-06 17:22:23.152 Google Chrome Helper[38157:507] All available displays report that they are mirrors.  This seems wrong.  Please comment in <rdar://problem/14731307> if you see this log
Caused by command amok --browser chrome 1.js
Barney Carroll
@barneycarroll
This message was deleted
Barney Carroll
@barneycarroll
Oddly Amok doesn't seem to be succeeding in spawning a chromium instance any more
$ NODE_DEBUG='amok,amok-server,amok-hotpatch,amok-browser' amok ./test/index.js -t -b chromium -c watchify -- -d -t babelify
AMOK 1975: set cwd /home/barney/git/modulator
AMOK 1975: set scripts { './test/index.js': './test/index.js' }
AMOK 1975: use server
AMOK 1975: use compiler
AMOK 1975: use hotpatch
AMOK 1975: use browser
AMOK 1975: use print
AMOK 1975: use multiplexer
AMOK 1975: run
AMOK 1975: set url http://localhost:9966/
AMOK-SERVER 1975: ready
AMOK 1975: set scripts { 'test/index.js': '/tmp/watchify115107-1975-qabs4c/index.js' }
AMOK-HOTPATCH 1975: done
AMOK-BROWSER 1975: starting server on port 9223
AMOK-BROWSER 1975: server listening
AMOK-BROWSER 1975: close server
AMOK-BROWSER 1975: server close
AMOK-BROWSER 1975: spawn chromium --user-data-dir=/tmp/chromium115107-1975-yxbbg3 http://localhost:9966/ --remote-debugging-port=9223 --no-first-run --no-default-browser-check
Casper Beyer
@caspervonb
@barneycarroll chromium only?
and which chromium-browser works fine?
@designeng Debug logs from chrome, any issues with it?
Casper Beyer
@caspervonb
@barneycarroll tried downgrading node?
Casper Beyer
@caspervonb
@barneycarroll open an issue for this one please, kinda a big deal if the browser isnt spawning ;)
Casper Beyer
@caspervonb
It should be errroring if it cant be found so.. very strange
Might be an issue with node 3/4 vs 0.12.x
Casper Beyer
@caspervonb
@barneycarroll the chrome(ium) process does not start at all?
Lim H.
@limdauto
@caspervonb hey just want to drop by to say amok is fantastic. I backed the project very early on but completely forgot about it. Just moved to a new computer today so was reevaluating my tools and suddenly remembered this. I took it for a test drive and was blown away. Thank you!
Casper Beyer
@caspervonb
Cheers @limdauto, still lots to do but we're getting there :)
Ah and yeah I remember, Lim H in backers IIRC :P
Danil Kornishev
@dkornishev
Hey, getting strange failure [5708:8484:1219/184718:ERROR:external_registry_loader_win.cc(144)] File C:\Users\Danil\AppData\Local\CRE\ihogoofdaifgdkdilopkeahfcnifkajn.crx for key Software\Google\Chrome\Extensions\ihogoofdaifgdkdilopkeahfcnifkajn does not exist or is not readable.
running amok --browser chrome --hot file:///cygpath -aw web/index.html chrome does open correctly a new session and opens the file requested, but no hot-swap occurs
this is on windows/cygwin (which I know is a bit strange to get things working)
Danil Kornishev
@dkornishev
creating that file manually got rid of the error, but still no hot swap...
Danil Kornishev
@dkornishev
localhost:9222/json doesn't load...hrm
Casper Beyer
@caspervonb
Hey @dkornishev , thats a chrome error
And its extension related
But it doesn't necessarily mean its the cause, actually unlikely as long as chrome without fatal errors starts you're good to go
@dkornishev could you run with NODE_DEBUG=amok,amok-browser,amok-hotpatch set and post it as an issue?
Casper Beyer
@caspervonb
Think it might be a bug due to spaces in the path not being decoded, e.g amok is actually looking for a file containing %20
Casper Beyer
@caspervonb
Been mulling it over, most likely reason is spaces in the file path, Caught a similar issue a few days ago on win10. Will get it fixed soon. Working on docs and test coverage for the underlying modules as I've been fixing quite a bit of things in them (browser_process, rdbg, compiler_process, debug_process)
If I'm right, temporary work around is don't use spaces in paths, unixy tools tend to have issues with this anyways (they shouldn't, but that test case gets overlooked ;))
Merry Christmas guys and gals :santa:
Danil Kornishev
@dkornishev
Merry Christmas to you too
Things I have figured out...CHROME_FLAGS are a little quirky in behavior (again I am on windows/cygwin so it might be a non-issue in a real linux environment)
i.e. export CHROME_FLAGS="--user-data-dir=/amok" works. When I tried to include actual paths (or god forbid ~) it stops working
Danil Kornishev
@dkornishev
amok --browser chrome --hot file:///cygpath -wa index.html opens the browser but does not start a debug connection
amok --browser chrome --hot js/index.bundle.js works correctly, but only if run from the same dir as where index.html lives
I think it would be nice to be able to specify baseDir and/or index.html to load
I've also been thinking about using amok via api, looking at the script doesn't seem like it would be too hard, but some documentation would be nice
Danil Kornishev
@dkornishev
anyway, phenomenal project already, hope it really takes off. It motivated me to dust off and re-connect my second monitor :)
Casper Beyer
@caspervonb
Yeah dual monitors with amok rock! :)