These are chat archives for anacrolix/torrent

5th
Nov 2017
Matt Joiner
@anacrolix
Nov 05 2017 03:26
@boramalper are you still stuck on that problem?
Matt Joiner
@anacrolix
Nov 05 2017 04:47
@boramalper anacrolix/torrent@fce1fe1 anacrolix/torrent@edf2495 some combination of those will get you what you want now
Matt Joiner
@anacrolix
Nov 05 2017 06:03
@iamacarpet your PR has exposed a pretty epic bug introduced by the unbiased request ordering optimization
i've tracked it down, the implementation will request chunks from the fastest peers even if they don't the corresponding pieces. which will impact poorly seeded torrents, but is probably unnoticed elsewhere
Denis
@elgatito
Nov 05 2017 09:56
latest anacrolix/torrent throws panic when adding torrent - http://paste.ubuntu.com/25893666/
Matt Joiner
@anacrolix
Nov 05 2017 09:57
!
I don't think that's an issue from torrent, can you double check?
Denis
@elgatito
Nov 05 2017 10:08
sorry, tried build from another host and it's fine :( probably some dependencies not updated
Matt Joiner
@anacrolix
Nov 05 2017 10:08
Yeah it looks like your *Client is nil, which isn't going to end well
Denis
@elgatito
Nov 05 2017 10:08
actually my code was not changed
something in the middle
you update dependencies with "go get -u ./..." inside of the project?
Matt Joiner
@anacrolix
Nov 05 2017 10:10
no, let me try
Denis
@elgatito
Nov 05 2017 10:11
it's fine on my host. just asking, maybe i'm doing that wrong locally
travis is always doing checkouts antway
Matt Joiner
@anacrolix
Nov 05 2017 10:29
do you test my stuff in your travis?
Denis
@elgatito
Nov 05 2017 11:22
heh. not yet
Samuel
@iamacarpet
Nov 05 2017 12:06
@anacrolix sorry about that, any idea if it’s easy to fix? I don’t mind having a look if you can point me in the right direction when you are back. Hopefully fairly easy if we keep track of the pieces they have, just a check before requesting?
Denis
@elgatito
Nov 05 2017 19:50
@anacrolix , do you have experience with ratelimiting torrent client? It looks like Burst is a const number, whetever you set it. So when I set rate limiter to "rate.Inf, 16K", the speed is not big enough, but limiting the speed is fine, when I set "rate.Inf, 1m", the speed is great, but rate limiting is strange, it drops speed to very low numbers
so maybe there is a good practice of limiting download/upload speed?