These are chat archives for anacrolix/torrent

28th
Jan 2018
deranjer
@deranjer
Jan 28 2018 00:13
@anacrolix Any examples you could give me of how to make the rate limiter work in a predicable manner? Although I honestly suppose it could be the method I am using to measure dl speed... I am basically doing a NewLimiter(500000, 500000) and I still sometimes get bursts of up to 1.5MB/s on download... am I at least using it right?
Also, are we able to change the limiter while the engine is running?
Matt Joiner
@anacrolix
Jan 28 2018 01:19
i just ran a test, i can reproduce the rate limit burstiness
deranjer
@deranjer
Jan 28 2018 01:19
Okay, just making sure I wasn't using it incorrectly. I don't see a way to change the limit while the engine is running, is that possible?
Matt Joiner
@anacrolix
Jan 28 2018 01:19
i think what happens is all the connections progress to the ReserveN at the same time and stal for ages
yes it would be possible, just need the API changed a bit
this also needs a test
deranjer
@deranjer
Jan 28 2018 01:20
The rate limiting needs a test?
Matt Joiner
@anacrolix
Jan 28 2018 01:20
yes
deranjer
@deranjer
Jan 28 2018 01:20
Okay, next week i'll pull the latest from your repo and work on that
maybe look into getting a PR for changing the rate limiter while running... but most likely that will be too difficult for me
Matt Joiner
@anacrolix
Jan 28 2018 01:21
make an issue for it
deranjer
@deranjer
Jan 28 2018 01:21
Will do
Matt Joiner
@anacrolix
Jan 28 2018 01:21
cheers
Matt Joiner
@anacrolix
Jan 28 2018 04:31
ok i've fixed the download rate limiter and added a test
testing it is very difficult, but i think i succeeded. the old algorithm is left in there you can try it with a constant to verify
Matt Joiner
@anacrolix
Jan 28 2018 06:46
yo @elgatito , got a link to your project to put in the README?
Denis
@elgatito
Jan 28 2018 06:55
@anacrolix you can use this one http://elementum.surge.sh
Matt Joiner
@anacrolix
Jan 28 2018 06:56
excellent, thanks
Denis
@elgatito
Jan 28 2018 07:03
So what is the good rate limiter parameters for real use? Bytes size is clear, what about the burst?
Is it better with the wastage of traffic on your hosts after the change?
Matt Joiner
@anacrolix
Jan 28 2018 07:04
yeah, it's dropped much lower
i wouldn't put burst below 100KB
i'd recommend to put it something like max(100KB, bytesPerSecond)
Denis
@elgatito
Jan 28 2018 08:14
pushed new release, hope we are fine now :D
Denis
@elgatito
Jan 28 2018 18:51
Am I understanding right that we have number of connected peers oug of total number of peers
And seeds are about the same, but includes stats only for peers that have all the pieces?
So seeds is a subset of peers stats, actually?
Matt Joiner
@anacrolix
Jan 28 2018 23:49
Yeah that sounds right
I'm not sure what the code is doing but probably that