These are chat archives for anacrolix/torrent

11th
Apr 2018
Christian Muehlhaeuser
@muesli
Apr 11 2018 01:11
hey guys! i noticed a potential null pointer access when using the dht package
https://github.com/anacrolix/dht/blob/master/announce.go#L195 <- SenderID() may return nil, in which case accessing its value *m.SenderID() would crash
I have pushed a potential fix here, i'm just not entirely sure, if that's the preferred way of handling this situation: muesli/dht@213d429
let me know and i shoot you a PR if you're interested
Christian Muehlhaeuser
@muesli
Apr 11 2018 01:59
actually, i just went ahead and did: anacrolix/dht#19
can't harm, right ;-)
Matt Joiner
@anacrolix
Apr 11 2018 07:28
that's now merged
and there's a test case :O
@elgatito There's nothing in there I can see that's useful. It would be nice to know that your DHT is working, check your debug vars for "peersAddedBySource": {
"Ha": 23,
"Hg": 305727,
"Tr": 13535,
"X": 187537
},
Christian Muehlhaeuser
@muesli
Apr 11 2018 07:32
@anacrolix nice one... So kind of the right fix after all?
Christian Muehlhaeuser
@muesli
Apr 11 2018 08:31
@anacrolix: managed to trigger a panic here: anacrolix/torrent/bep40.go:71 +0x9d9
Matt Joiner
@anacrolix
Apr 11 2018 08:45
@muesli anacrolix/torrent#245
Christian Muehlhaeuser
@muesli
Apr 11 2018 09:04
@anacrolix thanks, gonna see if there's something i can do about it
Christian Muehlhaeuser
@muesli
Apr 11 2018 09:36
seems a dupe of #244?
Denis
@elgatito
Apr 11 2018 11:37
@anacrolix , elgatito/elementum#7 , it looks like we have agreed then to allow usage of "ignore_unmarshal_type_error" here https://github.com/anacrolix/torrent/blob/master/metainfo/metainfo.go#L16
but have not included processing of it in decoder?
having problem with this syntax in torrent file: "creation date": "29.03.2018 22:18:14 UTC",
Denis
@elgatito
Apr 11 2018 11:42
some usage mentioned in decode.go, but still getting this: &bencode.SyntaxError{Offset:265, What:(*strconv.NumError)(0xc4207a3c50)}