These are chat archives for anacrolix/torrent

8th
Jun 2018
Denis
@elgatito
Jun 08 2018 05:47
huh.. i've made a basic socks5 usage in the library :) and it's working
Denis
@elgatito
Jun 08 2018 06:49
huh.. created a PR to allow proxy
works fine with my socks5 (with auth) on a firewalled network :)
Matt Joiner
@anacrolix
Jun 08 2018 09:14
great, i'm just waiting for it to pass tests
Matt Joiner
@anacrolix
Jun 08 2018 09:21
@elgatito I like it
Denis
@elgatito
Jun 08 2018 09:56
@anacrolix there are lot of ways to improve, but not sure its worth, taking care of complexity
Matt Joiner
@anacrolix
Jun 08 2018 09:56
yep
it passes tests, and if it works for your proxy it's a start
Denis
@elgatito
Jun 08 2018 09:56
This impl understands socks/http/https proxies
And thats a built-in way, so why not, for a start
Matt Joiner
@anacrolix
Jun 08 2018 09:57
the DefaultHTTPClient in the Config, it's only for trackers right?
i'll put some comments on the PR
Matt Joiner
@anacrolix
Jun 08 2018 10:02
happy to fix the things up myself but don't want to accept it and then go and break any API
Denis
@elgatito
Jun 08 2018 10:05
Yes, defaulthttpclient only for trackers requests
Matt Joiner
@anacrolix
Jun 08 2018 10:05
ok so you do proxy for trackers through http.Client, and for everything else you're using golang/x/net/proxy?
Denis
@elgatito
Jun 08 2018 10:13
Yup
There is some logic in http proxying, they do theirselves
Matt Joiner
@anacrolix
Jun 08 2018 10:14
ah there's a problem there dropping the context
Denis
@elgatito
Jun 08 2018 10:31
Tcp dial without context?
Matt Joiner
@anacrolix
Jun 08 2018 10:38
yeah taht's the one
we'll just put a comment that proxy dials may have timeout issues, but that's ok
i just wonder if we can get dialcontext from somewhere else
Matt Joiner
@anacrolix
Jun 08 2018 10:58
i've accepted it
Denis
@elgatito
Jun 08 2018 11:06
Thanks, will bring you few thousands of testers 😁
Matt Joiner
@anacrolix
Jun 08 2018 11:08
heh :P
i'm not sure about that other issue you linked me to, did you do a release with a newer version of torrent recently? is there someway I can figure out what revision you're using of things in your releases?
Denis
@elgatito
Jun 08 2018 11:22
Will post new version and there will be debug enabled
Have not got time , yet, to make proper release 🙁
Matt Joiner
@anacrolix
Jun 08 2018 11:22
yeah that's fine
there's a mysterious flag in that status debug in the issue
'T'
that shouldn't appear except in old torrent revisions i think
Matt Joiner
@anacrolix
Jun 08 2018 13:01
nevermind, i misread it