These are chat archives for anacrolix/torrent

13th
Jun 2018
Matt Joiner
@anacrolix
Jun 13 2018 00:21
just found a bug that's been in torrent for over 3 years
don't think it really affects anyone but it fails the tests a lot
Matt Joiner
@anacrolix
Jun 13 2018 00:54
90f84bda71fbbccec7fb05d69d948cb937d014e4
hm anacrolix/torrent@90f84bd
Denis
@elgatito
Jun 13 2018 04:56
isn't it fine to disallow connections to same peers?
Matt Joiner
@anacrolix
Jun 13 2018 07:45
except that clients will disagree on which connection to keep
Denis
@elgatito
Jun 13 2018 07:46
And what was the result of this check? Less connections than we expect?
Matt Joiner
@anacrolix
Jun 13 2018 07:56
all connections are lost instead of just duplicates
i doubt it has an impact on performance, but it might
particularly when gotorrent initiates the connections
Denis
@elgatito
Jun 13 2018 15:05
DEBU  bittorrent   ▶ configure        Client listening on tcp: 0.0.0.0:36967
DEBU  bittorrent   ▶ configure        Client listening on tcp: [::]:36967
DEBU  bittorrent   ▶ configure        Client listening on udp: 0.0.0.0:36967
DEBU  bittorrent   ▶ configure        Client listening on udp: [::]:36967
portfwd.go:32: discovered 1 upnp devices, map[]
 5  D ;;; upnp 192.168.0.25: anacrolix/torrent
      chain=dstnat action=dst-nat to-addresses=192.168.0.25 to-ports=36967 protocol=tcp dst-address=10.104.1.149 in-interface=ether1-gateway dst-port=36967 

 6  D ;;; upnp 192.168.0.25: anacrolix/torrent
      chain=dstnat action=dst-nat to-addresses=192.168.0.25 to-ports=36967 protocol=udp dst-address=10.104.1.149 in-interface=ether1-gateway dst-port=36967
looks good from the router side, still a black hole :D
Denis
@elgatito
Jun 13 2018 15:12
upnp devices should understand close request, to close port on listener close
to cleanup ports
isn't it strange there are only 3 connections with this number of peers?
Matt Joiner
@anacrolix
Jun 13 2018 23:48
I think they usually timeout. Is there close support in the upnp implementation we're using?
It's very strange. Is your plugin open source, can you link me to the peer ID code?