These are chat archives for anderspitman/dice-game

5th
Apr 2016
Anders Pitman
@anderspitman
Apr 05 2016 01:44
@chcschmid I just pinged you on github about the CSV stuff. If you can review that that would be great
@/all, as discussed earlier you can no longer make changes to my repo directly. Everything will have to be done through PRs
@sarahka7 you missed that part of the conversation
sarahka7
@sarahka7
Apr 05 2016 01:51
Okay got it- thx
Anders Pitman
@anderspitman
Apr 05 2016 01:53
@sarahka7 you'll need to fork my repo. See here: https://help.github.com/articles/fork-a-repo/
Anders Pitman
@anderspitman
Apr 05 2016 02:18
If someone could review #16 that would be great. It adds gradle wrapper, which should make it so you guys can build everything without installing gradle manually
Anders Pitman
@anderspitman
Apr 05 2016 05:22
Alright, PR #17 should have the basic setup for everything we need. I have separate directories for cli and gui. You guys should be able to start building your pieces whenever you're ready. I don't have any of the Game class implemented yet.
If someone can look over my PRs real quick and just verify that nothing looks fishy I'
I'll merge them
Hannah Van Den Bosch
@mshannahnv
Apr 05 2016 05:23
Can we still merge them or no?
Does that count as changing your repo
Anders Pitman
@anderspitman
Apr 05 2016 05:24
unfortunately yes
so just leave a comment after the review saying every looks ok
Hannah Van Den Bosch
@mshannahnv
Apr 05 2016 05:26
Okay they both look good
Anders Pitman
@anderspitman
Apr 05 2016 05:27
merged
thanks
spent like 3 hours coming up to speed on gradle today
but I think it was worth it
Hannah Van Den Bosch
@mshannahnv
Apr 05 2016 05:27
Totally
Anders Pitman
@anderspitman
Apr 05 2016 05:27
it's very powerful
Hannah Van Den Bosch
@mshannahnv
Apr 05 2016 05:28
I hope I get some time to dive into reading up about travis/gradle
Anders Pitman
@anderspitman
Apr 05 2016 05:28
I think the way it's set up now we should be able to develop the cli and gui completely independently, while still sharing the common code
Hannah Van Den Bosch
@mshannahnv
Apr 05 2016 05:28
Which is great
SO we have a test Friday?!
She posted an announcement
Anders Pitman
@anderspitman
Apr 05 2016 05:29
yeah
book
boo*
Hannah Van Den Bosch
@mshannahnv
Apr 05 2016 05:29
Evil
Anders Pitman
@anderspitman
Apr 05 2016 05:30
good news is just finals in all my classes after this week
Hannah Van Den Bosch
@mshannahnv
Apr 05 2016 05:30
I cannot believe that it's almost finals
Anders Pitman
@anderspitman
Apr 05 2016 05:30
seriously