These are chat archives for anderspitman/dice-game

7th
Apr 2016
Anders Pitman
@anderspitman
Apr 07 2016 01:00
Created the main DiceGame class and some (rather hacky) unit tests. Should be enough for you guys to get started once merged. Can someone review #24?
Anders Pitman
@anderspitman
Apr 07 2016 01:06
I went with an exception for handling the case when the user rolls after they've already passed 23. Let me know if anyone is opposed to that. I think it's safest way since it would be easier to ignore a return code.
sarahka7
@sarahka7
Apr 07 2016 01:50
Ok forked the dice game and working on some psuedocode for console. Was there something else i need to "clone"?
Anders Pitman
@anderspitman
Apr 07 2016 01:53
now that you've forked my repo, you'll need to clone from https://github.com/sarahka7/dice-game if you haven't already. That will be your "origin" remote, and my repo will be your "upstream" remote
from cygwin you can just do git clone https://github.com/sarahka7/dice-game in the directory you want dice-game to live
then you make your changes in there
sarahka7
@sarahka7
Apr 07 2016 01:58
Ok, in meantime should i code In gist- is that editable to others? then load to the repo?
Or just be working in a .java file - prob makes more sense-
Anders Pitman
@anderspitman
Apr 07 2016 02:19
i
Depends on what you're doing. If you want to share an idea, gists or hangouts can be good. Anything that will bein the final product should be committed. I would lean towards doing things that way because it gives us a paper trail of our progress
sarahka7
@sarahka7
Apr 07 2016 03:46
Okay i have a java file with psuedo code done- its making some assumptions about how the gui will look so want to be sure im on right track, before we get to real coding. How do i share it? Im inside my forked version now.
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 03:46
I'm here!
Should she do a PR to your master @anderspitman
?
Or if it's just psuedo code... put it in gist?
Anders Pitman
@anderspitman
Apr 07 2016 03:49
hm
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 03:50
I can convert to java code
Anders Pitman
@anderspitman
Apr 07 2016 03:50
up to you two
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 03:50
Anders Pitman
@anderspitman
Apr 07 2016 03:50
like I said. If expect it to evolve into something we want to keep around, go ahead and commit it
but gist is probably easier
sarahka7
@sarahka7
Apr 07 2016 03:51
Hey Hannah! So should i try doing a pull request? Any particular folder or just from master branch?
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 03:52
Since it's pseudo code, we can just do gist
sarahka7
@sarahka7
Apr 07 2016 03:52
okay
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 03:53
Feel free to post it in gist and share it with us
sarahka7
@sarahka7
Apr 07 2016 03:53
Ok will try now
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 04:03
Wow nice!
@anderspitman #24 Looks good
sarahka7
@sarahka7
Apr 07 2016 04:06
Thanks, i tried to match use case and stories, i was thinking more button clicking for navigation than actual keyboard typing, it its not too much hassle to add into gui.
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 04:06
I think it's great hopefully @hehe876 will check it out as well
As he's doing the GUI
I like that it has the entire flow
@anderspitman Did you want me to just edit your main.java?
/cli/src/main/java/Main.java
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 04:46
I'll work on converting Sara's pseudo code to code tomorrow morning
Christiaan Schmid
@chcschmid
Apr 07 2016 04:47
Hey all... I'm working on javadoc for the java files in src right now
Nguyen Dao
@ngdao
Apr 07 2016 04:52
Will check it out shortly
Christiaan Schmid
@chcschmid
Apr 07 2016 04:56
@anderspitman in RollRecord.java is that an object consisting of data collected at the end of a game?
Christiaan Schmid
@chcschmid
Apr 07 2016 05:40
I just updated Die.java, RollRecord.java, and StatsProcessor.java with java documentation. Let me know if that's the format we want to follow for the documentation. I still need to provide info on a function in RollRecord.java... does getRollValue() return the total of all rolls?
I was thinking that was the same as getTotalScore(). However, now that I think about it, totalScore could be a different value because of penalties or bonus points depending on how they finished. Am I understanding that correctly?
Anders Pitman
@anderspitman
Apr 07 2016 05:52
Sorry guys, kinda had a weird night. Great work though!
@sarahka7 the pseudocode is awesome!
@chcschmid RollRecord is just a java wrapper around the rows we're going to write to the database
I should probably rename getTotalScore to getTotalAllRolls or something like that, since the roll values are different from the final score for each game
but go ahead and just do the javadoc with the name as it is, and I'll rename it in a separate PR
@mshannahnv yeah just edit the Main.java for the cli
to run it do gradlew :cli:run
Nguyen Dao
@ngdao
Apr 07 2016 23:00
@anderspitman So I created a pull request for the GUI. If I fetch from your master now, will it only add any additional files or overwrite my repo?
Hannah Van Den Bosch
@mshannahnv
Apr 07 2016 23:23
I'm getting the following error:
Main.java:1: error: package dice does not exist
import dice.*;
Anders Pitman
@anderspitman
Apr 07 2016 23:40
@hehe876 if you fetch it's fine, but if you merge or pull (fetch + merge) there might be merge conflicts that you have to resolve and commit
@mshannahnv are you running the build with gradlew :CLI:run?
Anders Pitman
@anderspitman
Apr 07 2016 23:50
@hehe876 see github for comments on the PR