These are chat archives for anderspitman/dice-game

8th
Apr 2016
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 00:04
Ah, no. Makes sense
Do I need to be in dice-game to run it? Or deeper than that?
Anders Pitman
@anderspitman
Apr 08 2016 00:11
All the gradle commands are run from dice-game
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 00:13
Ty
Christiaan Schmid
@chcschmid
Apr 08 2016 01:31
Did you guys see our score for our first deliverable?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 01:32
No. Is it bad
Christiaan Schmid
@chcschmid
Apr 08 2016 01:33
22 out of 25. They took off points on the backlog, but i'm a little peeved because of how vague the instructions were with the backlog
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 01:34
Yeah I googled how to create a backlog and all it stated was to rank the stories
And also cracked open my scrum textbook
Thought ta said everything looked good when Eric visited!?
:(
Christiaan Schmid
@chcschmid
Apr 08 2016 01:36
That's what I thought, too! @anderspitman we're ready to get some points back
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 01:44
Well I feel bad because that was my section. I'd like to fix it but there is nothing in her PowerPoint about product backlogs
Nguyen Dao
@ngdao
Apr 08 2016 02:06
expected sprint, complexity points,
what the heck are these
lol
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 02:11
Did Corey say our backlog was OK @hehe876 ?
Nguyen Dao
@ngdao
Apr 08 2016 02:17
yeah
I don't think he knew about those either
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 02:23
Lololol
Freaking Vaul
Anders Pitman
@anderspitman
Apr 08 2016 02:43
This message was deleted
I should probably mention this chat is public and there's a link in our repo to it
Nguyen Dao
@ngdao
Apr 08 2016 02:45
can we make it private?
Anders Pitman
@anderspitman
Apr 08 2016 02:46
I don't think so, since it's linked to a public repo. I figured this would be a good way to show our workflow
Nguyen Dao
@ngdao
Apr 08 2016 03:11
Aint nobody got time for that haha. The GUI.java can build as is. It only need those 3 files
@anderspitman
Anders Pitman
@anderspitman
Apr 08 2016 03:13
what's the command to build it?
working on integrating it with gradle now...
I'm getting
Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
are you able to run it from the command line?
this is what I tried:
javac DiceGameGUI.java
java DiceGameGUI
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 03:30
This message was deleted
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 04:08
Are we requiring that the first roll be with 3 dice?
Just reading the rules and wanted to confirm because I didn't know what we were set on
Anders Pitman
@anderspitman
Apr 08 2016 04:14
I say whatever is simplest to code
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 04:16
I think setting a restriction makes it more complicated
Not much more
I'll just leave the rules as is
I'm just importing them into the CLI
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:27
Hannah@Hannah-PC /cygdrive/c/Users/Hannah/Documents/GitHub/dice-game
$ ./gradlew :cli:run
./gradlew: line 2: $'\r': command not found
./gradlew: line 8: $'\r': command not found
./gradlew: line 11: $'\r': command not found
./gradlew: line 14: $'\r': command not found
./gradlew: line 17: $'\r': command not found
./gradlew: line 18: syntax error near unexpected token `$'{\r''
'/gradlew: line 18: `warn ( ) {
Anders Pitman
@anderspitman
Apr 08 2016 05:29
hm I think it's the line endings
I could have sworn we tested this on your laptop though
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:29
I'm on my desktop
I could try to do it on my laptop
What were the commands that we ran again??
can your text editor save the files with unix line endings?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:32
I'm not sure, I'd need to google it
"Try running the dos2unix command on the file in question."
should I try that?
Anders Pitman
@anderspitman
Apr 08 2016 05:32
idk
if I were there I'd say go for it because I know how to use git to back out of any damage you could do
but without that it's risky
what editor are you using?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:33
just jgrasp
Anders Pitman
@anderspitman
Apr 08 2016 05:34
man idk
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:34
:(
Anders Pitman
@anderspitman
Apr 08 2016 05:34
it's hard to say which files the line endings got changed on
it could have been a file you saved, or one gradle created, or something to do with git
when I checked gradle into git it gave me a warning about line endings, but it worked fine on your laptop....
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:35
Should I try it on my laptop
??
Anders Pitman
@anderspitman
Apr 08 2016 05:35
maybe
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:35
I'll just xfer the file over
Anders Pitman
@anderspitman
Apr 08 2016 05:36
I don't think that will fix it
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:36
Oh
Anders Pitman
@anderspitman
Apr 08 2016 05:36
can you gist the file?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:36
yea
Anders Pitman
@anderspitman
Apr 08 2016 05:36
also make a backup (or 2) of it and try dos2unix on it as well
Anders Pitman
@anderspitman
Apr 08 2016 05:38
It doesn't throw that error on mine. Some other compile errors but just normal thing that need to be debugged
does ./gradlew :cli:run work on a clean master? You can do git stash to stash your changes (git pop to get them back)
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:41
Ok.. odd
It worked on Git Bash
not in cigwyn
Anders Pitman
@anderspitman
Apr 08 2016 05:42
that makes me nervous
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:42
Maybe I didn't have something installed correctly in cigwyn?
Anders Pitman
@anderspitman
Apr 08 2016 05:42
definitely means you have windows line endings I think
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:42
Ok
Anders Pitman
@anderspitman
Apr 08 2016 05:43
should be simple to solve. if you do a git diff (in cygwin), there shouldn't be any changes to the line endings. If that's the case, then it's just your new file that needs to be fixed
presumably the gist automatically unixified it
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:48
So I need to install dos2unix into cygwin ?
Anders Pitman
@anderspitman
Apr 08 2016 05:52
might not be worth the effort if git bash is working
we'll need to get to the bottom of this eventually but it's not as important as just getting things up and running
@hehe876 if you can't get the GUI to work with gradle don't sweat it. Just throw it in there someone and update the README with instructions on how to run it. As long as it works we can fix the build system later
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 05:57
So since my play() method uses roll() which throws an exception.. my play() needs to throw it as well?
:cli:compileJavaC:\Users\Hannah\Documents\GitHub\dice-game\cli\src\main\java\Main.java:78: error: unreported exception RollAfterGame     OverException; must be caught or declared to be thrown
                  System.out.println("You rolled a total of " + game.roll(numDice));
Anders Pitman
@anderspitman
Apr 08 2016 05:59
or catch it
check out the unit tests for an example
even if the catch block just prints out "Should never happen" or something like that
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:00
ok
Anders Pitman
@anderspitman
Apr 08 2016 06:00
because you should be checking to make sure the game isn't over before each roll
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:00
Right
Anders Pitman
@anderspitman
Apr 08 2016 06:00
@chcschmid is #25 ready to merge, or were you going to add any more to it?
Anders Pitman
@anderspitman
Apr 08 2016 06:06
Also a heads up guys I'm going out of town tomorrow night, so I'll need to have everything on my end wrapped up by about 5. Worst case scenario I can give you guys push access again, but I think we can get everything working before then
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:07
Yeah I hope we can finish before then
$ ./gradlew :cli:run
:shared:compileJava UP-TO-DATE
:shared:processResources UP-TO-DATE
:shared:classes UP-TO-DATE
:shared:jar UP-TO-DATE
:cli:compileJava
:cli:processResources UP-TO-DATE
:cli:classes
:cli:run
Welcome to Three to Twenty Three: A simple dice game inspired by Blackjack.

Select an option below:
1. How to play
2. Play
3. Quit
Exception in thread "main" java.util.NoSuchElementException
        at java.util.Scanner.throwFor(Scanner.java:862)
        at java.util.Scanner.next(Scanner.java:1485)
        at java.util.Scanner.nextInt(Scanner.java:2117)
        at java.util.Scanner.nextInt(Scanner.java:2076)
        at Main.startScreen(Main.java:24)
        at Main.main(Main.java:6)
:cli:run FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':cli:run'.
> Process 'command 'C:\Program Files\Java\jdk1.8.0_65\bin\java.exe'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 4.559 secs
Seems like it's pissed at line 24?
Anders Pitman
@anderspitman
Apr 08 2016 06:09
yeah
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:09
input = scan.nextInt();
Don't see a problem with it
Anders Pitman
@anderspitman
Apr 08 2016 06:09
you can run gradlew :cli:run --info to get more information
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:10
Okay I'll try that
command not found
Anders Pitman
@anderspitman
Apr 08 2016 06:10
./gradlew
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:18
So from what I'm reading about NoSuchElementException.. it's because I wasn't closing my scanner?
Tried closing them and it's still not working
Anders Pitman
@anderspitman
Apr 08 2016 06:19
did --info ever work?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:19
It did
It displayed a large block of text
Nothing that stood out
Should I copy it?
maybe you're using the scanner after it's already run out?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:21
Ah I vaguely remember needing to use hasNext()
well..
I thought that was only for reading a file
Anders Pitman
@anderspitman
Apr 08 2016 06:22
I have no idea
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:22
Doesn't really make sense because It's not allowing me to type anything
Anders Pitman
@anderspitman
Apr 08 2016 06:22
normally I would have tried running it way before I had this much code ;)
ooooooooooo
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:22
Yea
I should've commented out the import dice.*
Anders Pitman
@anderspitman
Apr 08 2016 06:23
ok maybe gradle is the problem
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:23
and been debugging
Anders Pitman
@anderspitman
Apr 08 2016 06:23
didn't think about that
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:23
I'll comment out the external stuff and debug in jgrasp
Anders Pitman
@anderspitman
Apr 08 2016 06:23
wait
quick and dirty, try this
one sec
ok try ./gradlew :cli:installDist
then go to cli/build/install/cli/bin and do ./cli
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:26
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (master)
$ ./gradle :cli:installDist
bash: ./gradle: Is a directory
Anders Pitman
@anderspitman
Apr 08 2016 06:26
eff
fixed it
copy paste queen
:P
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:27
hahahhaa
I still don't know the difference between gradle and gradlew
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (master)
$ ./gradlew :cli:installDist
:shared:compileJava UP-TO-DATE
:shared:processResources UP-TO-DATE
:shared:classes UP-TO-DATE
:shared:jar UP-TO-DATE
:cli:compileJava UP-TO-DATE
:cli:processResources UP-TO-DATE
:cli:classes UP-TO-DATE
:cli:jar
:cli:startScripts
:cli:installDist

BUILD SUCCESSFUL

Total time: 4.806 secs
Anders Pitman
@anderspitman
Apr 08 2016 06:27
for gradle to work you have to install it on your system and add it to PATH. nobody got time for that
gradlew just ships with our repo
and autodownloads the version of gradle you need
nice seems to be building ok
can you run it?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:29
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (master)
$ cd cli/build/install/cli/bin

Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game/cli/build/install/cli/bin (master)
$ ./cli
Welcome to Three to Twenty Three: A simple dice game inspired by Blackjack.

Select an option below:
1. How to play
2. Play
3. Quit
Think it's working
Anders Pitman
@anderspitman
Apr 08 2016 06:29
excellent
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:29
So what happened
Should I revert my extremely aggressive scanner closing?
Anders Pitman
@anderspitman
Apr 08 2016 06:30
I think when you let gradle have control of running it (:cli:run), it doesn't properly handle user input
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:30
Scanner scan = new Scanner(System.in);

            input = scan.nextInt();
            scan.close();
Anders Pitman
@anderspitman
Apr 08 2016 06:30
probably
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:30
lol
Anders Pitman
@anderspitman
Apr 08 2016 06:31
now what we're doing is building it as though we were going to ship it to users, so it handles the input ok
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:31
So do they (TAs) need to run it just how I did?
I can use that to make it work for the TAs
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:32
:thumbsup:
Anders Pitman
@anderspitman
Apr 08 2016 06:32
or you can add it
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:34
Where to?
Anders Pitman
@anderspitman
Apr 08 2016 06:34
run{
    standardInput = System.in
}
add that to cli/build.gradle
then try ./gradlew :cli:run again
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:37
lol
Found a bug on the back end
Anders Pitman
@anderspitman
Apr 08 2016 06:37
uh oh
lies!
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:37
You can't do MAX_TOTAL - currentTotal
I rolled 0 times and got a score of 23
Anders Pitman
@anderspitman
Apr 08 2016 06:37
lol
weird
thought I was checking for 0
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:39
I keep getting exceptions from my scanner too while I'm playing
extremely annoying
Anders Pitman
@anderspitman
Apr 08 2016 06:39
because of gradle?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:39
I have no idea
I was getting it with /cli
./cli
so it can't be gradle
Anders Pitman
@anderspitman
Apr 08 2016 06:39
right
yeah you'll need to figure that out
you're right about the bug though. hehehe
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:40
I hate Java
I miss C++
Anders Pitman
@anderspitman
Apr 08 2016 06:41
really? I love java
so precise and organized
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:41
hahaha
No I like it
Anders Pitman
@anderspitman
Apr 08 2016 06:41
C++ is dangerous
you wouldn't believe how many ways you can shoot yourself in the foot with it
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:42
Yeah I've totally experienced a handful of memory dumps
It's great
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 06:42
hahahhaaa
Anders Pitman
@anderspitman
Apr 08 2016 06:46
    public int getScore() {
        int score;

        int currentTotal = getCurrentTotal();

        if (currentTotal == 0 || currentTotal > MAX_TOTAL) {
            score = 0;
        }
        else if (currentTotal == MAX_TOTAL) {
            score = 2 * MAX_TOTAL;
        }
        else {
            score = MAX_TOTAL - currentTotal;
        }

        return score;
    }
drop that in
and add this unit test while you're at it:
    @Test
    public void testZeroScore() {
        DiceGame game = new DiceGame();

        assertEquals(0, game.getScore());
    }
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:33
Okay done
You still online @anderspitman ?
Anders Pitman
@anderspitman
Apr 08 2016 07:34
yup
for a little bit
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:34
Think it's good for you guys to test
Should I do PR?
Opps
Game over! With a total of 12, your final score is: 11
Should it be 12?
Anders Pitman
@anderspitman
Apr 08 2016 07:36
uh....
maybe?
yeah that's what we decided isn't it...
weird thing is that's not what the code says
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:37
Wouldn't score = currentTotal?
Anders Pitman
@anderspitman
Apr 08 2016 07:38
yeah :D
one minute
this actually solves the earlier problem another way as well
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:39
I decided to nix the "force player to roll with 3 die"... as it felt unnatural in the console...
Anders Pitman
@anderspitman
Apr 08 2016 07:39
public int getScore() {
        int score;

        int currentTotal = getCurrentTotal();

        if (currentTotal > MAX_TOTAL) {
            score = 0;
        }
        else if (currentTotal == MAX_TOTAL) {
            score = 2 * MAX_TOTAL;
        }
        else {
            score = currentTotal;
        }

        return score;
    }
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:39
Basically, If we force the user to roll 3.. there's no point in letting them roll, the computer would just roll for them at first and their first turn would be turn 2.
Anders Pitman
@anderspitman
Apr 08 2016 07:40

    @Test
    public void testGetScoreLessThan23() {

        DiceGame game = new DiceGame();

        try {
            int total = game.roll(3);

            assertEquals(total, game.getScore());
        }
        catch (RollAfterGameOverException e) {
            fail();
        }
    }
that makes sense
funny how you don't get a feel for these things until you actually start writing the code
if you'll copy those in and do a quick smoke test and a PR, I'll review and if all is good merge before bed
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:42
k
Looks good
So, as I'm doing everyhing in the console now
I have you as upstream
What do I do to do PR
I'm googling but you may be faster
Anders Pitman
@anderspitman
Apr 08 2016 07:49
first run this and paste the output for me:
git remote -v
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:49
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (master)
$ git remote -v
origin  https://github.com/mshannahnv/dice-game (fetch)
origin  https://github.com/mshannahnv/dice-game (push)
upstream        https://github.com/anderspitman/dice-game (fetch)
upstream        https://github.com/anderspitman/dice-game (push)
Anders Pitman
@anderspitman
Apr 08 2016 07:49
perfect
ok have you committed anything yet?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:49
No
Anders Pitman
@anderspitman
Apr 08 2016 07:50
k, first thing you need to do is create a branch:
git checkout -b create-cli
or whatever name you want to call it
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:50
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (master)
$ git checkout -b create-cli
M       cli/build.gradle
M       cli/src/main/java/Main.java
M       shared/src/main/java/DiceGame.java
M       shared/src/test/java/TestDiceGame.java
Switched to a new branch 'create-cli'
Anders Pitman
@anderspitman
Apr 08 2016 07:51
cool
did you create any new files or is everything in Main.java?
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:51
All in main
If you guys have suggestions I can edit tomorrow
there are ~ 4 methods
Anders Pitman
@anderspitman
Apr 08 2016 07:52
k, now do git commit -a -m "USEFUL MESSAGE ABOUT WHAT YOU DID HERE"
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:53
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (create-cli)
$ git commit -a -m "Created CLI, updated DiceGame & TestDiceGame with minor bug                         fixes"
[create-cli 45f3e65] Created CLI, updated DiceGame & TestDiceGame with minor bug                         fixes
 4 files changed, 132 insertions(+), 8 deletions(-)
Anders Pitman
@anderspitman
Apr 08 2016 07:54
git push origin create-cli
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:54
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (create-cli)
$ git push origin create-cli
Counting objects: 79, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (60/60), done.
Writing objects: 100% (79/79), 59.76 KiB | 0 bytes/s, done.
Total 79 (delta 17), reused 0 (delta 0)
To https://github.com/mshannahnv/dice-game
 * [new branch]      create-cli -> create-cli
Anders Pitman
@anderspitman
Apr 08 2016 07:55
now hop on github and create the PR
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:55
Ah ok - can't do it through git bash?
Anders Pitman
@anderspitman
Apr 08 2016 07:55
nope, PRs are a github thing. not build into git
sweet
you can do git branch to see your branches and git checkout BRANCH-NAME to switch branches
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 07:58
For some reason I thought I needed to create my branch before I started editing
That's cool that I can do it last
Anders Pitman
@anderspitman
Apr 08 2016 07:59
normally you would. I also like to make small commits as I go, adding unit tests along the way. tests are harder for UI stuff though and I often forgo that
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:00
So, the one bug that I'm aware of is that if you enter anything besides an INT, it will break
When it's expecting 1 2 3 (menu items)
But if you enter 40, it will just prompt you again
So it's not too bad of a fix
I just wanted to get a rough draft in
Is the GUI up?
Anders Pitman
@anderspitman
Apr 08 2016 08:02
cooleo
not sure what the status of the GUI is. I think @hehe876 basically has it done other than the integration with the backend, but we also need to get it integration with the build system
we might have to skip that and just ship it with custom instructions though
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:05
I think we're going to be scrambling up until 5
Anders Pitman
@anderspitman
Apr 08 2016 08:05
hey this is kinda fun!
great job on the UI!!
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:05
Thanks!
I forget how long it takes, even for something so simple
Anders Pitman
@anderspitman
Apr 08 2016 08:06
yeah for real
this is perfect though. even if that's all we deliver this week it'll be great
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:06
Ok good
Can I put the bug that I mentioned in "Issues"
Anders Pitman
@anderspitman
Apr 08 2016 08:07
I'll see if I can figure out how to make gradle package it into a jar
yup go ahead
you can always create as many issues as you'd like
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:07
Nice
I don't want it to be forgotten tomorrow
Anders Pitman
@anderspitman
Apr 08 2016 08:10
merged!
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:10
sweeet
Anders Pitman
@anderspitman
Apr 08 2016 08:11
good work @sarahka7 and @mshannahnv. We can touch base tomorrow on the GUI and decide on our gameplan
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:12
Still need to figure out how to fix the product backlog, too
Goodnight!
Anders Pitman
@anderspitman
Apr 08 2016 08:13
I'll add an issue for that. night!
oh
nvm you got it
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:13
:D
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 08:22
A
Anders Pitman
@anderspitman
Apr 08 2016 14:11
B
Anders Pitman
@anderspitman
Apr 08 2016 17:21
Weekend plans got canceled, so I can help tonight with whatever needs to be done
Hannah Van Den Bosch
@mshannahnv
Apr 08 2016 17:26
Nice
Christiaan Schmid
@chcschmid
Apr 08 2016 17:43
@anderspitman sorry for the delayed response. You can merge #25 if you want. I will be adding more documentation today after the test. Perhaps you can merge it now, and after the test I can practice creating a new branch and initializing a PR correctly.
Anders Pitman
@anderspitman
Apr 08 2016 17:46
@chcschmid actually I just double checked the PR and it looks a little weird. For some reason it's saying you added a couple files that should already be in my master. Can try fetching and merging from upstream and pushing that? You'll probably have a few merge conflicts, but I can help you fix those
just tell me what it says
nvm
you just fixed it
K #25 is merged