These are chat archives for anderspitman/dice-game

9th
Apr 2016
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:15
Do we need to make unit tests for the front end cli
Anders Pitman
@anderspitman
Apr 09 2016 02:19
H
Nah
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:20
I'm attempting to recreate the product backlog
Did the GUI work with gradle?
Nguyen Dao
@ngdao
Apr 09 2016 02:31
I think the score should be (if not > 23) then return current total. That would make it easier for me. What ya think?
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:32
If it's < 23 it's returning current total
Nguyen Dao
@ngdao
Apr 09 2016 02:32
nvm, it won't make it easier for me.
else {
score = MAX_TOTAL - getCurrentTotal();
}
this is the code I got, maybe we've changed it
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:32
You have older code
Did you set anders as upstream
^ Product Backlog
Nguyen Dao
@ngdao
Apr 09 2016 02:38
i'll update right now
Anders Pitman
@anderspitman
Apr 09 2016 02:48
@mshannahnv backlog looks great. The scorekeeper stuff still seems weird to me but if they like it then whatever. Maybe add a couple for "As a user I want to have a console interface..." and "As a user I want to have a graphical user interface..." or something like that?
@hehe876 do you have the latest version of the GUI so I can play around with building it in gradle?
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:49
We're putting the GUI off until next week right?
Anders Pitman
@anderspitman
Apr 09 2016 02:50
No it's mostly working, but we'll probably ship it as a jar this week because we're not sure how to integrate with gradle yet
actually I think what I'll do right now is work on packaging the cli as a jar as well. That way they can look at our code, but they don't have to build it unless they want to
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:51
I'm not sure how to include the console and GUI as a user story
Nguyen Dao
@ngdao
Apr 09 2016 02:52
i'll write the user story for the GUI
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:53
I don't mind doing it, I have the excel open
Anders Pitman
@anderspitman
Apr 09 2016 02:53
Does it not really work? I'm still not super clear on user stories. So the whole thing for the cli would be: "As a player, I want to have a console interface so I can play the game from the command line"
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:53
That's good actually
I want to have a graphical user interface so that I can easily play the game.
?
Anders Pitman
@anderspitman
Apr 09 2016 02:58
"I want to have a graphical user interface to impress the TAs"
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:58
looolll
Anders Pitman
@anderspitman
Apr 09 2016 02:58
"I want to have a graphical user interface because it's 2016"
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:58
Hey man text based games are totally on trend
Anders Pitman
@anderspitman
Apr 09 2016 02:58
"I want to have a graphical user interface because I deserve it. Murica"
"I want to have a graphical user interface so we can prove Eric's actually doing something"
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:59
I'm a bit concerned about the backlog "Estimate" column
Anders Pitman
@anderspitman
Apr 09 2016 02:59
@hehe876 ;)
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 02:59
it's supposed to add up to a week
and it's going over a week
Anders Pitman
@anderspitman
Apr 09 2016 03:00
use fractional days?
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:01
good idea
Ok
Think it's done!
The dependencies column confuses me
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:07
Opps wrong Product Backlog
I can't cancel a PR can I
Anders Pitman
@anderspitman
Apr 09 2016 03:11
yeah you can
easy peasy
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:14
Okay
I edited the backlog
and the commited
and then I did further edits (before PR)
and wanted to recommit
and it's not letting me
How can I fix this
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (product-backlog)
$ git commit -a -m "Minor Product Backlog changes"
On branch product-backlog
Untracked files:
        cli/build/
        cli/src/main/java/Main.class
        doc/Product Backlog.pdf
        shared/build/

nothing added to commit but untracked files present
Anders Pitman
@anderspitman
Apr 09 2016 03:22
what do you mean "further edits before PR"?
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:23
I commited
Anders Pitman
@anderspitman
Apr 09 2016 03:23
go a git status
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:23
and then you mentioned that you wanted two more lines in the backlog
so I made further edits
I did git commit --amend
and it let me commit
but it's giving me a warning
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (product-backlog)
$ git commit --amend
[product-backlog 60a50d5] Replaced product backlog with correct format
 Date: Fri Apr 8 19:49:01 2016 -0700
warning: LF will be replaced by CRLF in cli/build/install/cli/bin/cli.
The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in cli/build/scripts/cli.
The file will have its original line endings in your working directory.
 22 files changed, 504 insertions(+), 20 deletions(-)
 create mode 100644 cli/build/classes/main/Main.class
 create mode 100644 cli/build/install/cli/bin/cli
 create mode 100644 cli/build/install/cli/bin/cli.bat
 create mode 100644 cli/build/install/cli/lib/cli.jar
 create mode 100644 cli/build/install/cli/lib/commons-lang3-3.3.2.jar
 create mode 100644 cli/build/install/cli/lib/opencsv-3.7.jar
 create mode 100644 cli/build/install/cli/lib/shared.jar
 create mode 100644 cli/build/libs/cli.jar
 create mode 100644 cli/build/scripts/cli
 create mode 100644 cli/build/scripts/cli.bat
 create mode 100644 cli/build/tmp/jar/MANIFEST.MF
 create mode 100644 cli/src/main/java/Main.class
 delete mode 100644 doc/Product Backlog.md
 create mode 100644 doc/Product Backlog.pdf
 create mode 100644 shared/build/classes/main/Driver.class
 create mode 100644 shared/build/classes/main/dice/DiceGame.class
 create mode 100644 shared/build/classes/main/dice/Die.class
 create mode 100644 shared/build/classes/main/dice/RollAfterGameOverException.class
 create mode 100644 shared/build/classes/main/dice/RollRecord.class
 create mode 100644 shared/build/classes/main/dice/StatsProcessor.class
 create mode 100644 shared/build/libs/shared.jar
 create mode 100644 shared/build/tmp/jar/MANIFEST.MF
I'm afraid of that "LF will be replaced by CRLF"..
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:32
I'm just going to start over
Anders Pitman
@anderspitman
Apr 09 2016 03:33
ah
the only time you ever want to amend that I know of is when you want to change a commit message
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:34
I jsut reset --hard
Anders Pitman
@anderspitman
Apr 09 2016 03:34
normally if you want to change something just do a new commit. You can have multiple commits in a single push
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:34
For some reason it wasn't allowing me to
Anders Pitman
@anderspitman
Apr 09 2016 03:34
be careful with that
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:34
Said I had unchecked files
Anders Pitman
@anderspitman
Apr 09 2016 03:34
I've lost a lot of work doing reset hard
you'll almost always have unchecked files. That just means temporary files we don't want added to git, like .class files
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:35
Hannah@Hannah-PC MINGW64 ~/Documents/Github/dice-game (product-backlog)
$ git status
On branch product-backlog
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        doc/Product Backlog.pdf

nothing added to commit but untracked files present (use "git add" to track)
Anders Pitman
@anderspitman
Apr 09 2016 03:35
they change every time you build and are generated from the source files so it doesn't make sense to commit them
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:36
Should I do git add Product Backlog.pdf
Anders Pitman
@anderspitman
Apr 09 2016 03:36
it would be best not to commit a pdf if we can avoid it. A text file would be better
you can't do diffs on pdfs
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:37
like a .doc?
I just need a table format
Wasn't sure what to do
Anders Pitman
@anderspitman
Apr 09 2016 03:37
you can do tables in markdown
"GFM" stands for Github Flavored Markdown
fyi
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:41
is @chcschmid finishing the documentation on getRollValue()?
and then do I need to fix the bug that allows string inputs - or do we think the TAs won't try to kill our program?
Anders Pitman
@anderspitman
Apr 09 2016 03:43
Not sure what @chcschmid's status is. I can add the javadoc if necessary
I'd say either fix it or document it somewhere they can see it
but it's not critical. we just need to ship something, it doesn't have to be bulletproof
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:44
Right
Anders Pitman
@anderspitman
Apr 09 2016 03:45
ok I got the cli building as a jar. I think I'm falling in love with the java software ecosystem. everything is so easy and tidy
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:45
Nice
So we don't think we should put off the GUI for next week? We're really getting down to the wire here and it hasn't been fully tested by the group.
Anders Pitman
@anderspitman
Apr 09 2016 03:46
I say we ship what we have. @hehe876 what's the status?
he showed it to me earlier and it was basically working
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:47
I just know that Week 2 states 'Code should compile without errors'
Anders Pitman
@anderspitman
Apr 09 2016 03:47
It does
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:47
and if something is rushed out
Anders Pitman
@anderspitman
Apr 09 2016 03:48
well I'm also concerned that @hehe876 has hardly committed anything, even though he's done all this work
we need to at least get the code in there somewhere so they can see what we've got cookin
@/all #33 needs a quick review if someone could do that
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 03:49
Looks good
Anders Pitman
@anderspitman
Apr 09 2016 03:52
Also @sarahka7 do you think you could throw your pseudocode in a text file and add it to the doc directory? Good to show them you were involved with the design of the CLI
should be able to do it through the github interface. Just create a text file at https://github.com/sarahka7/dice-game and do a PR
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 04:01
@anderspitman can you revire $34
#34
review
5 commits later
:)
Anders Pitman
@anderspitman
Apr 09 2016 04:02
lol
merged
Just need to update the README to point the TAs there. They can download the CLI jar and run it directly
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 04:17
@anderspitman please review #35
Easy fix actually, thank goodness
Can we delete the rule that says the first turn has to be 3 dice?
at least for this deliverable
Since the CLI doesn't set that restriction
Don't know about the GUI
Anders Pitman
@anderspitman
Apr 09 2016 04:28
I don't think the GUI does either. We can remove it
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 04:28
I'm editing it now
Anders Pitman
@anderspitman
Apr 09 2016 04:31
Fix looks good. Just had one refactoring request
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 04:36
?
Did you post it somewhere?
oh I see
sarahka7
@sarahka7
Apr 09 2016 04:42
@anderspitman sure, ill do that now
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 04:47
@anderspitman Should be good
wait
Anders Pitman
@anderspitman
Apr 09 2016 04:49
@mshannahnv couple things: You don't have to start a new PR to address review comments. Just commit your changes on the same branch and push them. Github will automatically update to reflect the latest in the PR
Also you broke it ;)
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 04:50
Yeah I forgot a scanner in the new function
Anders Pitman
@anderspitman
Apr 09 2016 04:50
you can run ./gradlew check locally to run everything Travis does so you have a better idea if it'll break when you push
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 04:51
:thumbsup:
Good to know about not needing to PR
sarahka7
@sarahka7
Apr 09 2016 04:52
@anderspitman okay pls let me know if I did that right. I initiated from my sarahka7/dicegame.
Anders Pitman
@anderspitman
Apr 09 2016 04:55
@sarahka7 almost. You did the PR on your repo, but you needed to do it on mine. Normally if you push code github automatically pops up a big green button so it's hard to miss. Actually maybe I should just walk you through that process anyway, since we need to update your master (I noticed it's out of date). Do you have your dice-game repo up and running in cygwin yet?
@mshannahnv beautiful. Now if we need to change that error message it only has to happen in one place
@sarahka7 if you don't have time to go through that now that's fine. We should be able to do a PR directly from github even if your master is out of date, because there won't be any conflicts
Anders Pitman
@anderspitman
Apr 09 2016 05:01
btw guys I came across this. Not sure if I posted it yet but looks pretty good: https://guides.github.com/introduction/flow/
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:01
I saw those guides the other day
They look great
sarahka7
@sarahka7
Apr 09 2016 05:01
@anderspitman Its all good i have time- just installing cygwin on my desktop real quick then a walkhru would be great!
Anders Pitman
@anderspitman
Apr 09 2016 05:02
@sarahka7 cooleo
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:02
Please review #38 - finished @chcschmid 's documentation
We have an hour left - GUI? lol
Anders Pitman
@anderspitman
Apr 09 2016 05:03
was just about to say
probably no GUI at this point
They can see that Eric's PR is in, so they know we're working on it
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:04
So, we should update the "how to build" area to exclude it?
Anders Pitman
@anderspitman
Apr 09 2016 05:04
yeah, I can do that
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:04
I'm going to submit our github link so we don't forget
Anders Pitman
@anderspitman
Apr 09 2016 05:04
I'll include instructions for downloading the jar release of the CLI as well
good idea
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:05
Also, I'll push the GUI down to week 3 on the backlog.
I don't want them dinging for that
Anders Pitman
@anderspitman
Apr 09 2016 05:05
k
sarahka7
@sarahka7
Apr 09 2016 05:07
@anderspitman okay terminal up i have $ prompt
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:08
There's no submission link for Deliverable 2.
Christiaan Schmid
@chcschmid
Apr 09 2016 05:10
Hey guys. Sorry for the delay. Got slammed at the data center with configuring priority servers for work. @mshannahnv Thanks for helping me with the documentation. Sorry for dropping the ball...
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:10
It was super easy 2 minute fix :) NP
Christiaan Schmid
@chcschmid
Apr 09 2016 05:10
Are any of you using Sublime Text?
Anders Pitman
@anderspitman
Apr 09 2016 05:11
@sarahka7 go to wherever you want your repo to live and do git clone https://github.com/anderspitman/dice-game
it will create a dice-game directory
Christiaan Schmid
@chcschmid
Apr 09 2016 05:11
I found a sweet package for doing documentation. DockBlockr.
Anders Pitman
@anderspitman
Apr 09 2016 05:12
also @sarahka7 this command line cheat sheet might be helpful: http://cli.learncodethehardway.org/bash_cheat_sheet.pdf
sarahka7
@sarahka7
Apr 09 2016 05:13
Nice! Okay it says done-
Anders Pitman
@anderspitman
Apr 09 2016 05:14
great now cd into dice-game and do git checkout -b add-cli-pseudocode
that will create a new branch named add-cli-pseudocode and change into that branch
sarahka7
@sarahka7
Apr 09 2016 05:17
Ok-
Ready for next
Anders Pitman
@anderspitman
Apr 09 2016 05:18
great, now you need to navigate to that directory in Windows and create a file cli_pseudocode.txt (or whatever you want to call it) in the doc directory
Anders Pitman
@anderspitman
Apr 09 2016 05:24
@mshannahnv yeah I don't see the link either
I just posted on the board
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:25
I'm assuming that they are just going off of the first submission link
Anders Pitman
@anderspitman
Apr 09 2016 05:25
makes sense
Nguyen Dao
@ngdao
Apr 09 2016 05:25
successfully tested the GUI
pretty excited
lol
Anders Pitman
@anderspitman
Apr 09 2016 05:27
nice! do we want to try and squeeze it in for this release? I'm game. Got nothin goin on between now and midnight...
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:27
I'd rather not
I just made the changes to all of the documentation
We did a lot this week
Anders Pitman
@anderspitman
Apr 09 2016 05:27
hm, good points
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:28
It's up to you guys though!
Anders Pitman
@anderspitman
Apr 09 2016 05:28
we could at least push the code and add a jar to the release. I still haven't updated the README yet so I could include instructions for running the gui release
@hehe876 your call. We'll need to work fast if you want to do it
Hannah Van Den Bosch
@mshannahnv
Apr 09 2016 05:29
I pushed #39 and #40 but if you're including the GUI you can close it. It's up to you guys
:D
sarahka7
@sarahka7
Apr 09 2016 05:33
@anderspitman okay copied the file into the doc folder in windows. Do i need to do something in cygwin to comit it for sure?
Anders Pitman
@anderspitman
Apr 09 2016 05:33
yup run git add doc/FILENAME.txt
then git commit -m "Useful message about what you added"
actually hold up
before you run the second one do these:
git config --global user.name sarahka7
git config --global user.email <your-email-address>
sarahka7
@sarahka7
Apr 09 2016 05:51
The configs worked. When i go to add the file im getting an error msg. dice game folder is living on my desktop and i moved the txt file in there (into docs folder).. And im in ~/dice-game in cygwin.. Any ideas
Anders Pitman
@anderspitman
Apr 09 2016 05:53
post the error
sarahka7
@sarahka7
Apr 09 2016 05:55
I put: $git add doc/cli_pseudocode.txt
i get: fatal: pathspec 'doc/cli_pseudocode.txt' did not match any files
Anders Pitman
@anderspitman
Apr 09 2016 05:56
make sure you run it from dice-game
sarahka7
@sarahka7
Apr 09 2016 05:56
In cywgin: circl@DESKTOP-TECC5KD ~/dice-game
Anders Pitman
@anderspitman
Apr 09 2016 05:56
if you're in doc it would just be git add cli_pseudocode.txt
show me the output of ls
sarahka7
@sarahka7
Apr 09 2016 05:58
build.gradle cli doc gradle (and 6 more)
Anders Pitman
@anderspitman
Apr 09 2016 05:59
k now do ls doc
Nguyen Dao
@ngdao
Apr 09 2016 06:04
hmmm, I sent ed JAR file to my friend and he could open it
weird
sarahka7
@sarahka7
Apr 09 2016 06:04
Ahha! I named it with .text.text at end by accident- oops! Okay fixed it. @anderspitman
Anders Pitman
@anderspitman
Apr 09 2016 06:04
cool. make sure it's txt and not text
then run the add and commit from earlier
sarahka7
@sarahka7
Apr 09 2016 06:05
Okay thx just ran the commit- pls lemme know if it went through
Anders Pitman
@anderspitman
Apr 09 2016 06:06
2 more steps :)
sarahka7
@sarahka7
Apr 09 2016 06:07
Okay ready
Anders Pitman
@anderspitman
Apr 09 2016 06:07
do git push origin add-cli-pseudocode, or whatever you named the branch
it'll ask for you github username and pw
sarahka7
@sarahka7
Apr 09 2016 06:10
K almost- im getting msg "permission to anderspitman/dice-game.git denied to sarahka7
Anders Pitman
@anderspitman
Apr 09 2016 06:10
ah, sorry!
I done goofed
but that's ok. you get to learn some ninja tricks while we fix it
sarahka7
@sarahka7
Apr 09 2016 06:11
Fatal: unable to access 'https://github.com/anderspitman/dice-game/': requested url returned error: 403
Anders Pitman
@anderspitman
Apr 09 2016 06:11
git remote rename origin upstream
git remote add origin https://github.com/sarahka7/dice-game
sarahka7
@sarahka7
Apr 09 2016 06:13
Cool, do i need a -m before the third line?
Anders Pitman
@anderspitman
Apr 09 2016 06:13
third line of which?
Nguyen Dao
@ngdao
Apr 09 2016 06:14
@anderspitman what's your email Anders? I'll try to send the JAR file so you can see it
sarahka7
@sarahka7
Apr 09 2016 06:15
sry nm i had typo. I think it went thru now.
Anders Pitman
@anderspitman
Apr 09 2016 06:15
try dragging it into the chat
if that doesn't work tapitman11@gmail.com
there you go
Anders Pitman
@anderspitman
Apr 09 2016 06:16
so there should be a big green "Create Pull Request" button now
@hehe876 jar still isn't working for me
Nguyen Dao
@ngdao
Apr 09 2016 06:17
yeah, the int[] lastRoll is an array that store the last roll [dice1,dice2,dice3] (ie [1,4,0])
maybe you have to install java?
haha
Anders Pitman
@anderspitman
Apr 09 2016 06:17
pretty sure I have java ;)
Nguyen Dao
@ngdao
Apr 09 2016 06:17
sarah
would you mind trying that file?
@sarahka7
Anders Pitman
@anderspitman
Apr 09 2016 06:18

We really only have 2 problems:
1) your PR is breaking the build
2) you commited some files that shouldn't be in git

If you create a new PR with you code in a completely separate directly (like your original PR I believe) and only commit the text files we should be good. We can sort out the details later

Nguyen Dao
@ngdao
Apr 09 2016 06:18
what error does it say @anderspitman ?
Anders Pitman
@anderspitman
Apr 09 2016 06:19
I posted it on github
check the comments of your PR
sarahka7
@sarahka7
Apr 09 2016 06:20
Sure- okay so do i need to click a green pull request btn somewhere to finish the pr ?
Anders Pitman
@anderspitman
Apr 09 2016 06:20
yup
Nguyen Dao
@ngdao
Apr 09 2016 06:20
UnsupportedClassVersion? we may not be using the same java version? lol
Anders Pitman
@anderspitman
Apr 09 2016 06:21
I'm on 7
I'd be surprised if that were the issue
You using java 8 it looks like? There's a good chance the TA's won't have that
I could be wrong about that, but 7 would be safer. Is there any way you can build it with java 7?
Nguyen Dao
@ngdao
Apr 09 2016 06:23
I'll have a look
Anders Pitman
@anderspitman
Apr 09 2016 06:23
I doubt you're using any java8 features so it should still build. just need to tell it to use 7
Honestly I think we'd be better off waiting on the GUI at this point
we don't have time to update the docs
@sarahka7 what's your status? we're almost done
sarahka7
@sarahka7
Apr 09 2016 06:28
I created a pr- but did i set up he right base/head fork?
Anders Pitman
@anderspitman
Apr 09 2016 06:29
I don't see the new PR anywhere
just the one from 2 hours ago
If you go here there should be a big green button: https://github.com/sarahka7/dice-game
in the middle of the page
I think off to the right
sarahka7
@sarahka7
Apr 09 2016 06:30
okay i see "new pull request" so click that one right?
Anders Pitman
@anderspitman
Apr 09 2016 06:31
or maybe left
no not that one
"Create pull request"
it's not always there. usually just right after you push
sarahka7
@sarahka7
Apr 09 2016 06:31
Hmmm, not seeing it
Anders Pitman
@anderspitman
Apr 09 2016 06:32
weird. I'm also seeing your branch way behind upstream. that doesn't make any sense. we just got it fresh
ok you can try the "new pull request" button. but you'll need to use the dropdowns to select your pseudocode branchd and my master branch. give it a shot
@hehe876 installed java8 and your jar is working
sarahka7
@sarahka7
Apr 09 2016 06:34
are u base fork and im head or other way around?
Anders Pitman
@anderspitman
Apr 09 2016 06:35
yup
sarahka7
@sarahka7
Apr 09 2016 06:38
Mssg "there isnt anything to compare"
Anders Pitman
@anderspitman
Apr 09 2016 06:38
@sarahka7 any luck?
sarahka7
@sarahka7
Apr 09 2016 06:38
Switched the forks but also no differences detected
Anders Pitman
@anderspitman
Apr 09 2016 06:39
what did you call the pseudocode file?
sarahka7
@sarahka7
Apr 09 2016 06:39
cli_pseudocode.txt
Anders Pitman
@anderspitman
Apr 09 2016 06:40
ah ok your push didn't go through
do the git push origin BRANCH_NAME again
it should ask for your password
can you just run the commands and then post the output here?
Nguyen Dao
@ngdao
Apr 09 2016 06:42
I think I removed the JAVA8 feature
Anders Pitman
@anderspitman
Apr 09 2016 06:43
@hehe876 great now I have to figure out how to revert to java7 ;)
Nguyen Dao
@ngdao
Apr 09 2016 06:43
hahaha
the REAL version control problem
We can just tell them to install java8, not like it that hard! lol
Anders Pitman
@anderspitman
Apr 09 2016 06:44
I agree
it's been out for 2 years
reasonable requirement
sarahka7
@sarahka7
Apr 09 2016 06:44
git push origin add-cli-psuedocode
Anders Pitman
@anderspitman
Apr 09 2016 06:45
the gui looks great btw
@sarahka7 what happens when you run that? it still hasn't pushed anything to github
sarahka7
@sarahka7
Apr 09 2016 06:46
Get --- fatal:unable to access 'https://girhub.com/sarahka7/difegame
Anders Pitman
@anderspitman
Apr 09 2016 06:46
ah
you have a type in your remote
sarahka7
@sarahka7
Apr 09 2016 06:46
...illegal characters found in url
Anders Pitman
@anderspitman
Apr 09 2016 06:46
git remote rm origin
sarahka7
@sarahka7
Apr 09 2016 06:46
K
Anders Pitman
@anderspitman
Apr 09 2016 06:47
git remote add origin https://github.com/sarahka7/dice-game
copy and post that last one
paste**
then do the push again
Nguyen Dao
@ngdao
Apr 09 2016 06:47
has anyone submit the thing...
Anders Pitman
@anderspitman
Apr 09 2016 06:47
there's no submit link. we're assuming they're just using the link from deliverable 1
Nguyen Dao
@ngdao
Apr 09 2016 06:48
okay
Anders Pitman
@anderspitman
Apr 09 2016 06:49
Once we get Sarah's pseudocode in that's it for this week. Leave #43 in place so they can see we're working on the gui. I'll upload the gui jar to our release page
Nguyen Dao
@ngdao
Apr 09 2016 06:49
cool
great work everybody!
sarahka7
@sarahka7
Apr 09 2016 06:50
Okay i typed: git push origin add-cli-pseudocode
Anders Pitman
@anderspitman
Apr 09 2016 06:51
didn't work. output?
sarahka7
@sarahka7
Apr 09 2016 06:51
got error: src refspec add-cli-pseudocode does match any. Failed to push some refs to https://github.com/sarahka7/dice-game
Anders Pitman
@anderspitman
Apr 09 2016 06:52
git branch
post output
sarahka7
@sarahka7
Apr 09 2016 06:52
*add-cli-psuedocode (in green)
master (in white)
Anders Pitman
@anderspitman
Apr 09 2016 06:53
you spelled pseudo wrong
no biggie
git push origin add-cli-psuedocode
sarahka7
@sarahka7
Apr 09 2016 06:54
Ah yep!! Ok entering pw now
Okay went thu on cygwin!
Counted/compressed/etc
Anders Pitman
@anderspitman
Apr 09 2016 06:57
hit the PR button!
merged!
sarahka7
@sarahka7
Apr 09 2016 06:58
phew! Great!
Anders Pitman
@anderspitman
Apr 09 2016 06:58
can you do a 10 second review of this: anderspitman/dice-game#44
sarahka7
@sarahka7
Apr 09 2016 06:58
Yeah
Anders Pitman
@anderspitman
Apr 09 2016 07:00
too late, I merged it ;)
sarahka7
@sarahka7
Apr 09 2016 07:00
Ok looks good
Anders Pitman
@anderspitman
Apr 09 2016 07:00
abusing my powers
sarahka7
@sarahka7
Apr 09 2016 07:00
Haha
Anders Pitman
@anderspitman
Apr 09 2016 07:00
we probably could have gotten away with it, but technically they won't count any work after midnight
sarahka7
@sarahka7
Apr 09 2016 07:01
Ok good- got my pr in just in time- lol
Anders Pitman
@anderspitman
Apr 09 2016 07:01
You should download the GUI from here and play a couple rounds. Eric did an awesome job
sarahka7
@sarahka7
Apr 09 2016 07:01
I appreciate the walkthru and ur patience!!!
Yes i will try it!
Anders Pitman
@anderspitman
Apr 09 2016 07:02
no worries. it's a lot of information. the good news is we went through almost every command you'll need
one more thing though. to complete the circle of life you need to update your master now that everything has been merged:
git checkout master
git pull upstream master
sarahka7
@sarahka7
Apr 09 2016 07:04
nice - okay did it.
"to complete the circle of life" --lol.
Anders Pitman
@anderspitman
Apr 09 2016 07:04
great. if you do a git log you should see your commit towards the top
actually it's about 7 down, but the merge is close to the top
sarahka7
@sarahka7
Apr 09 2016 07:06
ah, i see it- very good!
Anders Pitman
@anderspitman
Apr 09 2016 07:06
anyhow, great work @/all . we accomplished all our goals this week. next week we can focus on the stats and getting the GUI integrated into the build system
@sarahka7 excellent
alright, bedtime. night!
sarahka7
@sarahka7
Apr 09 2016 07:07
thx again- gnight!