These are chat archives for anderspitman/dice-game

15th
Apr 2016
Anders Pitman
@anderspitman
Apr 15 2016 00:02 UTC
If we want to use the name as an ID, the UI will need to keep track of it. As I think about it maybe we should use Integer IDs
Nguyen Dao
@ngdao
Apr 15 2016 00:09 UTC
doesn't a game(DiceGame) have a player and an ID?
or that's for the database
how do we generate dose?
those*
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 00:11 UTC
We need to prompt the user for a name and then store it in Anders' back end
Nguyen Dao
@ngdao
Apr 15 2016 00:12 UTC
yeah, but what class to we store it in
also, having trouble running the project
```FAILURE: Build failed with an exception.
  • What went wrong:
    Java home supplied via 'org.gradle.java.home' is invalid. Invalid directory: /usr/lib/jvm/java-8-oracle```
FAILURE: Build failed with an exception.

* What went wrong:
Java home supplied via 'org.gradle.java.home' is invalid. Invalid directory: /usr/lib/jvm/java-8-oracle
Anders Pitman
@anderspitman
Apr 15 2016 00:13 UTC
Ah crap
That's only going to work on my machine. What was I thinking
Nguyen Dao
@ngdao
Apr 15 2016 00:14 UTC
haha
Anders Pitman
@anderspitman
Apr 15 2016 00:14 UTC
@hehe876 you're right we don't currently have a way to tell the back end the user name
Nguyen Dao
@ngdao
Apr 15 2016 00:15 UTC
yeah, and the game ID also
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 00:15 UTC
Probably pass a parameter for dice game
If that works?
Nguyen Dao
@ngdao
Apr 15 2016 00:15 UTC
I'm thinking we should add it to DiceGame.java
that object should hold those information
at least it should create a player class
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 00:16 UTC
Game id could be assigned in the back end
Nguyen Dao
@ngdao
Apr 15 2016 00:16 UTC
Or the player class would create a dicegame class
game id can just be the order in which it is inserted to the database?
that way it's an integer?
Anders Pitman
@anderspitman
Apr 15 2016 00:18 UTC
gameId will be handled by the backend
UI doesn't need to worry about it
Nguyen Dao
@ngdao
Apr 15 2016 00:18 UTC
yep
I'm thinking the user have to enter their name (initials) before doing anything else
Anders Pitman
@anderspitman
Apr 15 2016 00:20 UTC
seems reasonable to have the DiceGame constructor require a name?
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 00:20 UTC
Yes
Nguyen Dao
@ngdao
Apr 15 2016 00:20 UTC
I'd say so
more user stories incoming lol
Anders Pitman
@anderspitman
Apr 15 2016 00:31 UTC
It would actually be really helpful if someone could take ownership of the scrum side of things, making sure our user stories and Sprint stuff and everything are in order. I don't know much about that stuff
I'm planning to focus on this tonight. I'd rather not spend my Friday night on it again
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 00:43 UTC
Which user stories need to be added?
Nguyen Dao
@ngdao
Apr 15 2016 00:52 UTC
isn't Sarah in charge of the documentation?
I think something along the line of "As a user I would like to enter my name so that I can identify my score"
Let me know when you fix the gradle @anderspitman
tonight is a good night for google hang out lol
Anders Pitman
@anderspitman
Apr 15 2016 01:23 UTC
k I'm on it
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 01:26 UTC
That's already a user story I think
I hope it's in there!
We should've covered everything
Anders Pitman
@anderspitman
Apr 15 2016 01:31 UTC
#52 should fix it if someone can review
Christiaan Schmid
@chcschmid
Apr 15 2016 01:44 UTC
This message was deleted
c:\Users\Chin\Google Drive\School\ASU\CSE 360\dice-game>gradlew :cli:run
:shared:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':shared:compileJava'.
> Could not find tools.jar

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 9.66 secs
@anderspitman , this is the error I get when I try to run the CLI
Anders Pitman
@anderspitman
Apr 15 2016 01:47 UTC
@chcschmid what happens if you just run gradlew check?
Christiaan Schmid
@chcschmid
Apr 15 2016 01:48 UTC
same error
second answer
Anders Pitman
@anderspitman
Apr 15 2016 01:53 UTC
need to write a method to make sure the username is legal. Should I call it validateUsername or verifyUsername?
Christiaan Schmid
@chcschmid
Apr 15 2016 01:56 UTC
I did used the third answer and it seems to work. gradlew check still fails, but I can now play the game fine
  • I used
Anders Pitman
@anderspitman
Apr 15 2016 01:56 UTC
post the error on check. that needs to work
Christiaan Schmid
@chcschmid
Apr 15 2016 01:57 UTC
FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':shared:testCompileClasspath'.
> Could not download junit.jar (junit:junit:4.12)
   > Could not get resource 'https://jcenter.bintray.com/junit/junit/4.12/junit-4.12.jar'.
      > Failed to move file 'C:\Users\Chin\AppData\Local\Temp\gradle_download6768917511763632644bin' into filestore at 'C:\Users\Chin\.gradle\caches\modules-2\files-2.1\junit\junit\4.12\2973d150c0dc1fefe998f834810d68f278ea58ec\junit-4.12.jar'

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 17.033 secs
Anders Pitman
@anderspitman
Apr 15 2016 01:58 UTC
hm
possibly a permissions issue
delete the folder 'C:\Users\Chin\AppData\Local\Temp\gradle_download6768917511763632644bin' and try again
that should hopefully get you a fresh gradle
Christiaan Schmid
@chcschmid
Apr 15 2016 02:01 UTC
bueno
Anders Pitman
@anderspitman
Apr 15 2016 02:01 UTC
really?
Christiaan Schmid
@chcschmid
Apr 15 2016 02:05 UTC
Just played using the GUI for the first time. It looks great!
Anders Pitman
@anderspitman
Apr 15 2016 02:20 UTC
#54 needs a review. #53 still does as well
Anders Pitman
@anderspitman
Apr 15 2016 02:53 UTC
#49 needs a re-review since I added some stuff
Nguyen Dao
@ngdao
Apr 15 2016 03:13 UTC
what does ```.builder() do?
Anders Pitman
@anderspitman
Apr 15 2016 03:14 UTC
follow the link in the code
it's the builder pattern
Nguyen Dao
@ngdao
Apr 15 2016 03:15 UTC
why use a .create() method instead of constructors?
for mock test?
Anders Pitman
@anderspitman
Apr 15 2016 03:15 UTC
gives more control over the process
it's not completely necessary here, but I found myself doing a bunch of renaming in the unit tests and hope this might avoid that somewhat in the future
Nguyen Dao
@ngdao
Apr 15 2016 03:21 UTC
does it not set this.username = username
private DiceGame(String username) {
          currentTotal = 0;
          die = new Die();
      }
(from #54 )
Anders Pitman
@anderspitman
Apr 15 2016 03:23 UTC
good catch!
added unit tests...
adding**
Nguyen Dao
@ngdao
Apr 15 2016 03:24 UTC
need a setter for the user name too
```bash
Anders Pitman
@anderspitman
Apr 15 2016 03:24 UTC
should just need a getter, if that, right?
it's set in the constructor
Nguyen Dao
@ngdao
Apr 15 2016 03:24 UTC
yeah that's true
Anders Pitman
@anderspitman
Apr 15 2016 03:24 UTC
or more specifically in the create() call
Nguyen Dao
@ngdao
Apr 15 2016 03:24 UTC
hmmm
yeah
will need a getter
i'll type it here
Anders Pitman
@anderspitman
Apr 15 2016 03:25 UTC
yeah I need it for the test anyway so I'm adding it
Nguyen Dao
@ngdao
Apr 15 2016 03:25 UTC
public String getUsername() {
return this.username;
}
Anders Pitman
@anderspitman
Apr 15 2016 03:26 UTC
thx
Nguyen Dao
@ngdao
Apr 15 2016 03:27 UTC
which PR did you fix the gradle? Or is merged already?
is it*
Anders Pitman
@anderspitman
Apr 15 2016 03:27 UTC
#53 not merged yet needs review
Nguyen Dao
@ngdao
Apr 15 2016 03:32 UTC
I don't see a PR #53, 53 is an issue
Anders Pitman
@anderspitman
Apr 15 2016 03:33 UTC
my bad
@chcschmid pulled a fast one on me
Nguyen Dao
@ngdao
Apr 15 2016 03:33 UTC
but how come Chris can run it just fine, is he using linux?
Anders Pitman
@anderspitman
Apr 15 2016 03:33 UTC
#52
Nguyen Dao
@ngdao
Apr 15 2016 03:33 UTC
lol
Anders Pitman
@anderspitman
Apr 15 2016 03:42 UTC
k @hehe876 #54 is ready for another review pass
Nguyen Dao
@ngdao
Apr 15 2016 03:44 UTC
else if (username.length() < VALID_LENGTH) {
             String message = "Username '" + username + "' too short";
             throw new InvalidUsernameException(message);
         }
why are there 3 quotation mark ending the strings. and probably should add "is too short"
nvm i got the 3 marks thing
Anders Pitman
@anderspitman
Apr 15 2016 03:45 UTC
go ahead and put review comments directly on github
you can comment directly on the code
Anders Pitman
@anderspitman
Apr 15 2016 03:51 UTC
@hehe876 @mshannahnv as soon as #49 is merged you should be able to start displaying the dummy stats data. I'm working on the real version now
Anders Pitman
@anderspitman
Apr 15 2016 04:11 UTC
@chcschmid are you currently working on the CSV stuff? I'm thinking about how to split this up into classes
Christiaan Schmid
@chcschmid
Apr 15 2016 04:12 UTC
I'm trying to, but struggling to figure out how to test it within our classes that we have
Anders Pitman
@anderspitman
Apr 15 2016 04:13 UTC
yeah I can see why that might be an issue
let's get you up and running with a workflow
I'm throwing together a little UML right now
Christiaan Schmid
@chcschmid
Apr 15 2016 04:15 UTC
sounds good
Nguyen Dao
@ngdao
Apr 15 2016 04:16 UTC
if you're in a brach, and you do a git merge master, and master have the new file, does it add the new file to your branch?
Anders Pitman
@anderspitman
Apr 15 2016 04:17 UTC
yep
Anders Pitman
@anderspitman
Apr 15 2016 04:24 UTC
@chcschmid the more I think about it the CSV stuff is definitely the trickier of the 2 tasks we have to accomplish, especially when it comes to unit testing file IO stuff. Are you interested in swapping and working on the stats processing instead? Basically you need to take a list of RollRecord and compute each of the stats from it. If you'd rather stick with the file stuff that's ok
you can also think of it as RollRecord[] -> StatsData
Christiaan Schmid
@chcschmid
Apr 15 2016 04:27 UTC
No we can switch. It's kinda going over my head.
Anders Pitman
@anderspitman
Apr 15 2016 04:28 UTC
Well a lot of the problem is that I didn't architect it very well up front
Are you sure? If you were excited about doing the CSV stuff that's fine it'll just take a little bit more work getting things set up for you
I'm fine working on either part
Christiaan Schmid
@chcschmid
Apr 15 2016 04:32 UTC
I'll give the RollRecord a shot. I'm interested in the CSV but I don't know if I could finish it before tomorrow night
Anders Pitman
@anderspitman
Apr 15 2016 04:33 UTC
k
give me 15 minutes to set you up with a testbed
Christiaan Schmid
@chcschmid
Apr 15 2016 04:33 UTC
sounds good
Anders Pitman
@anderspitman
Apr 15 2016 04:34 UTC
we're going to be working together off the stats branch. See if you can do git checkout upstream/stats and then do git diff master and you should see changes from master
Christiaan Schmid
@chcschmid
Apr 15 2016 04:37 UTC
error: pathspec 'upstream/stats' did not match any file(s) known to git.
Anders Pitman
@anderspitman
Apr 15 2016 04:37 UTC
show me git remote -v
Christiaan Schmid
@chcschmid
Apr 15 2016 04:37 UTC
origin  https://github.com/chcschmid/dice-game.git (fetch)
origin  https://github.com/chcschmid/dice-game.git (push)
upstream        https://github.com/anderspitman/dice-game (fetch)
upstream        https://github.com/anderspitman/dice-game (push)
Anders Pitman
@anderspitman
Apr 15 2016 04:38 UTC
how about
git fetch upstream
git checkout upstream/stats
if I had a nickel....
Nguyen Dao
@ngdao
Apr 15 2016 04:40 UTC
Error: Could not find or load main class DiceGameGUI
:gui:run FAILED
Christiaan Schmid
@chcschmid
Apr 15 2016 04:40 UTC
So now any changes I make will be applied to that branch?
Nguyen Dao
@ngdao
Apr 15 2016 04:41 UTC
can't run gui for some reason
Anders Pitman
@anderspitman
Apr 15 2016 04:41 UTC
@chcschmid you'll still do PRs, but you'll do them against that branch
so you'll branch off of that branch
locally
and when you do the PR on github, rather than using the big green button I think you create the PR manually and choose which branch you want to PR to
@hehe876 make 100% sure you're on a clean master
Nguyen Dao
@ngdao
Apr 15 2016 04:47 UTC
hah, weird
when I do a diff there's are differences
but when I merge it's say already up to date
Anders Pitman
@anderspitman
Apr 15 2016 04:52 UTC
up to date just means there's nothing extra in the branch you're trying to merge into the branch you're on. doesn't mean you haven't added anything
in the branch you're on
@chcschmid I'm almost ready
Nguyen Dao
@ngdao
Apr 15 2016 04:53 UTC
but after I merge, the diff is still there
Anders Pitman
@anderspitman
Apr 15 2016 04:53 UTC
yeah
that means the branch your on has extra stuff compared to the one you're trying to merge in
you're**
Nguyen Dao
@ngdao
Apr 15 2016 04:54 UTC
oh ok
gottem!
thanks man
Nguyen Dao
@ngdao
Apr 15 2016 05:04 UTC
swear to god most time are spent dealing with git hub haha
Anders Pitman
@anderspitman
Apr 15 2016 05:04 UTC
be careful not to blame github for git's issues
github actually makes git a lot easier to use
Nguyen Dao
@ngdao
Apr 15 2016 05:05 UTC
haha, they're all evil!
Anders Pitman
@anderspitman
Apr 15 2016 05:07 UTC
haha
@chcschmid I lied. It's getting there though
Nguyen Dao
@ngdao
Apr 15 2016 05:20 UTC
how do you guys plan to know when a game end?
Anders Pitman
@anderspitman
Apr 15 2016 05:30 UTC
score >= 23
actually no
total >= 23
because score can be 0
sorry I forgot about your PR
merged it
Anders Pitman
@anderspitman
Apr 15 2016 05:44 UTC
k @chcschmid everything is good to go. sorry that took so long
if you can't work on it tonight no worries
Nguyen Dao
@ngdao
Apr 15 2016 05:48 UTC
@anderspitman can you give me a brief run through how you want us to use the mock data?
Anders Pitman
@anderspitman
Apr 15 2016 05:48 UTC
you bet
Nguyen Dao
@ngdao
Apr 15 2016 05:49 UTC
we're using rollrecord correct?
Anders Pitman
@anderspitman
Apr 15 2016 05:51 UTC
basically if you call StatsProcessor.create() it will give you a StatsProcessor that is polymorphically a MockStatsProcessor under the hood. You can use that StatsProcessor and call methods like getPlayerList, which you then display in the UI
look at (and modify if you need to for testing purposes MockStatsProcessor to see what data is currently in there
Nguyen Dao
@ngdao
Apr 15 2016 05:51 UTC
cool got it
Anders Pitman
@anderspitman
Apr 15 2016 05:51 UTC
you'll never need to touch RollRecord I don't think
Nguyen Dao
@ngdao
Apr 15 2016 05:52 UTC
it's using some CVS, can i just comment them out?
Anders Pitman
@anderspitman
Apr 15 2016 05:53 UTC
hm
I have a better option. I just made #56. It supercedes the previous Mock PR. If you can review it it should have everything you and @chcschmid need to get going
@chcschmid that would mean we can keep working on master as before
it doesn't have any of the CSV stuff in it
If you haven't started reviewing yet hold off for a minute. Need to add one small thing
Anders Pitman
@anderspitman
Apr 15 2016 06:02 UTC
ok clear!
Anders Pitman
@anderspitman
Apr 15 2016 06:08 UTC
Alright @hehe876 if you pull master you should be able to work with the mock stuff
Nguyen Dao
@ngdao
Apr 15 2016 06:12 UTC
coolio
Anders Pitman
@anderspitman
Apr 15 2016 06:34 UTC
@chcschmid the only files you should need to look at are TestStatsProcessor.java, Database.java, and StatsProcessor.java. You'll add your methods to ConcreteStatsProcessor, which you'll unit test in TestStatsProcessor. I already implemented getPlayerList as an example for you. You can add whatever you need to help with testing to MockDatabase
Christiaan Schmid
@chcschmid
Apr 15 2016 06:40 UTC
Sorry about that! I was at the hospital with my wife visiting some friends. Thanks for setting up the example! I'll get working on that and have something ready to go for tomorrow night.
Anders Pitman
@anderspitman
Apr 15 2016 06:40 UTC
no worries
took me forever to put everything together
but I think the architecture is solid now
Christiaan Schmid
@chcschmid
Apr 15 2016 06:42 UTC
You're awesome. Thanks for getting that all ready
Nguyen Dao
@ngdao
Apr 15 2016 06:49 UTC
anyone still up?
Anders Pitman
@anderspitman
Apr 15 2016 06:53 UTC
me
for a little bit
Nguyen Dao
@ngdao
Apr 15 2016 06:56 UTC
yeah, how do you locate conflicts?
Anders Pitman
@anderspitman
Apr 15 2016 06:57 UTC
normally what I do is create a new throwaway branch off the new branch, then try to merge master into the throwaway and see what breaks
Nguyen Dao
@ngdao
Apr 15 2016 06:58 UTC
oh ok
Anders Pitman
@anderspitman
Apr 15 2016 06:58 UTC
oooo the new UI looks all fancy now
just got 2 23's in a row
Nguyen Dao
@ngdao
Apr 15 2016 07:00 UTC
woo
you like it?
Anders Pitman
@anderspitman
Apr 15 2016 07:00 UTC
:clap:
yeah
but my window manager tiles everything so it looks weird, so I'm not getting the full experience
actually that was surprisingly easy to fix
Nguyen Dao
@ngdao
Apr 15 2016 07:03 UTC
alright, that's it for me tonight
g9 guys and gals
Anders Pitman
@anderspitman
Apr 15 2016 07:03 UTC
night. great work! we'll get this merged ASAP tomorrow
doesn't look like there are any real conflicts. all you need to do is merge upstream master and you should be good to go
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 15:12 UTC
If we call StatsProcessor.create() it looks like it's creating a ConcreteStatsProcessor
This message was deleted
    public static StatsProcessor create() {
        Database db = Database.create("concrete");
        return create("concrete", db);
    }
Unless I'm misunderstanding the code
Anders Pitman
@anderspitman
Apr 15 2016 15:49 UTC
Yeah sorry I still need to clean that up. create is overloaded. Call the other one and tell it you want a mock
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 15:50 UTC
public static StatsProcessor create(String type, Database database) {
        if (type.equals("mock")) {
            return new MockStatsProcessor(database);
        }
        else {
            return new ConcreteStatsProcessor(database);
        }
    }
Call that one?
Anders Pitman
@anderspitman
Apr 15 2016 15:50 UTC
Actually let me just fix that right. Even I'm still confused
review #58
if ya would
Anders Pitman
@anderspitman
Apr 15 2016 15:55 UTC
I removed the extra one
wait hold up
I liked #59 more. That way you can just call create() and once the backend is working we don't need to change the frontends to flip the switch
Anders Pitman
@anderspitman
Apr 15 2016 16:04 UTC
@mshannahnv I'm giving you push access. I need to go shower and eat. If #59 looks ok go ahead and merge it so you're not blocked. If there's something wrong with it just use the other create method for now. Look at the unit tests for examples of creating a DB and passing it in
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 16:05 UTC
Thanks @anderspitman
Anders Pitman
@anderspitman
Apr 15 2016 16:06 UTC
np. i'll be back online in a bit
Anders Pitman
@anderspitman
Apr 15 2016 16:27 UTC
@sarahka7 how's the playtesting coming? Have you been able to run it using gradle?
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 16:27 UTC
"public StatsData getTotalStats()" will probably live in the Mock/ConcreteStatsProcessor too, right?
Anders Pitman
@anderspitman
Apr 15 2016 16:28 UTC
I think we're gonna call it getAllStats() but yeah
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 16:28 UTC
ok perfect
Anders Pitman
@anderspitman
Apr 15 2016 16:28 UTC
actually I should add that
Anders Pitman
@anderspitman
Apr 15 2016 16:33 UTC
#60
The data it returns is totally bogus, ie it's not actually an average of the other data
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 16:34 UTC
:thumbsup:
Looks great
Anders Pitman
@anderspitman
Apr 15 2016 16:36 UTC
:+1:
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 16:36 UTC
I merged, feel free to revoke my rights
So if I git pull upstream master, it's not going to freak out about the changes I've made locally?
Anders Pitman
@anderspitman
Apr 15 2016 16:38 UTC
keep em. better not to have a single bottleneck for merging, especially with everyone getting more familiar with PRs and the amount of code coming in picking up. The only thing you need to be a little careful of is that you never want to push to anderspitman/master (probably upstream/master for you). Don't worry too much though. It's hard to mess things up so badly that it can't be fixed
as long as there are no conflicts it will be fine
if there are you need to fix them. it seems scary at first (it puts a bunch of "<<<<<<<<", "HEAD>>>>>" blah blah in your files) but once you've done a couple manual merges it's not too bad
it won't overwrite your local changes though and will warn you if you try to do that
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 16:40 UTC
it merged perfectly
Anders Pitman
@anderspitman
Apr 15 2016 16:41 UTC
cool
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 16:41 UTC
I feel like my Main.java is getting a little large
Not sure if there is a way to break it up
Since it's mostly UI
~200 lines
Anders Pitman
@anderspitman
Apr 15 2016 16:44 UTC
I don't think it's too bad
but feel free to add files in that directory
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 16:45 UTC
Maybe refactoring will be the last week
Anders Pitman
@anderspitman
Apr 15 2016 16:45 UTC
Main.java should be able to see anything you add
yeah if it's not slowing you down we can wait on that
Anders Pitman
@anderspitman
Apr 15 2016 17:02 UTC
for both the CLI and GUI, keep in mind that we'll need to handle cases where there's a long list of players. Currently MockStatsData doesn't simulate this, but feel free to add more data to it. Which reminds me we still need a leader board.
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 17:19 UTC
I'm going to push my progress on CLI statistics
I think it's pretty much finished
for both player and all
Leaderboard will be later this afternoon
Anders Pitman
@anderspitman
Apr 15 2016 17:23 UTC
I think the leaderboard should probably be done in the backend
otherwise you guys will duplicate the effort in the UIs
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 17:23 UTC
For sure
Anders Pitman
@anderspitman
Apr 15 2016 17:23 UTC
we can mock it for now though
what kind of interface are you thinking?
What do you think?
Anders Pitman
@anderspitman
Apr 15 2016 17:27 UTC
the simplest would be to add a getLeaderboard() : String[] to DiceGame. It would just be a list of the leaders. Then if you want more than the name for the UI you can getPlayerStats for each leader
also very flexible
but if we already know what info we want, and it's the same for both UIs, maybe the backend should return LeaderboardPlayer objects which have names and total scores or something
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 17:28 UTC
#61 needs review
Is it normal for my merges from upstream to master show up as commits?
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 17:33 UTC
Or am I doing something funky
Anders Pitman
@anderspitman
Apr 15 2016 17:33 UTC
no that can happen
normally you don't merge upstream very often, unless you know it has something you need for what you're working on. Github can usually automerge everything for you
that was poorly worded
you should always pull the latest upstream/master after PRs are merged. But if you're in the middle of a PR, usually you avoid updating because it just adds work
code for #61 is very sexy
excellent use of methods
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 17:38 UTC
Woo hoo!
Anders Pitman
@anderspitman
Apr 15 2016 17:38 UTC
and the stats look great!
just playtested
:shipit:
@hehe876 is #57 ready for review? I see you fixed the merge conflicts
Nguyen Dao
@ngdao
Apr 15 2016 17:46 UTC
yeah
Anders Pitman
@anderspitman
Apr 15 2016 17:48 UTC
k
finishing up that 230 take home then I'll do it real quick
Anders Pitman
@anderspitman
Apr 15 2016 18:15 UTC
@hehe876 just a couple small comments on github
Anders Pitman
@anderspitman
Apr 15 2016 20:37 UTC
#62 needs review. Mock leaderboard stuff
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 21:20 UTC
Please review #63
Hannah Van Den Bosch
@mshannahnv
Apr 15 2016 23:22 UTC
Nevermind. review #64 :)
User prompt is finished, as is leaderboard
Anders Pitman
@anderspitman
Apr 15 2016 23:31 UTC
Headed home. Can review then. Unless someone else picks it up first