These are chat archives for anderspitman/dice-game

30th
Apr 2016
Anders Pitman
@anderspitman
Apr 30 2016 01:00 UTC
Anders in the house
Nguyen Dao
@ngdao
Apr 30 2016 01:20 UTC
working on improving the animation, it's gonna be sick! Or else I'm gonna be lol
Anders Pitman
@anderspitman
Apr 30 2016 01:20 UTC
hehehe
Christiaan Schmid
@chcschmid
Apr 30 2016 01:55 UTC
@hehe876 How did it go at Ticketmaster?
Nguyen Dao
@ngdao
Apr 30 2016 01:58 UTC
It was great
they're only looking for 1 more spot tho
So my expectation is not so high
haha
Christiaan Schmid
@chcschmid
Apr 30 2016 02:00 UTC
Did you meet with Rich?
Nguyen Dao
@ngdao
Apr 30 2016 02:02 UTC
yeah
and another person
I'd consider it a good interview, whether there're better one or not is up for the dice haha
Anders Pitman
@anderspitman
Apr 30 2016 02:03 UTC
good thing you're our dice expert
sarahka7
@sarahka7
Apr 30 2016 02:04 UTC
hey is now a good time to try forking/cloning Eric's gui?
Nguyen Dao
@ngdao
Apr 30 2016 02:05 UTC
yep
man, you guys gonna love the new animation, i'm so proud :sparkles:
sarahka7
@sarahka7
Apr 30 2016 02:06 UTC
I can't wait to see it!
Anders Pitman
@anderspitman
Apr 30 2016 02:07 UTC
I'm starting my review of @113 now
#113
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 02:08 UTC
Hey @sarahka7 - if you go into the Pull Request Tab, and click on Eric's PR. Near the merge button theres a link that says "view command line instructions"
That's how you can test it
Anders Pitman
@anderspitman
Apr 30 2016 02:09 UTC
46 on my first game :sunglasses:
Nguyen Dao
@ngdao
Apr 30 2016 02:11 UTC
like a balws
Anders Pitman
@anderspitman
Apr 30 2016 02:13 UTC
leaderboard is looking great
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 02:16 UTC
So are we squashing the bugs tonight?
sarahka7
@sarahka7
Apr 30 2016 02:17 UTC
@mshannahnv thanks- so should I be in anderspitman/dice-game looking for that?
Anders Pitman
@anderspitman
Apr 30 2016 02:17 UTC
I say we try to integrate as many of @hehe876 's changes as possible, then work on bugs
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 02:17 UTC
Yep!
Anders Pitman
@anderspitman
Apr 30 2016 02:18 UTC
But honestly a lot of the bugs are just small annoyances. Not much critical that absolutely has to be fixed.
@hehe876 my review of #113 is done. Just one question about the new file on github
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 02:19 UTC
One piece that's missing from the GUI is that the user can't stop and maintain their score
they either get 23 or lose
Anders Pitman
@anderspitman
Apr 30 2016 02:20 UTC
yeah we should fix that
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 02:20 UTC
and Personal Stats: Average rolls per game was coming back incorrect for me this morning
#117
that was both the cli and gui
those are the two big things
Christiaan Schmid
@chcschmid
Apr 30 2016 02:24 UTC
@mshannahnv I'll look at that right now
Anders Pitman
@anderspitman
Apr 30 2016 02:28 UTC
@mshannahnv are you sure the GUI doesn't let you stop early? You should just need to hit the Reset button. Seems to be working for me. You mean it's not clear that you're ending the game?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 02:28 UTC
When you hit reset is it saving the score?
Anders Pitman
@anderspitman
Apr 30 2016 02:29 UTC
The score is saved to the DB after every roll
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 02:29 UTC
Oh
Maybe a popup that says what your final score is
I thought it cleared it out
Or just changing the verbiage of the button
Nguyen Dao
@ngdao
Apr 30 2016 02:31 UTC
alright, so that's one down
Anders Pitman
@anderspitman
Apr 30 2016 02:31 UTC
:shipit:
@chcschmid the average roll bug should be pretty easy to catch with a unit test. Our testing of the stats stuff is really light...
@hehe876 did you fix the bug where it was displaying 92?
Nguyen Dao
@ngdao
Apr 30 2016 02:34 UTC
yeah I did
Anders Pitman
@anderspitman
Apr 30 2016 02:35 UTC
sweet
Nguyen Dao
@ngdao
Apr 30 2016 02:40 UTC
it was my last commit
Christiaan Schmid
@chcschmid
Apr 30 2016 02:42 UTC
@anderspitman How would I do a unit test using the new database that we've created. I don't even know where it is
Anders Pitman
@anderspitman
Apr 30 2016 02:44 UTC
It would be better to catch the bug using the mock stuff (either using MockDatabase or MockStatsProcessor) if possible. If it's not reproducible that way then we might need to write files. I'm already doing that in a few tests, but I'd like to get away from doing file IO in tests as much as possible. Doing that is the reason ./gradlew check -t is broken
Nguyen Dao
@ngdao
Apr 30 2016 02:49 UTC
ALRIGHTY, get ready boiz and gurlz
I'll go afk for half an hour. see ya later
Anders Pitman
@anderspitman
Apr 30 2016 02:54 UTC
LOL
that animation is ridiculous. I love it
sarahka7
@sarahka7
Apr 30 2016 03:02 UTC
okay waiving the white flag of defeat, I've been Googling around, but must be doing something wrong here- I'm still trying to launch eric's gui. Clicked on the pull request (2 ) tab, and see two open ones but am not sure where to go from there. I'm in the Github website trying to do it. Can someone walk me through?
Anders Pitman
@anderspitman
Apr 30 2016 03:03 UTC
no problem
which code are you wanting to try out? he has a couple PRs in right now
sarahka7
@sarahka7
Apr 30 2016 03:04 UTC
the latest gui
Anders Pitman
@anderspitman
Apr 30 2016 03:04 UTC
k
show me the output of git remote
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:04 UTC
#120 is ready for review - CLI visual enhancements
sarahka7
@sarahka7
Apr 30 2016 03:06 UTC
origin
upstream
Anders Pitman
@anderspitman
Apr 30 2016 03:08 UTC
k do these @sarahka7:
git remote add eric https://github.com/ngdao/dice-game
git fetch eric
git checkout eric/Animation
sarahka7
@sarahka7
Apr 30 2016 03:09 UTC
image.png
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:10 UTC
Wait did we implement new scoring rules?
like the triple 111s or whatever
Anders Pitman
@anderspitman
Apr 30 2016 03:10 UTC
@sarahka7 I don't think you executed the remote add command correctly
make sure you paste the whole line
@mshannahnv in eric's latest PR yes, but it's not documented so I'm not sure what all the rules are
the one I've seen activated is rolling consecutive numbers
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:11 UTC
Are we handling that on FE?
Anders Pitman
@anderspitman
Apr 30 2016 03:12 UTC
frontend?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:12 UTC
oh nvm I see
Yea
sarahka7
@sarahka7
Apr 30 2016 03:12 UTC
image.png
Anders Pitman
@anderspitman
Apr 30 2016 03:12 UTC
It would require changes to both UI's, yes
Christiaan Schmid
@chcschmid
Apr 30 2016 03:12 UTC
@mshannahnv is there still an error with Average Rolls Per Game in personal stats?
Anders Pitman
@anderspitman
Apr 30 2016 03:13 UTC
@sarahka7 git remote rm eric then rerun the add
@chcschmid yes there is
look at her issue comments it's easy to reproduce
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:14 UTC
There's no way to merge a certain part of Eric's PR huh?
sarahka7
@sarahka7
Apr 30 2016 03:14 UTC
image.png
Anders Pitman
@anderspitman
Apr 30 2016 03:14 UTC
ps if anyone has eric as a remote take note that changed his GH username from hehe876 to ngdao, so you might need to remove and re-add his remote
@sarahka7 need to fetch first
sarahka7
@sarahka7
Apr 30 2016 03:16 UTC
oops, thx. okay cool. so something loaded...(I'll post pic)
image.png
I'm in 'detached head' state...lol.
Anders Pitman
@anderspitman
Apr 30 2016 03:17 UTC
lol
Nguyen Dao
@ngdao
Apr 30 2016 03:17 UTC
I have many branches you you want to fetch different version
Anders Pitman
@anderspitman
Apr 30 2016 03:17 UTC
yeah that's normal. I guess I've gotten used to seeing that and never stopped to think about what it said
Nguyen Dao
@ngdao
Apr 30 2016 03:18 UTC
and 2 more scoring system was added: 3 of a kind + 15, consecutive + 10
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:18 UTC
I want to help with some GUI bugs but not sure which version to jump in on or if we should wait for that entire PR to be approved
Anders Pitman
@anderspitman
Apr 30 2016 03:18 UTC
ah ok that's not too complicated
hm
Nguyen Dao
@ngdao
Apr 30 2016 03:18 UTC
only thing front end need to change is getCurrentTotal and getScore will return different values now
Anders Pitman
@anderspitman
Apr 30 2016 03:19 UTC
problem is the unit tests are broken
Nguyen Dao
@ngdao
Apr 30 2016 03:19 UTC
yeah, additional scoring will mess with getScore()'s original test value I bet
Anders Pitman
@anderspitman
Apr 30 2016 03:19 UTC
because some assumptions don't hold anymore. For example it used to be after a game ended the score was guaranteed to be 0 or 23 as long as they didn't stop
Nguyen Dao
@ngdao
Apr 30 2016 03:20 UTC
@mshannahnv pull from anders' master for the most stable version, my latest PR is additional Animation only
@anderspitman exactly
Anders Pitman
@anderspitman
Apr 30 2016 03:21 UTC
@mshannahnv and @sarahka7 if you two can bang on the new GUI and see if it works ok from a user perspective, I can look into the unit test situation. I think we should merge this before having anyone else fix other bugs
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:21 UTC
Yea it's getting massice
massive too
Anders Pitman
@anderspitman
Apr 30 2016 03:21 UTC
what is?
Nguyen Dao
@ngdao
Apr 30 2016 03:21 UTC
^
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:21 UTC
that PR lol!
Anders Pitman
@anderspitman
Apr 30 2016 03:21 UTC
ah
Nguyen Dao
@ngdao
Apr 30 2016 03:21 UTC
which one?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:22 UTC
#114
Nguyen Dao
@ngdao
Apr 30 2016 03:22 UTC
ah
lol
thought you guys reviewed it
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:22 UTC
I did this morning
Anders Pitman
@anderspitman
Apr 30 2016 03:23 UTC
I'm talking about the Animation one
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:23 UTC
but 4 commits got added to 114 so not sure if it's still g2g
Anders Pitman
@anderspitman
Apr 30 2016 03:23 UTC
so I guess you look at #119, I'll look at #114
sarahka7
@sarahka7
Apr 30 2016 03:23 UTC
any suggestions what gui version should I type instead? git checkout eric/???? I'd be happy to test out whatever you'd like me to -
Anders Pitman
@anderspitman
Apr 30 2016 03:24 UTC
yeah any new commits requires a review
Nguyen Dao
@ngdao
Apr 30 2016 03:24 UTC
just read the comments
Anders Pitman
@anderspitman
Apr 30 2016 03:24 UTC
@sarahka7 I think eric/Animation would be the best
sarahka7
@sarahka7
Apr 30 2016 03:25 UTC
okay I'll try again and see if the head stays attached
Anders Pitman
@anderspitman
Apr 30 2016 03:25 UTC
keep in mind the new scoring and maybe think about the best way to make it clear to the user
Nguyen Dao
@ngdao
Apr 30 2016 03:25 UTC
Weird how the code lines changes like that
Anders Pitman
@anderspitman
Apr 30 2016 03:25 UTC
detached head is what you want
lol
Nguyen Dao
@ngdao
Apr 30 2016 03:25 UTC
I'll add special Rolls into instruction
Anders Pitman
@anderspitman
Apr 30 2016 03:25 UTC
it just means you don't have a local branch for that commit ID, but it doesn't matter. You can still run the gradle commands
sarahka7
@sarahka7
Apr 30 2016 03:26 UTC
image.png
Anders Pitman
@anderspitman
Apr 30 2016 03:26 UTC
:thumbsup:
./gradlew :gui:run
sarahka7
@sarahka7
Apr 30 2016 03:28 UTC
success- thx!
Christiaan Schmid
@chcschmid
Apr 30 2016 03:28 UTC
Leaderboard should work when running CLI, right?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:28 UTC
yea
everything should work in CLI - if not let me know ! :)
Anders Pitman
@anderspitman
Apr 30 2016 03:28 UTC
@hehe876 #114 is really hard to review. Any chance you could try merging the latest master and pushing? That often helps
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:29 UTC
Love the dice animation
Nguyen Dao
@ngdao
Apr 30 2016 03:31 UTC
@anderspitman I'm going through the the commits to see what went wrong
@mshannahnv thank :3
thanks*
@anderspitman individual commits looks more separated. I think all of it combined, with shifting in code line made it change so much collectively
sarahka7
@sarahka7
Apr 30 2016 03:43 UTC
@hehe876 very cool animation! It's so boiiiingy! I like how you put the "value over" 23 in the ending dialog box too. The six buttons give it a clean look. Last version was very good too, but you definitely improved it!
Nguyen Dao
@ngdao
Apr 30 2016 03:45 UTC
@sarahka7 yayyy.
@all: I'm adding the Special rolls rule in the instruction. Changing the background color to fit as well.
Anyone working on fixing the unit test
wish chris was here haha
Christiaan Schmid
@chcschmid
Apr 30 2016 03:46 UTC
I'm here. still trying to figure it out
i'm having issues with branches and commits
sorry
For some reason my CLI version of the program doesn't run and I'm trying to figure out why. Without it running it's been hard for me to "see" the error
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:48 UTC
oh it's int he gui as well
if that helps
Nguyen Dao
@ngdao
Apr 30 2016 03:50 UTC
what is?
you mean the GUI PR?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 03:51 UTC
Just so he can see the backend bug
he can use gui or cli
It's broken in both
Nguyen Dao
@ngdao
Apr 30 2016 03:58 UTC
I just tried CLI
it's working fine
Anders Pitman
@anderspitman
Apr 30 2016 03:58 UTC
@hehe876 I'm considering unit tests as part of my review
I've started adding review comments to #114 if you want to start addressing/responding to them
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 04:00 UTC
@hehe876 huh? I just played a game on a fresh character, rolled 3 times, went to the "Player Stats" for my new character and my average roll per game is 0.6
Nguyen Dao
@ngdao
Apr 30 2016 04:01 UTC
yeah, averages are messed up
i'm looking into it right now
most likely in StatProcessor.computeStat()
Christiaan Schmid
@chcschmid
Apr 30 2016 04:04 UTC
I think I found the issue. In computeStats the variable totalGames = record.getGameId();. No idea, why I'm getting the game ID for that
that total game variable is used in determining the avg number of rolls down on line 176
Anders Pitman
@anderspitman
Apr 30 2016 04:08 UTC
@chcschmid I think that will work for all stats, but not for player stats
@hehe876 done with my first pass of #114, see comments on GH
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 04:09 UTC
Think #114 has a lot of #119 in it
Christiaan Schmid
@chcschmid
Apr 30 2016 04:09 UTC
Correct. There is only one computeStats used for both queries, right?
Anders Pitman
@anderspitman
Apr 30 2016 04:10 UTC
@mshannahnv it's the other way around, but yes. Pretty sure he branched #119 off of #114
@chcschmid yes
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 04:11 UTC
isConsecutive just checks if you roll a 1 2 3 or 6 5 4, right?
(examples, obv)
Anders Pitman
@anderspitman
Apr 30 2016 04:12 UTC
@chcschmid you'll want to change computeStats to make it work in either case. I think that's the best route. Basically need to add up the number of rolls for each game id and increment the count of games
Christiaan Schmid
@chcschmid
Apr 30 2016 04:13 UTC
@anderspitman if you have a quick minute can we do a quick hangouts screen share?
Anders Pitman
@anderspitman
Apr 30 2016 04:14 UTC
yup
Christiaan Schmid
@chcschmid
Apr 30 2016 04:14 UTC
K i'll get the call going
Nguyen Dao
@ngdao
Apr 30 2016 04:16 UTC
@mshannahnv yeah, it checks if the array contain 3 consecutive numbers regardless of order
@anderspitman commented on the comments
Nguyen Dao
@ngdao
Apr 30 2016 04:24 UTC
@chcschmid yeah, so it should be totalGames = dbLength
this guy's definitely getting an F
blob
Anders Pitman
@anderspitman
Apr 30 2016 04:30 UTC
@hehe876 what are you working on right now?
Nguyen Dao
@ngdao
Apr 30 2016 04:45 UTC
idk
I was gonna do something
then I got distracted lol
Anders Pitman
@anderspitman
Apr 30 2016 04:46 UTC
We'd need to move pretty quickly if you want to get all of this merged.
fast turn around
Nguyen Dao
@ngdao
Apr 30 2016 04:46 UTC
what do you want me to do?
Anders Pitman
@anderspitman
Apr 30 2016 04:47 UTC
If you agree with my review comments then the next step is for you to implement them and update your PR. If you don't agree with some of them post on GH and we discuss until we're in agreement
Nguyen Dao
@ngdao
Apr 30 2016 04:47 UTC
ok
on it!
Anders Pitman
@anderspitman
Apr 30 2016 04:50 UTC
I think I'll just do a semi-hack to fix the unit tests.
Then I should be able to do a PR on your branch
Nguyen Dao
@ngdao
Apr 30 2016 05:00 UTC
sorry, new commit on the same PR Anders
Anders Pitman
@anderspitman
Apr 30 2016 05:01 UTC
that's the way you're supposed to do it ;)
Anders Pitman
@anderspitman
Apr 30 2016 05:07 UTC
Ok @hehe876 you should be able to merge my unit test changes into your branch. I think that will fix it
Nguyen Dao
@ngdao
Apr 30 2016 05:07 UTC
Let's do this
travis seem to like it
Anders Pitman
@anderspitman
Apr 30 2016 05:10 UTC
Did you merge it yet? Your PR didn't update. We might have to do it manually. I don't normally do PRs on forks
Nguyen Dao
@ngdao
Apr 30 2016 05:14 UTC
I merged it with my branch
do I need to PR again?
Anders Pitman
@anderspitman
Apr 30 2016 05:14 UTC
excellent. no
travis is running now
Nguyen Dao
@ngdao
Apr 30 2016 05:14 UTC
cool
awww yiss
Anders Pitman
@anderspitman
Apr 30 2016 05:16 UTC
nice
I'm ok with merging #114. The CLI needs to be brought up to date with it, though. @mshannahnv did you say you already reviewed it as well?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:17 UTC
Yea #114 looks good
Anders Pitman
@anderspitman
Apr 30 2016 05:17 UTC
basically the CLI needs to tell the user if they got 3 in a row or 3 of a kind
if we merge this we're committing to make that work before midnight
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:18 UTC
For sure I'm down
Anders Pitman
@anderspitman
Apr 30 2016 05:18 UTC
cool
@hehe876 if you pull master and merge with ngdao/Animation it should fix travis
after you push
Nguyen Dao
@ngdao
Apr 30 2016 05:20 UTC
okay
Anders Pitman
@anderspitman
Apr 30 2016 05:20 UTC
@sarahka7 @chcschmid how are you both doin?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:20 UTC
Do I need to call something from the back end each roll to see if they had a special roll
Anders Pitman
@anderspitman
Apr 30 2016 05:20 UTC
@mshannahnv yeah
Christiaan Schmid
@chcschmid
Apr 30 2016 05:20 UTC
When I fixed it and got it working with one test, four others blew up
Anders Pitman
@anderspitman
Apr 30 2016 05:20 UTC
I really should have made @hehe876 make unit tests for that functionality but I let him off easy ;)
@chcschmid it helps to run the tests more often, even after very small changes. Take 5 minutes and get the daemon running, it will save your sanity: https://docs.gradle.org/current/userguide/gradle_daemon.html
Nguyen Dao
@ngdao
Apr 30 2016 05:22 UTC
I know, but i haven't been involved with the tests much, so it would take too long
haha
Anders Pitman
@anderspitman
Apr 30 2016 05:23 UTC
if it were a real project I'd be a Nazi about it, but we have to finish this tonight
normally part of the review process involves making sure the tests cover all the new functionality introduced, including all cyclomatic paths
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:24 UTC
Never thought I'd hear that word again
Nguyen Dao
@ngdao
Apr 30 2016 05:26 UTC
lol
Anders Pitman
@anderspitman
Apr 30 2016 05:27 UTC
I'll be sure to text it to you every day for the rest of your life
my gift to you
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:28 UTC
lololol
So, I should be calling getSpecialRollCode() ?
after my roll
and if it's null, nothing special
if its 1 or 2, display message
Nguyen Dao
@ngdao
Apr 30 2016 05:29 UTC
it's initial is 0
its*
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:29 UTC
Ah sorry I see that in the constructor
Sounds good!
Nguyen Dao
@ngdao
Apr 30 2016 05:29 UTC
:+1:
Animation is working too @anderspitman
Anders Pitman
@anderspitman
Apr 30 2016 05:31 UTC
wait, did you make that animation yourself?
each frame?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:31 UTC
I think he edited the faces of the die
Nguyen Dao
@ngdao
Apr 30 2016 05:32 UTC
I download a gif, then split it into roll and stop animations, then change the face for each out come of the stop
Anders Pitman
@anderspitman
Apr 30 2016 05:33 UTC
niiiice
Nguyen Dao
@ngdao
Apr 30 2016 05:33 UTC
did you see the conflict with #119 and your PR @mshannahnv ?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:33 UTC
Yea
Nguyen Dao
@ngdao
Apr 30 2016 05:33 UTC
cool
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:33 UTC
I'm probably just going to close mine and add it back onto yours
Anders Pitman
@anderspitman
Apr 30 2016 05:33 UTC
sometimes that's easier
it sucks when you're working on a big PR for days or weeks, then someone else sneaks in a big conflicting one before you on master. Guess who gets to resolve all the conflicts
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:34 UTC
lolol
Nguyen Dao
@ngdao
Apr 30 2016 05:34 UTC
yewww
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:34 UTC
:(
We need to edit the README on the special score
and CLI & GUI
instructions
Nguyen Dao
@ngdao
Apr 30 2016 05:36 UTC
GUI instructions is updated, I'll do the readme
sarahka7
@sarahka7
Apr 30 2016 05:38 UTC
@anderspitman sorry stepped away for dinner. Was waiting for gui fixes. I can reload gui and test more. Anything still not working that I should ignore for now?
Nguyen Dao
@ngdao
Apr 30 2016 05:41 UTC
Have we resolve the Get Overall stat issue when database is empty?
Anders Pitman
@anderspitman
Apr 30 2016 05:41 UTC
I think we can merge #119
any objections?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:42 UTC
Looks good to me
sarahka7
@sarahka7
Apr 30 2016 05:42 UTC
I just re-fetched it and will play some more.
Anders Pitman
@anderspitman
Apr 30 2016 05:43 UTC
k @sarahka7 I'll give you some time to play with it and get your feedback
particularly interested in your thoughts on the new scoring system.
and how it feels from a user point of view
ah dang!
2 consecutives in a row then a 23 :sunglasses:
86 points booya
Nguyen Dao
@ngdao
Apr 30 2016 05:45 UTC
wow
that's the highest so far
sarahka7
@sarahka7
Apr 30 2016 05:47 UTC
Ok im on it.
Anders Pitman
@anderspitman
Apr 30 2016 05:48 UTC
this is kinda addictive.
Nguyen Dao
@ngdao
Apr 30 2016 05:48 UTC
added a bit on #119
have a look
Anders Pitman
@anderspitman
Apr 30 2016 05:48 UTC
I feel like with a little tweaking this could be something people would actually play
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 05:48 UTC
Greenlight it on steam!
Rack in the dough
Nguyen Dao
@ngdao
Apr 30 2016 05:48 UTC
hahahahaha
Anders Pitman
@anderspitman
Apr 30 2016 05:49 UTC
yeah baby
Nguyen Dao
@ngdao
Apr 30 2016 05:49 UTC
I need to find the owner of the Gif and give them credit too
lol
Anders Pitman
@anderspitman
Apr 30 2016 05:49 UTC
I think the biggest problem currently is that there's little incentive not to go over
cuz you can just start a fresh game and try again
Nguyen Dao
@ngdao
Apr 30 2016 05:49 UTC
but that leader board tho
can't be on top without the double goodness
Anders Pitman
@anderspitman
Apr 30 2016 05:50 UTC
that's my point
people can just spam 3s until they get on the leaderboard
Christiaan Schmid
@chcschmid
Apr 30 2016 05:50 UTC
@anderspitman this getAvgRollsPerGame is turning into a large fish to fry
Anders Pitman
@anderspitman
Apr 30 2016 05:51 UTC
the penalty for going over needs to be harsher and carry over from game to game
@chcschmid we can screen share if you want me to take a look
Nguyen Dao
@ngdao
Apr 30 2016 05:51 UTC
Can cost more to roll more dice maybe
Christiaan Schmid
@chcschmid
Apr 30 2016 05:52 UTC
k I'll call
Nguyen Dao
@ngdao
Apr 30 2016 05:53 UTC
what about documentation?
I'll start writing documentation (comments) on GUI
sarahka7
@sarahka7
Apr 30 2016 05:54 UTC
wow, actually made it to 23- first time! So I got a +10 consecutive, and made it to 23, then my finishing score was 66.
Are the bonus rules going to be added to the instructions- so user will know upfront about the bonus potential?
Nguyen Dao
@ngdao
Apr 30 2016 05:54 UTC
can someone start adding documentation on the shared files?
@sarahka7 yes, GUI instruction includes the special roll in #119, don't know about CLI tho
sarahka7
@sarahka7
Apr 30 2016 05:56 UTC
The version I'm testing doesn't mention it yet when I click "instruction" unless I'm testing the wrong version. I'm using \Animation
gui
Nguyen Dao
@ngdao
Apr 30 2016 05:59 UTC
yeah I added that a bit later after you pull it I think
sarahka7
@sarahka7
Apr 30 2016 06:00 UTC
oh okay that's good then.
Yes the bonus potential does make it more exciting.
I like it.
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:03 UTC
Okay I got the CLI caught up
PR INC
Please test/review #123
sarahka7
@sarahka7
Apr 30 2016 06:06 UTC
@mshannahnv I can take a look, do I fetch from your dice-game repo then?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:08 UTC
I just follow the "view command line instructions" on anderspitman/dice-game#123
Eek

Step 1: From your project repository, check out a new branch and test the changes.

git checkout -b mshannahnv-cli master
git pull https://github.com/mshannahnv/dice-game.git cli

Hopefully those two commands work for ya!
pull is the same as fetch/merge
just in case it looks different
sarahka7
@sarahka7
Apr 30 2016 06:12 UTC
ty! ty! I appreciate it. Okay I'm in and testing it now.
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:14 UTC
I'm going to convert my GUI changes over to master
Nguyen Dao
@ngdao
Apr 30 2016 06:17 UTC
there were a PR that you changed the button's text, which one was it @mshannahnv
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:17 UTC
It's in #121
I'm putting it in a new PR without conflicts
Anders Pitman
@anderspitman
Apr 30 2016 06:18 UTC
@sarahka7 are you feeling good about #119?
Christiaan Schmid
@chcschmid
Apr 30 2016 06:20 UTC
@all #117 has been merged!
sarahka7
@sarahka7
Apr 30 2016 06:23 UTC
@mshannahnv looks good! So player stats and leaderboard are still generic right? I got to 23 (46) but my stats and name did not record to leaderboard or stats. Also- Did we want to add info about the bonus rules in the instructions? I think this would be a good idea for both gui and cli- just to let the player know what the game is capable of/ allow them to strategize in advance.
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:23 UTC
They should be in the CLI I hope!
Are they there under HOW TO PLAY?
sarahka7
@sarahka7
Apr 30 2016 06:25 UTC
@anderspitman #119- the animations are good. At first I was confused bc I was looking on the top sides for the sums, but then I figured out to look on the side facing forward. The thing is, typically it's the value that lands "face-up" in a dice game that gets summed/counted.
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:26 UTC
I can try to fix that in photoshop if we have some time at the end
I agree with you
and the TAs will probably expect the same thing
sarahka7
@sarahka7
Apr 30 2016 06:27 UTC
@mshannahnv I will re-fetch and check gain - the instructions
Anders Pitman
@anderspitman
Apr 30 2016 06:27 UTC
@sarahka7 I had the same problem
But on GH @hehe876 said it would be hard to fix
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:27 UTC
Not hard just repetitive
Anders Pitman
@anderspitman
Apr 30 2016 06:27 UTC
it defies the laws of gravity but I'm not sure it's that big of a deal
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:28 UTC
I have #125 which needs review.. which also includes my last PR because I'm a branch noob
I try to keep it separate but it seems like if I don't use old branches, it just takes my current local data. I wish when I made a branch, it was just empty until I pulled from somewhere
Anders Pitman
@anderspitman
Apr 30 2016 06:29 UTC
I'm on it
Nguyen Dao
@ngdao
Apr 30 2016 06:29 UTC
I'd rather we spent our last 30 minutes on something else rather than changing the face of the dice. I would take a long time, trust me lol
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:30 UTC
We could be super lazy and just change the last frame ;)
sarahka7
@sarahka7
Apr 30 2016 06:32 UTC
@mshannahnv pls. double check me but I do not see info on the bonus roll points in How to Play.
Anders Pitman
@anderspitman
Apr 30 2016 06:32 UTC
All stats is still missing from the GUI, right?
Nguyen Dao
@ngdao
Apr 30 2016 06:33 UTC
@anderspitman what do you mean?
@mshannahnv the upper face of the dice is too small though, the side surface area should be apparent enough haha
Anders Pitman
@anderspitman
Apr 30 2016 06:34 UTC
@mshannahnv CLI updates look great. Very intuitive
it's fine. it's really beta anyway
@hehe876 can you fix readme PR?
Nguyen Dao
@ngdao
Apr 30 2016 06:35 UTC
All stats is implemented in GUI tho
Anders Pitman
@anderspitman
Apr 30 2016 06:36 UTC
@hehe876 not quite. The functionality is different from the CLI
run the CLI and you'll see what I mean
the GUI doesn't allow you to see stats for all the players crunched together
it only let's you look at your own or one other player
but that's ok. just a slight feature difference
Nguyen Dao
@ngdao
Apr 30 2016 06:37 UTC
done
ohhhh
sarahka7
@sarahka7
Apr 30 2016 06:38 UTC
@hehe876 okay I re-fetched and see the special rolls rules now- nice. This is nitpicky, but maybe use a "+" to say "bonus +15" and bonus +10 - - if time to add.
Anders Pitman
@anderspitman
Apr 30 2016 06:38 UTC
we need to start cutting a release in 5 or 10 minutes tops
sarahka7
@sarahka7
Apr 30 2016 06:39 UTC
stats and leaderboard are working very nicely in gui. It is remembering everything.
Anders Pitman
@anderspitman
Apr 30 2016 06:40 UTC
@mshannahnv it doesn't look like #125 changes the GUI at all?
oh nvm
I'm just blind
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:41 UTC
Snuck a little spacing in there
I think #123 and #125 were pretty similar
#125 just had the spacing I just added
Anders Pitman
@anderspitman
Apr 30 2016 06:41 UTC
I'm nervous about #125
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:42 UTC
We can close and I can do new PR
Anders Pitman
@anderspitman
Apr 30 2016 06:42 UTC
are you sure the meanings of the buttons match the names
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:42 UTC
What do you mean
Anders Pitman
@anderspitman
Apr 30 2016 06:42 UTC
the database is saving the current score whether you hit the button or not
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:43 UTC
How should we reanem "Save Score" then
Anders Pitman
@anderspitman
Apr 30 2016 06:43 UTC
you could roll once, then force exit the game and it would be the same result
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:43 UTC
"End Game"?
Anders Pitman
@anderspitman
Apr 30 2016 06:43 UTC
maybe
reset was fine
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:43 UTC
Ok
I'll revert
Anders Pitman
@anderspitman
Apr 30 2016 06:43 UTC
well idk
you just changed the name, right. not any behavior?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:44 UTC
The text doesn't change the behavior
I added a pop up
After RESET is pressed
like.. This is your score!
Anders Pitman
@anderspitman
Apr 30 2016 06:45 UTC
I think it's fine
Nguyen Dao
@ngdao
Apr 30 2016 06:45 UTC
have you read my comment?
on #125
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:46 UTC
OK I'll add
Nguyen Dao
@ngdao
Apr 30 2016 06:47 UTC
that should be the last pr!
database issue is fixed?
Anders Pitman
@anderspitman
Apr 30 2016 06:47 UTC
which one?
average rolls?
Nguyen Dao
@ngdao
Apr 30 2016 06:48 UTC
yeah
Anders Pitman
@anderspitman
Apr 30 2016 06:48 UTC
@chcschmid merge master for #126. better get it in asap
Christiaan Schmid
@chcschmid
Apr 30 2016 06:48 UTC
#126 is a PR containing java documentation for StatsProcessor.java
merge master?
Anders Pitman
@anderspitman
Apr 30 2016 06:50 UTC
your PR has conflicts
Christiaan Schmid
@chcschmid
Apr 30 2016 06:50 UTC
I'm in updateJavaDoc branch. Do I just do git merge origin master?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:53 UTC
Can somebody test #125
Anders Pitman
@anderspitman
Apr 30 2016 06:53 UTC
@mshannahnv just did
waiting on travis
merged
@chcschmid git pull upstream master
Christiaan Schmid
@chcschmid
Apr 30 2016 06:54 UTC
M       .gitignore
M       README.md
M       cli/src/main/java/Main.java
D       gui/src/main/java/DiceGameGUI.form
M       gui/src/main/java/DiceGameGUI.java
A       gui/src/main/resources/dice_static.jpg
A       gui/src/main/resources/dice_stop_1.gif
A       gui/src/main/resources/dice_stop_2.gif
A       gui/src/main/resources/dice_stop_3.gif
A       gui/src/main/resources/dice_stop_4.gif
A       gui/src/main/resources/dice_stop_5.gif
A       gui/src/main/resources/dice_stop_6.gif
M       gui/src/main/resources/die-a.gif
D       gui/src/main/resources/die_face_1.png
D       gui/src/main/resources/die_face_2.png
D       gui/src/main/resources/die_face_3.png
D       gui/src/main/resources/die_face_4.png
D       gui/src/main/resources/die_face_5.png
D       gui/src/main/resources/die_face_6.png
U       shared/src/main/java/dice/DiceGame.java
M       shared/src/main/java/dice/RollResult.java
M       shared/src/main/java/dice/StatsProcessor.java
M       shared/src/test/java/TestDiceGame.java
M       shared/src/test/java/TestStatsProcessor.java
Pull is not possible because you have unmerged files.
Please, fix them up in the work tree, and then use 'git add/rm <file>'
as appropriate to mark resolution, or use 'git commit -a'.
Anders Pitman
@anderspitman
Apr 30 2016 06:54 UTC
I'm cutting the release
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:54 UTC
Ah
Did Eric make a pop up too?
Anders Pitman
@anderspitman
Apr 30 2016 06:54 UTC
who knows
:shipit:
:sunglasses:
Nguyen Dao
@ngdao
Apr 30 2016 06:55 UTC
yeah
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:55 UTC
I don't think I needed to add mine at all then
Nguyen Dao
@ngdao
Apr 30 2016 06:55 UTC
my #119 have the pop up in reset
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:55 UTC
It's popping up twice, even after the check
Nguyen Dao
@ngdao
Apr 30 2016 06:55 UTC
your GUI code looks really old o.O
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:56 UTC
I have no idea
I just pulled master and it's up to date though
Nguyen Dao
@ngdao
Apr 30 2016 06:56 UTC
private void btnResetActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_btnResetActionPerformed
        String name = lblPlayerName.getText();

        if(thisGame.getCurrentTotal() < 23){
            JOptionPane.showMessageDialog(
                    null,
                    "Your score this round is: " + thisGame.getScore(),
                    "Round Ended",
                    JOptionPane.OK_OPTION);
        }

        try {
            thisGame = DiceGame.create(name);
        }
        catch (InvalidUsernameException ex) {
            ex.printStackTrace();
        }

        lblRollScore.setText("0");
        lblTotalScore.setText("0");
        lblRollTotal.setText("0");
        lblSpecialRoll.setText("");

        btnRoll.setEnabled(true);

        for (int index = 0; index < listLbl.size(); index++)
        {
            listLbl.get(index).setIcon(listIcon.get(7));
        }
this is mine reset button
Anders Pitman
@anderspitman
Apr 30 2016 06:57 UTC
it's fine
I merged master into her's when I tested it
and GH didnt' complain
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:57 UTC
That makes sense why it's popping up twice. our ifs are living next to eachout
eachother
Nguyen Dao
@ngdao
Apr 30 2016 06:57 UTC
cool
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 06:58 UTC
I didn't know you already made one Eric, my b
Nguyen Dao
@ngdao
Apr 30 2016 06:58 UTC
I thought they would merge
Christiaan Schmid
@chcschmid
Apr 30 2016 06:58 UTC
hmmm... sorry about #126 guys. No idea what I did
@anderspitman should I close it?
Anders Pitman
@anderspitman
Apr 30 2016 06:59 UTC
if you like
no time to merge it
Nguyen Dao
@ngdao
Apr 30 2016 07:00 UTC
the end of the file
Anders Pitman
@anderspitman
Apr 30 2016 07:00 UTC
looks like it had conflicts and you left the "HEAD>>>>>" stuff in there
Nguyen Dao
@ngdao
Apr 30 2016 07:00 UTC
there's still some git stuff
Anders Pitman
@anderspitman
Apr 30 2016 07:00 UTC
after you merged
^^
great work everyone!
awesome teamwork
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:01 UTC
GG
You guys taking the final in 360?
Anders Pitman
@anderspitman
Apr 30 2016 07:01 UTC
still haven't decided
Nguyen Dao
@ngdao
Apr 30 2016 07:01 UTC
hmm
Anders Pitman
@anderspitman
Apr 30 2016 07:01 UTC
if I have time to study the day before maybe
Nguyen Dao
@ngdao
Apr 30 2016 07:02 UTC
did we manage to submit the link in time?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:02 UTC
Ah I didn't submit anything
Anders Pitman
@anderspitman
Apr 30 2016 07:02 UTC
lol
me neither
Nguyen Dao
@ngdao
Apr 30 2016 07:04 UTC
there's an attempt yesterday
??
Anders Pitman
@anderspitman
Apr 30 2016 07:04 UTC
it let me submit it just now
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:04 UTC
Sorry this link is 3 minutes late! Our github commits were before midnight - please have mercy on our souls!
Submitted
Nguyen Dao
@ngdao
Apr 30 2016 07:04 UTC
lmao
Anders Pitman
@anderspitman
Apr 30 2016 07:04 UTC
I'm sure it's final. Calliss is my bestie
fine**
she wouldn't do me like that
Nguyen Dao
@ngdao
Apr 30 2016 07:05 UTC
haha
3 min
better take off 300 point
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:05 UTC
It's only worth 37!
Anders Pitman
@anderspitman
Apr 30 2016 07:06 UTC
that's not how the game works
if you go over you get a 0
Nguyen Dao
@ngdao
Apr 30 2016 07:06 UTC
hahaha
I don't even know what grade do I have in 360
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:06 UTC
Did average roll stats get fixed
?
Christiaan Schmid
@chcschmid
Apr 30 2016 07:06 UTC
yes
Nguyen Dao
@ngdao
Apr 30 2016 07:07 UTC
yes
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:07 UTC
yay
Christiaan Schmid
@chcschmid
Apr 30 2016 07:07 UTC
:santa: my present to you
guy
s
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:07 UTC
Thanks santa!
Anders Pitman
@anderspitman
Apr 30 2016 07:08 UTC
that reminds me. it's a new day. you know what that means Hannah?
Christiaan Schmid
@chcschmid
Apr 30 2016 07:08 UTC
Santas tall skinny top elf man really helped him out though and deserves a lot of credit
Nguyen Dao
@ngdao
Apr 30 2016 07:08 UTC
GOOD NIGHT YALL
Christiaan Schmid
@chcschmid
Apr 30 2016 07:08 UTC
aka @anderspitman
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:08 UTC
cyclomatic cyclomatic cyclomatic
Anders Pitman
@anderspitman
Apr 30 2016 07:08 UTC
hahaha yep
Nguyen Dao
@ngdao
Apr 30 2016 07:09 UTC
what is with cyclomatic?
Anders Pitman
@anderspitman
Apr 30 2016 07:09 UTC
search for it in this thread
Nguyen Dao
@ngdao
Apr 30 2016 07:09 UTC
it even have the red squiggly line under it!
Anders Pitman
@anderspitman
Apr 30 2016 07:09 UTC
did we lose @sarahka7 ?
Hannah Van Den Bosch
@mshannahnv
Apr 30 2016 07:13 UTC
gnight guys!
Anders Pitman
@anderspitman
Apr 30 2016 07:13 UTC
yeah I'm checkin out too. Night!
sarahka7
@sarahka7
Apr 30 2016 07:19 UTC
goodnight all- thx !
Nguyen Dao
@ngdao
Apr 30 2016 20:15 UTC
so... can we edit the repo anymore? lol
It's hard to let go
Anders Pitman
@anderspitman
Apr 30 2016 20:16 UTC
lol
I think it would be easier for grading if we don't modify it
until after next week at least
Nguyen Dao
@ngdao
Apr 30 2016 20:20 UTC
I saw a bug and it makes me nervous lol
Anders Pitman
@anderspitman
Apr 30 2016 20:22 UTC
meh I wouldn't worry
it's beta
it basically works
Nguyen Dao
@ngdao
Apr 30 2016 20:27 UTC
yeah, all the backlog has been met