These are chat archives for andrew/node-sass

22nd
Mar 2014
Andrew Nesbitt
@andrew
Mar 22 2014 16:17
an actual use for gitter!
Adam Yeats
@adamyeats
Mar 22 2014 16:17
hahaha i know, right!
been waiting for the ideal time
Andrew Nesbitt
@andrew
Mar 22 2014 16:18
how's it going?
Adam Yeats
@adamyeats
Mar 22 2014 16:18
i'm doing okay man, how about you?
Andrew Nesbitt
@andrew
Mar 22 2014 16:19
Good
sorting out my office today
which involved moving the rabbits outside
they are pissed!
Adam Yeats
@adamyeats
Mar 22 2014 16:20
hahaha oh man
Nothing worse than pissed off rabbits!
ok i got some q's for ya on node-sass
i've never worked on a library with native bindings before so might be a while before i can contribute anything meaningful...

Firstly, in the README, it says: Replace the prebuild binary with your newly generated one

cp build/Release/binding.node precompiled/your-platform/binding.node

I don't have a /precompiled dir in my folder, have I done something wrong?
Andrew Nesbitt
@andrew
Mar 22 2014 16:29
tbh i think the readme is a bit out of date there
I think when you run npm install it puts the binary in /bin now
or maybe not
Adam Yeats
@adamyeats
Mar 22 2014 16:29
it looks that way to me
Andrew Nesbitt
@andrew
Mar 22 2014 16:29
but the precompiled folder isn't used anymore
Adam Yeats
@adamyeats
Mar 22 2014 16:30
ok, but do i still have to cp from or to bin/darwin-x64-v8-3.14?
Andrew Nesbitt
@andrew
Mar 22 2014 16:31
nah it looks in bin now
Adam Yeats
@adamyeats
Mar 22 2014 16:31
so that entire step can be removed?
Andrew Nesbitt
@andrew
Mar 22 2014 16:32
build.js is where the magic happens
yeah I think that whole bit can be removed
we don't check the compiled binaries in now
instead we have some in a different repo called node-sass-binaries
and in script/prepublish.sh it pulls them in when we release new versions of the lib to npm
so for a fresh clone
you need to grab the libsass submodule and run build.js
or npm install
see what I mean by it needs more eyes/love
Adam Yeats
@adamyeats
Mar 22 2014 16:35
npm install looks like it runs build.js automatically, right?
Andrew Nesbitt
@andrew
Mar 22 2014 16:36
yup yup
check line 27 in package.json
Adam Yeats
@adamyeats
Mar 22 2014 16:37
yep just seen it (y)
ok cool, i'll make that my first PR
Andrew Nesbitt
@andrew
Mar 22 2014 16:38
swweeet
thanks for you help
Adam Yeats
@adamyeats
Mar 22 2014 16:38
Then probably this? This looks straightforward - andrew/node-sass#245
Andrew Nesbitt
@andrew
Mar 22 2014 16:40
yeah that would be handy
it's suprising how much node-sass is depended on now
2000 downloads a day atm
Adam Yeats
@adamyeats
Mar 22 2014 16:42
must be dude! i use it all the time
Andrew Nesbitt
@andrew
Mar 22 2014 16:42
ghost are going to start using it in the ember-based dashboard
but a lot of users don't really get that it's not feature complete with ruby sass
Adam Yeats
@adamyeats
Mar 22 2014 16:44
yeah that's the issue really isn't it
maybe a small docs tweak to reflect that?
Andrew Nesbitt
@andrew
Mar 22 2014 16:45
yeah
near the top of the readme, and in contributing.md
Adam Yeats
@adamyeats
Mar 22 2014 16:45
the sass guys made a table to show the differences that might be worth linking to
Andrew Nesbitt
@andrew
Mar 22 2014 16:46
yeah for sure
I didn't know that existed!
Adam Yeats
@adamyeats
Mar 22 2014 16:48
i think @stu_robson sent it to me the other week
i'll dig it out and add it
I shouldn't search twitter for node-sass
it just makes me sad
I shouldn't take comments about it so personally
Adam Yeats
@adamyeats
Mar 22 2014 16:54
it's so easy to, but bare in mind these people also arent opening issues or submitting PRs
so how can they ever expect any action?
Andrew Nesbitt
@andrew
Mar 22 2014 16:54
yeah true
Adam Yeats
@adamyeats
Mar 22 2014 16:54
i think a good thing to do is tweet @ him and say "we'll open an issue for you"
i've found that being pleasant generally catches people off their guard as people aren't really used to it in our community
Andrew Nesbitt
@andrew
Mar 22 2014 16:56
yeah I used to
but now I don't have enough time to keep up with all the issues!
Adam Yeats
@adamyeats
Mar 22 2014 16:56
how many maintainers are there on node-sass?
Andrew Nesbitt
@andrew
Mar 22 2014 16:56
there are 5 people with commit access
but none of them are full time
maybe a couple that are responsive
and the other two come and go every so often
Adam Yeats
@adamyeats
Mar 22 2014 16:59
it might be a good time to check who's still interested and who isn't, and maybe look for more maintainers
i'm happy to do it but will need some guidance from you initially
Andrew Nesbitt
@andrew
Mar 22 2014 16:59
I ask on twitter every so often
https://github.com/keithamus helped out recently too
I might try and poke him to get more involved
Adam Yeats
@adamyeats
Mar 22 2014 17:00
that sounds good
an effective thing i've seen in other repos is splitting tasks into micro-issues
Andrew Nesbitt
@andrew
Mar 22 2014 17:01
also a good plan
Adam Yeats
@adamyeats
Mar 22 2014 17:01
to encourage irregular or new open source devs to get involved
Adam Yeats
@adamyeats
Mar 22 2014 17:04
WU59.gif
aw man the gif is broked :(
Andrew Nesbitt
@andrew
Mar 22 2014 17:05
haha, downloaded it and played it in finder
Adam Yeats
@adamyeats
Mar 22 2014 17:05
:smile:
ok, so i'll do README, sindre's issue and nudge the old issues and see if i can get a few closed
if you're happy for me to come on board as a maintainer, awesome! can certainly do that
Andrew Nesbitt
@andrew
Mar 22 2014 17:07
that would be kickass
<3
Adam Yeats
@adamyeats
Mar 22 2014 17:07
as i say though, i might need to ask you questions a bit while i'm getting used to stuff
Andrew Nesbitt
@andrew
Mar 22 2014 17:07
no worries
Adam Yeats
@adamyeats
Mar 22 2014 17:08
awsm :+1:
Andrew Nesbitt
@andrew
Mar 22 2014 17:12
We should add the maintainers list to the readme too
for the love
Adam Yeats
@adamyeats
Mar 22 2014 17:12
Definitely
let's open up this Gitter room as well IMO
sometimes it's easier to chat in this sort of environment
Andrew Nesbitt
@andrew
Mar 22 2014 17:14
sure
isnt it already open?
Adam Yeats
@adamyeats
Mar 22 2014 17:17
ah yup seeems so!
Andrew Nesbitt
@andrew
Mar 22 2014 17:18
we could always add the badge to the readme
Adam Yeats
@adamyeats
Mar 22 2014 17:18
yeah good idea
Adam Yeats
@adamyeats
Mar 22 2014 17:33

Important note on libsass

The libsass C++ library that this library binds to is not currently at feature parity with the Ruby Gem that most Sass users will use. While we try our best to maintain feature parity with libsass, we can not enable features that have not been implemented in libsass yet.

If you'd like to see what features are still upcoming in libsass, Jo Liss has written a recent blog post on the subject.

Please check the Issues on the libsass repo before opening an issue here, as there is a good chance that it may be an issue there for it. If not, then by all means, open an issue here and we'll look into it.

How does that look to you?
Andrew Nesbitt
@andrew
Mar 22 2014 17:34
yeah that looks wonderful
Adam Yeats
@adamyeats
Mar 22 2014 17:43
awsm. just dropped a PR for it
Andrew Nesbitt
@andrew
Mar 22 2014 17:45
speed merging
Adam Yeats
@adamyeats
Mar 22 2014 17:46
boom
failing tests on travis though?
Andrew Nesbitt
@andrew
Mar 22 2014 17:46
bloody travis
Adam Yeats
@adamyeats
Mar 22 2014 17:46
hahaa
Error: timeout of 2000ms exceeded
possibly a temporary thing?
it's building again
going to feed the rabbits
back in a bit
Adam Yeats
@adamyeats
Mar 22 2014 17:47
ok dude!
Andrew Nesbitt
@andrew
Mar 22 2014 18:16
back for a few
tests are passing again
Adam Yeats
@adamyeats
Mar 22 2014 18:17
yay!
2 things
are you able to give me a list of maintainers usernames?
and re: sindre's issue, i think he's trying to say this stuff should be in render.js?
Andrew Nesbitt
@andrew
Mar 22 2014 18:18
yeah I think so
Adam Yeats
@adamyeats
Mar 22 2014 18:18
ln#32, if (options.sourceMap) {
Andrew Nesbitt
@andrew
Mar 22 2014 18:19
you can actually get that via the api
Screen Shot 2014-03-22 at 6.19.45 PM.png
I'd leave off hampton, as he's not actually done anything!
Adam Yeats
@adamyeats
Mar 22 2014 18:22
ah cool didn't know that!
Andrew Nesbitt
@andrew
Mar 22 2014 18:22
anyways I'm off for some sushi
feel free to open an issue or email if you have any other questions
thanks again for the help
Adam Yeats
@adamyeats
Mar 22 2014 18:23
enjoy your sushi!
will do :)