These are chat archives for andyet/SimpleWebRTC

3rd
Mar 2016
Michele Olivo
@bud-mo
Mar 03 2016 11:26
@xdumaine Hi! Can you keep an eye on the library used by the project? I have noticed some issues about the rtc adapter which are very annoying.
Xander Dumaine
@xdumaine
Mar 03 2016 11:28
@ZxBud which issues in particular? I don't have a ton of sway with adapter.js but I do try to keep an eye on it.
Another of the SimpleWebRTC maintainers also contributes to adapter.js so we try to maintain compatibility
Michele Olivo
@bud-mo
Mar 03 2016 11:34
I am building the bundle from scratch so I can include some patches
@xdumaine I'm sorry, I'm noticing now that building the bundle does not emit the same output of the github version
Xander Dumaine
@xdumaine
Mar 03 2016 11:36
Browserify is used for bundling it, and often results in big diffs
You basically have two options: fork and patch the bundle directly, or open PRs for the things you need patched
Michele Olivo
@bud-mo
Mar 03 2016 11:39
Patching the bundle is not a good options, is not maintainable, I'm trying to patch directly the libraries used and send PRs to the projects
Xander Dumaine
@xdumaine
Mar 03 2016 11:39
Yep that's the better path.
I can't help much more without knowing any specifics though
Michele Olivo
@bud-mo
Mar 03 2016 11:39
Have you tried the SimpleWebRTC on Safari?
Xander Dumaine
@xdumaine
Mar 03 2016 11:41
Safari has no WebRTC support.
Michele Olivo
@bud-mo
Mar 03 2016 11:49
Yes I know, walkin back to the start of the discussion my case was this: I have noticed some libraries you use uses the adapter.js, but the version which is installed using the npm installhave a couple of bugs, which causes in a bugged latest-v2.js and simplewebrtc.bundle.js
Xander Dumaine
@xdumaine
Mar 03 2016 11:50
have a couple of bugs
what bugs?
you have to elaborate
Michele Olivo
@bud-mo
Mar 03 2016 11:52
For example, building the bundle as I previously said, this line is missing https://github.com/webrtc/adapter/blob/master/src/js/utils.js#L92
Which cause the fail to execute the script in safari (and I bet in many other browsers)
Xander Dumaine
@xdumaine
Mar 03 2016 11:54
See webrtc/adapter#208
They have to update the npm package after PRs are merged, which they do not always do right away.
Michele Olivo
@bud-mo
Mar 03 2016 11:56
@xdumaine ok thank you for the info, I was searching exactly that issue!
Michele Di Salvatore
@micheledisalvatore
Mar 03 2016 15:25
Hi guys
A quick question... Where can I find the open source project of signaling.simplewebrtc.com ?
I'm using Signalmaster project but it doesn't work, whereas signaling.simplewebrtc.com works well
Xander Dumaine
@xdumaine
Mar 03 2016 15:50
That's the same project, you might just be having a version incompatibility issue.
Michele Di Salvatore
@micheledisalvatore
Mar 03 2016 15:52
@xdumaine Please can you send me the dependencies versions?
or you can respond to this issue :) andyet/signalmaster#73
Michele Di Salvatore
@micheledisalvatore
Mar 03 2016 15:57
many thanks ;)
Michele Di Salvatore
@micheledisalvatore
Mar 03 2016 17:27
with an npm listyou can print the same list that I published