Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Anderson Ribeiro e Silva
    @dimrsilva
    So, I want to discuss what to do. My main idea is to decouple a service from some methods of the directive. What do you think?
    Adrien Crivelli
    @PowerKiKi
    Like I said, I am in favor in complete BC if it can solve the long standing issues. Even maybe going for Angular 2, or at least thinking about how we could make the future migration easier ?
    would that be ok for you @ProLoser to break BC ?
    Anderson Ribeiro e Silva
    @dimrsilva
    Well, I did some work. It is on my fork: https://github.com/dimrsilva/ui-mask on branch master. It's not ready for release, so I do not open a pull request yet.
    Adrien Crivelli
    @PowerKiKi
    Thanks for taking time for that. I myself have very limited time to contribute to Angular UI, so I'll let you decide what's best for your fork/future versions
    Nick Tomlin
    @NickTomlin
    Hi All, I'd love to help get things working happily on Travis. One thing that would really help would be getting an open source account with Sauce so we can more easily run tests in a wide range account. I'm not sure if angular-ui already has one though.
    Adrien Crivelli
    @PowerKiKi
    I asked the team about it...
    Adrien Crivelli
    @PowerKiKi
    according to @douglasduteil we're better off with one account per repo. He also mentionned: https://github.com/douglasduteil/gesalakacula/blob/master/README.md#extra-re-ka-la-re-ka-la-re-ka-la which is supposedly useful...
    @NickTomlin if you have any kind of experience on that matter, I would gladly accept PR/help... because I never worked with SauceLabs before and won't have much time to invest into that ...
    Douglas Duteil
    @douglasduteil
    Just saying
    • geSaLaKaCuLa (for Generate SauceLabs Karma Custom Launchers) is a SauceLab browser config generator for the custom launchers options in Karma. It helps you write less to run your code in more SauceLab browser
    • reKaLa (for Recursive Karma Launcher) is a recursive wrapper to launch a lot of SauceLab browser without letting SauceLab queuing all (more effective for massive number of browsers)
    Jon Scolamiero
    @jdscolam
    j0 j0, quick question, is there anyway to keep the separator characters in the value saved to the model?
    e.g. 11/11/2015 would be written just like that into the model.
    Jon Scolamiero
    @jdscolam
    Anyonehere?
    Adrien Crivelli
    @PowerKiKi
    @jdscolam i don't think there is a way to do what you want
    Jon Scolamiero
    @jdscolam
    That's too bad, I really like this mask.
    but ui-mask seems like a nicer implementation.
    Anderson Ribeiro e Silva
    @dimrsilva
    @jdscolam You can set modelViewValue attribute to true.
    Jon Scolamiero
    @jdscolam
    @dimrsilva Ooh, neat, let me try that!
    Jon Scolamiero
    @jdscolam
    Looks to be working perfectly, thank you @dimrsilva !
    Nick Tomlin
    @NickTomlin
    @PowerKiKi I use Sauce at work so i'd be happy to help submit a PR. We'd need an name, email, and login to tie to the account. I'm not sure the best way to coordinate on that (ideally it would be accessible by multiple maintainers). I'd be happy to sign up with an email and then send the password via Keybase or another service. Once that's done I can work on getting things running locally and on Travis. I'll definitely look into geSaLaKaCuLa reKaLa
    (also, apologies for the late reply, I'm not so great about Gitter)
    Adrien Crivelli
    @PowerKiKi
    @NickTomlin I'd say, go ahead, create whatever you need, and we'll see later to share access
    Nick Tomlin
    @NickTomlin
    @PowerKiKi awesome, will do!
    Nick Tomlin
    @NickTomlin
    I've really enjoyed using this for some of the small modules that I maintain https://github.com/semantic-release/semantic-release . It seems like it might be good fit for ui-mask
    Adrien Crivelli
    @PowerKiKi
    I just automated a bit more the release process :-/ but semantic-release seems interesting... I would like to avoid the complexity of things like angular-ui-publisher. While it did its job I felt it was a bit overly complex/obscure. But again semantic-release sounds good. If somebody have time to experiment with it someday ... ...
    Denis Yaremov
    @lu4
    Guys there are several problems with ng-model integration, please consider the following PR for additional info: angular-ui/ui-mask#48
    TheBekker
    @TheBekker
    Is it possible to make a mask like so: **-AnyCharsOfAnyLength, so it could be: "9b-123abc" or it could be "9b-123456abcdeg". hope this makes sense
    Nick Tomlin
    @NickTomlin
    Would anyone be interested in talking about a v2 roadmap? I feel like there are a lot of wonky things that need to be fixed in a more comprehensive way than the attempts at patching we've been making so far. I'm actually going to be switching off of a project that uses ui-mask soon (going to do back-end dev for a bit) so I won't be much help in actually writing stuff. I'd be happy to help organize, however.
    One big thing is splitting things up into smaller more easily reasoned about modules
    Adrien Crivelli
    @PowerKiKi
    I agree with you current situation is less than ideal. Of all the angular-ui projects I follow this one is by far the most "active" one (in a negative way). However I won't have any time to invest in this project either
    Luke Pfeiffer
    @lukepfeiffer10
    @NickTomlin I would be interested in talking about a v2. I have a decent amount of time to work on it as well.
    Adrien Crivelli
    @PowerKiKi
    @lukepfeiffer10 I believe @NickTomlin's opinion would be interesting if he has time for that. But most likely you'll have to take the initiative here and start something on your own.
    Again, I'm merely a maintainer here, I never used the lib, neither wrote actual code for it. So I don't have significant contributions to make unfortunately.
    According to latest contributions, @Tim91084, @peterox, @toddbranch, @marbletravis and @dimrsilva may have some interest in a v2...
    Adrien Crivelli
    @PowerKiKi
    If you are able to come up with a working v2, I'll add you to the team so you can work directly on the official repo
    Luke Pfeiffer
    @lukepfeiffer10
    @PowerKiKi Thanks for insight. I just started really digging into the code so I'm not really familiar yet what some of the wonky things are mentioned by @NickTomlin. Hopefully he will have some time to talk about it and we can get something put together.
    Adrien Crivelli
    @PowerKiKi
    @lukepfeiffer10 one wanted feature would be to have a filter service (angular-ui/ui-mask#31). More generally speaking, that would mean a better split architecture (smaller "modules" that you can put together). Attributes may be confusing, and I'm wondering if a somehow unified way to configure the directive would be better. But what seems to be the biggest PITA are all the edge cases on different browers/OS and configurations (placeholder corruption, broken behavior when combined with other directives, integration with validation system). I think comprehensive tests should be a very strong point for a v2.
    Nick Tomlin
    @NickTomlin
    Sorry to chime in late here. I completely agree with @PowerKiKi that tests are the most important thing to stop regressions and weird bugs from popping up
    Luke Pfeiffer
    @lukepfeiffer10

    @NickTomlin Alright. I was thinking that the maskSpec file needed to be split into separate files to easier group some of the tests anyway. That plus some more and better tests I could work on first.

    Let me know any other thoughts as well. I have been working on a very basic ui-mask filter as well as just familiarizing myself with the main ui-mask code. I haven't seen any low hanging fruit for modularizing the main ui-mask code yet so any ideas there are greatly appreciated.

    Kerry McCullough
    @kmccullough
    Any particular reason why the parser is pushed onto modelCtrl.$parsers rather than unshifted?
    Causing me many headaches
    Luke Pfeiffer
    @lukepfeiffer10
    Is it standard for new parsers to be unshifted onto the parser array?
    I'm not sure why it is pushed and not unshifted but I am curious as to why it's a problem.
    Kerry McCullough
    @kmccullough
    Just raised an issue on it
    It is a problem because there needs to be consistency
    you can't push some and unshift others
    $parsers should be unshifted and $formatters should be pushed
    Luke Pfeiffer
    @lukepfeiffer10
    Should be a relatively easy change if you want to submit a PR. Not sure if anyone here would actually know if there is a specific reason the parser was pushed instead of unshifted. Do you happen to have a reference that explicitly states that $parsers should be unshifted? Not saying you are wrong but I haven't found anything that states it in those words.
    Kerry McCullough
    @kmccullough
    I can submit a PR. No, I am having trouble finding anything official that states it, it's not so much a hard and fast rule, I guess