Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Kerry McCullough
    @kmccullough
    Exactly, but it doesn't appear there is one
    In this particular case it makes sense to unshift it anyway since this directive very specifically needs to work with the actual viewValue
    since it is a visual thing
    Luke Pfeiffer
    @lukepfeiffer10
    In that case I'm more inclined to just leave it as is unless someone from the angular team can weigh in on the issue. Maybe they would answer on their main github repo?
    Kerry McCullough
    @kmccullough
    Maybe I was not clear
    Luke Pfeiffer
    @lukepfeiffer10
    ?
    Kerry McCullough
    @kmccullough
    So, there may be no standard as to which side of the array to put new parsers, but since this particular parser is very specifically tied to the actual viewValue, it should be unshifted so that it is closer to the viewValue
    Luke Pfeiffer
    @lukepfeiffer10
    Oh I see
    Kerry McCullough
    @kmccullough
    In other words it would make no sense to have a parser previous to this one, since it works on the actually displayed value
    Luke Pfeiffer
    @lukepfeiffer10
    Since it literally has to be run first
    Kerry McCullough
    @kmccullough
    right
    Luke Pfeiffer
    @lukepfeiffer10
    I can see the reasoning behind that.
    Kerry McCullough
    @kmccullough
    But otherwise, outside of this case, I would agree that besides my own logic, I don't see any standard side of the array that should be added to
    Luke Pfeiffer
    @lukepfeiffer10
    Same. Here is to hoping the tests pass after that change ha
    Kerry McCullough
    @kmccullough
    I'll run
    Kerry McCullough
    @kmccullough
    Is there anything I should know about contributing?
    Like do I need to make a branch or something?
    Luke Pfeiffer
    @lukepfeiffer10
    I can't think of anything off the top of my head. Just the normal fork and pull request. That's what I have done
    Kerry McCullough
    @kmccullough
    k
    Kerry McCullough
    @kmccullough
    tests pass
    Luke Pfeiffer
    @lukepfeiffer10
    Cool submit the PR. Oh try to make it a single commit. Forgot about that
    Kerry McCullough
    @kmccullough
    it is, it's a one liner
    are you the maintainer?
    Luke Pfeiffer
    @lukepfeiffer10
    No I just happen to be the most active right now
    Adrien Crivelli
    @PowerKiKi
    @kmccullough I guess I would be the maintainer, but ironically enough I may be the one that know the less about this lib, since I didn't code it nor used it :P
    Luke Pfeiffer
    @lukepfeiffer10
    No worries @PowerKiKi as long as you keep merging PRs for us 😃
    Jonathan Solorzano
    @fenixsolorzano
    How does the optional work?
    Luke Pfeiffer
    @lukepfeiffer10
    If you have a mask like so, 9999? the fourth digit in your mask can be included or excluded and still be considered a valid value.
    Adrien Crivelli
    @PowerKiKi
    @lukepfeiffer10 is taking over ui-mask project, wish him luck !
    Hai Trung
    @HaiTrung
    Hello every body! Can you help me. I need to mask a text input in Angularjs. Have a function in Angular UI do it?
    Farhan Salam
    @farhansalam
    Hi guys need a little help here.
    it might seem a bit stupid but iam kinda stuck here with including the module using ui.mask . ui-mask lib is installed using bower and i can see the angular.module loaded in vendor.js which is included in index.html file using grunt
    but still getting the
    Module 'ui.mask' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
    Adrien Crivelli
    @PowerKiKi
    @farhansalam this should work: var app = angular.module('demo', ['ui.mask']);
    Farhan Salam
    @farhansalam
    @PowerKiKi Thanks for the help. This is exactly what I was doing. Actually there was an error in a library other than ui-mask and it was causing all libs included after it in vendor.js to fail.
    fixed it
    Manar Kurmanov
    @manar-mk
    hi)
    a question about masking
    how to define this pattern? \d+
    in ui-mask
    roosuocha
    @roosuocha
    I second the @manar-mk question
    Main gripe being when working with currency formatted data -- placeholders are stubborn. If I want to enter $1098.02, and I have space for a million dollars, i.e. $?9?9?9,?9?9?9,?9?9?9.99, entering the above yields $109,802, _ _ _ . _ _
    Emmanuel Arzate
    @Eiarzate1
    I had to dig in the mask.js file to find the attribute allowInvalidValue.
    I am using it now. But I spent a few hours trying to save invalid values through some tmp var. That wasn't working since the value would get cleared by ui-mask. It would be good if allowInvalidValue was in the docs.
    Adrien Crivelli
    @PowerKiKi
    @Eiarzate1 please create a PR to improve the docs
    Heyligen Grégory
    @heyligengregory
    Hi, a question about using ui-mask on IE. Does placeholder works on your side ?
    It seems that there is trouble, its like the input was onFocus but it's not
    Mikael Pettersson
    @Evanion
    Is there any way to dynamically add the separators to the mask when the user is typing?
    IE, the mask might look like this: 999-9999 .. when the user have typed 12nothing of the mask is visible, but when the user inputs the third char, the dash in the mask is added, and the user continues with the forth number etc?
    Manar Kurmanov
    @manar-mk
    hi guys is there version for angular 2 ?
    Adrien Crivelli
    @PowerKiKi
    @manar-mk AFAIK there is nothing for angular 2+