angular-ui/ui-router

The de-facto solution to flexible routing with nested views

Mark Wilkins

@markwilk

Having trouble creating a plnkr to replicate, so thought I'd ask to see if this rings a bell for anyone... Have you ever had a case where the browser's back button updates the URL, but the state doesn't actually change? And then, if I click any link/state in the view, the state DOES change to where I expected the back button to take me, not that target of the clicked link? Details to follow...

AngularJS 1.7.3, ui-router 1.1.40. I start at state a.b.c, which has nested views, and has a list of "items". I click on an item in the innermost view, which takes me to state d.

Mark Wilkins

@markwilk

Then I hit the back button from state d, and the URL changes back to a.b.c, and the state loads correctly.

BUT THEN

Cody Mikol

@codymikol

Any console errors?

Mark Wilkins

@markwilk

I follow the same link from a.b.c, or even a different one, and the I go to a new "item".

The second (and every subsequent) time, the back button updates the URL, but doesn't change the state back to a.b.c

@codymikol no, no errors.

And I have tracing turned on, but nothing is written out for those subsequent clicks of the back button

UNTIL I click some other link on the "item" page...and then it takes me where the back button should have taken me

Again, sorry no plnkr...but I couldn't get it to fail there. :-/

Cody Mikol

@codymikol

@markwilk Doesn't ring a bell unfortunately :(

Mark Wilkins

@markwilk

Thanks for replying, @codymikol . When I get a few more minutes, I'll try the plnkr again.

Mark Wilkins

@markwilk

Duh. Turned out that an unrelated directive was unbinding too many window events, which was causing the issue. Never mind. :-/

Cody Mikol

@codymikol

Chris Thielen

@christopherthielen

@cxvvs that does look like a bug 🤔 I would have expected a promise injected

Tom McKearney

@tommck

Hey @christopherthielen .. any chance you can address this? ui-router/core#229

Chris Thielen

@christopherthielen

I’ll try to make some time this week

Tom McKearney

@tommck

:+1:

Chris Thielen

@christopherthielen

@tommck how do I reproduce this typescript error?

Tom McKearney

@tommck

build any app that uses it with "strict": true in the tsconfig.json

Chris Thielen

@christopherthielen

ah, let me try that

got it, thanks

Tom McKearney

@tommck

awesome.. thanks for doing that

Deepak

@deepak20c

how to call any service while closing window/tab

Tom McKearney

@tommck

that has nothing to do with routing

Tom McKearney

@tommck

If you want to do lazy loading in Angular, do you need to use SystemJS? I'm a little confused about the implied dependency there

Tom McKearney

@tommck

Unrelated: this code: https://github.com/ui-router/sample-app-angular doesn't have a tsconfig.json file and won't run w/ "npm start" (gets a bunch of TS errors in the node_modules folder) (Created an issue: https://github.com/ui-router/sample-app-angular/issues/332#issue-419528912)

Tom McKearney

@tommck

might not be related to the tsconfig file

Tom McKearney

@tommck

NOTE: That code does have a tsconfig.json, it's just not in the root folder

Chris Thielen

@christopherthielen

No you don’t need systemjs

There is some DI provider with SystemJS in the name that I think is required, but it doesn’t actually use SystemJS. if I remember correctly

Shawn Rieger

@riegersn

Hello! I’m trying to modify state param mid transition, during the resolve (ui-router /angularjs) Is this possible?

Chris Thielen

@christopherthielen

Hi Shawn. The idiomatic way is to redirect the transition if you need to change params

you can’t really do that from a resolve but you can from a transition hook

Tom McKearney

@tommck

Hey all, @christopherthielen - any chance you can take a look at this problem on SO? https://stackoverflow.com/questions/55579916/uirouter-angular-error-staticinjectorerrorappmodulefooservice-stateservi
We've been having this issue on and off and can't figure out what's causing it

tommck @tommck thinks it's time to move away from ui-router

Enl0ve

@Enl0ve

rencently, I find below content on the source code of ui-router, other dom events, You can also customize which DOM events to respond to (instead ofclick) by providing aneventsarray in theui-sref-optsattribute, such as ui-sref-opts="{ events: ['change', 'blur'] }", I try, but failed, anybody who can help me? Thank you

Jakobinec

@Jakobinec

Hi! Can I ask a question about @uirouter/angular-hybrid? Am I in the right place?
I have a hybrid application (Angular+AngularJS). It was created by tutorials from your official sight https://github.com/ui-router/angular-hybrid
And now I want to navigate to url from Angular component TypeScript code.
Could you tell me please the proper way how can I do it (like "this.router.navigate('/dashboard')") and what class I should import.
Thanks!

Chris Thielen

@christopherthielen

Inject UIRouter then use UIRouter.stateService.go('dashboard')

https://ui-router.github.io/ng2/docs/latest/classes/state.stateservice.html#go

Jakobinec

@Jakobinec

Hello! How can I inject Transition into service. This code works well in component, but does not work in service:
const rootScope = this.transition.injector().get('$rootScope');
rootScope.menuItem = 'documentsUpg';
I use hybrid routing (Angular + AngularJS)

Chris Thielen

@christopherthielen

you can not inject $transition$ into a service because it’s not a global object

Gabe

@gabrielmiller_gitlab

I'm working on an AngularJS app that uses an older version of ui-router, 0.4.3. I'd like to some day port the app into Angular2+ and https://github.com/ui-router/angular-hybrid looks like a promising path to upgrade parts of the application piecemeal. That said, I'm trying to get a grasp on router upgrade path.

It's not clear to me what the minimum starting version of ui-router is before implementing angular-hybrid. Should I upgrade ui-router from 0.4.3 to 1.x as a step before implementing angular-hybrid?

I was intending to follow the ui-router upgrade here https://ui-router.github.io/guide/ng1/migrate-to-1_0#breaking-changes, but I wanted a sanity check to see if this is fact necessary before implementing angular-hybrid.

Princeton Collins

@princetoncollins

@Gabe I'm currently in the process of migrating an AngularJS app to Angular. I can share my package.json that shows the current versions I'm using for all ui-router and angular packages if you'd like.

Gabe

@gabrielmiller_gitlab

@princetoncollins that would be appreciated, thank you

Princeton Collins

@princetoncollins

@gabrielmiller_gitlab

"dependencies": {
    "@angular/animations": "^8.2.9",
    "@angular/cdk": "^8.2.3",
    "@angular/common": "^8.2.9",
    "@angular/compiler": "^8.2.9",
    "@angular/compiler-cli": "^8.2.9",
    "@angular/core": "^8.2.9",
    "@angular/forms": "^8.2.9",
    "@angular/material": "^8.2.3",
    "@angular/platform-browser": "^8.2.9",
    "@angular/platform-browser-dynamic": "^8.2.9",
    "@angular/platform-server": "^8.2.9",
    "@angular/router": "8.2.9",
    "@angular/upgrade": "^8.2.9",
    "@uirouter/angular": "6.0.1",
    "@uirouter/angular-hybrid": "9.0.0",
    "@uirouter/core": "6.0.1",
    "@uirouter/rx": "^0.6.5",
    "core-js": "^2.5.4",
    "zone.js": "^0.10.2",
    "rxjs": "^6.5.5",
    "rxjs-compat": "^6.5.5",
}

Don't think you'll need @angular/cdk or @angular/animations and @angular/material.

Where communities thrive

People

Repo info

Activity