These are chat archives for angular/material

30th
Nov 2015
Steven Weingärtner
@eXaminator
Nov 30 2015 07:54
@felixfbecker Thanks for the link!
Brett Nimphius
@itsastute
Nov 30 2015 19:44
Is angular the best framework for MDL?
Ed Pelc
@epelc
Nov 30 2015 21:35
elad you here?
Elad Bezalel
@EladBezalel
Nov 30 2015 21:38
i am now
Ed Pelc
@epelc
Nov 30 2015 21:39
good
I found out why .toUpperCase() fixes it
Elad Bezalel
@EladBezalel
Nov 30 2015 21:39
why?
Ed Pelc
@epelc
Nov 30 2015 21:39
It's essentially removing this angular/material@f62f693 if you switch it to .toUpperCase() !== 'md-content'
that commit broke tooltips for a lot of people to fix his usecase with the sidenavs
Elad Bezalel
@EladBezalel
Nov 30 2015 21:40
'elad'.toUpperCase() is 'ELAD'
oh so your'e saying that we need to use toUpperCase in there also
Ed Pelc
@epelc
Nov 30 2015 21:41
but 'md-content'.toUpperCase() !== 'md-content' so it effectivly gets rid of the the !== check added above which broke things for everyone
I think we need to reverse that commit only check that it !== 'MD-CONTENT' if a sidenav is open
This is where it also broke tooltips for several other people https://github.com/angular/material/pull/5161#issuecomment-149153559
Elad Bezalel
@EladBezalel
Nov 30 2015 21:44
i can't understand why 'md-content'.toUpperCase() !== 'MD-CONTENT' is not good..
Ed Pelc
@epelc
Nov 30 2015 21:45
it makes that loop stop at the root html element instead of md-content
the old behavior was it stopped at md-content which worked for 99% of people. But I guess it was broken with sidenavs open so @kasiarachwal added that fix which broke it for the 99% usecase
Elad Bezalel
@EladBezalel
Nov 30 2015 21:46
so we need to just remove this check?
Ed Pelc
@epelc
Nov 30 2015 21:47
while (current && current !== $rootElement[0] && current !== document.body && current.nodeName !== 'MD-CONTENT') { just makes it so it doesn't stop at md-content. I though .toUpperCase() would make it work for both but it doesn't
yes
but I imagine that will piss @kasiarachwal off and he will try to readd it so we need a check in that loop to skip the md-content if a sidenav is open
Elad Bezalel
@EladBezalel
Nov 30 2015 21:49
can you create a PR and put all the information you have on this issue in there just to make it clear, tag me and i will review and dive into this when it's ready
it will help us a lot cause right now we have many work thats need to be done asap.
Ed Pelc
@epelc
Nov 30 2015 21:51
I'll get a demo from @kasiarachwal first so I can make sure whatever I do fixes his usecase and the regular one then I'll make a pr
I'm not sure if you want to revert angular/material@f62f693 for now as it breaks tooltips for most people. I don't mind as I'm on an internal fork with that reverted anyways. I also have to wait for at least rc6 to get back on the main repo as there are a few issues I found while testing it
Elad Bezalel
@EladBezalel
Nov 30 2015 21:55
As always, a PR will be very welcomed. i hope @kasiarachwal will answer soon so we can solve this issue.
Ed Pelc
@epelc
Nov 30 2015 21:57
I just sent him a message https://github.com/angular/material/commit/f62f6934c02f4c994f3e9a9157cc0de351dd8c79#commitcomment-14694446 I'll make a PR and mention you when he gets back to me
Elad Bezalel
@EladBezalel
Nov 30 2015 21:58
Thank you! :)