Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 11 2016 19:26

    Splaktar on master

    fix(toast): apply theming corre… perf(icon): better handling of … fix(list): copy ng-show, ng-hid… and 49 more (compare)

  • Jun 15 2016 16:14

    Splaktar on v1.1.0-rc.5

    release: version 1.1.0-rc.5 (compare)

  • May 14 2016 05:55

    Splaktar on master

    feat(panel): initial implementa… update(panel): promise logic im… update(panel): add and remove p… and 44 more (compare)

  • May 05 2016 20:47

    Splaktar on v1.1.0-rc4

    release: version 1.1.0-rc4 (compare)

  • May 05 2016 20:47

    Splaktar on v1.1.0-rc3

    release: version 1.1.0-rc3 (compare)

  • May 03 2016 22:28

    Splaktar on es6-tutorial

    Prepare clean start Remove bow… install angular-material And i… working version of starter-app and 19 more (compare)

  • May 03 2016 22:22

    Splaktar on master

    Tutorial Readme updates Updates for Tutorial #2 Update README with tutorial ste… and 56 more (compare)

  • May 01 2016 22:56

    Splaktar on fixBlurryRightNavIe11

    fix(sidenav): rightNav button a… (compare)

  • May 01 2016 22:37

    Splaktar on master

    fix(dialog): don't clobber md-d… update version number in packag… update(changelog): sort so 1.1.… and 1 more (compare)

  • May 01 2016 22:34

    Splaktar on fixSideNavDemo

    docs(sidenav): leftNav text isn… (compare)

  • Apr 27 2016 04:14

    Splaktar on fixSideNavDemo

    docs(sidenav): invalid `md-whit… (compare)

  • Apr 27 2016 03:54

    Splaktar on master

    update(changelog): add missing … fix(toolbar): remove transition… fix(tests): Cleans up the DOM a… and 2 more (compare)

  • Apr 23 2016 01:32

    Splaktar on master

    update(docs): improve docs for … update(docs): renamed `md-text-… fix(list): clickable list-items… and 71 more (compare)

  • Apr 11 2016 03:20

    Splaktar on improveExtendThemeDoc

    update(docs): improve docs for … (compare)

  • Apr 11 2016 03:15

    Splaktar on improveExtendThemeDocs

    update(docs): improve docs for … (compare)

  • Apr 11 2016 02:57

    Splaktar on updateThemingDocs

    update(docs): renamed `md-text-… (compare)

  • Apr 11 2016 02:48

    Splaktar on master

    fix(demo, codepen): use secure … fix(build, layout): remove depr… update(build): remove stale bow… and 72 more (compare)

  • Apr 11 2016 02:48

    Splaktar on v1.1.0-rc2

    release: version 1.1.0-rc2 (compare)

  • Mar 19 2016 03:00

    Splaktar on master

    fix(checkbox): pointer events d… update(tests): remove disabled/… fix(datepicker): enable scrolli… and 20 more (compare)

  • Mar 13 2016 05:41

    Splaktar on v1.0.6

    Revert "fix(select): made selec… update(layout): add layout-nowr… fix(whiteframe): update breakpo… and 57 more (compare)

Ed Pelc
@epelc
good
I found out why .toUpperCase() fixes it
Elad Bezalel
@EladBezalel
why?
Ed Pelc
@epelc
It's essentially removing this angular/material@f62f693 if you switch it to .toUpperCase() !== 'md-content'
that commit broke tooltips for a lot of people to fix his usecase with the sidenavs
Elad Bezalel
@EladBezalel
'elad'.toUpperCase() is 'ELAD'
oh so your'e saying that we need to use toUpperCase in there also
Ed Pelc
@epelc
but 'md-content'.toUpperCase() !== 'md-content' so it effectivly gets rid of the the !== check added above which broke things for everyone
I think we need to reverse that commit only check that it !== 'MD-CONTENT' if a sidenav is open
This is where it also broke tooltips for several other people https://github.com/angular/material/pull/5161#issuecomment-149153559
Elad Bezalel
@EladBezalel
i can't understand why 'md-content'.toUpperCase() !== 'MD-CONTENT' is not good..
Ed Pelc
@epelc
it makes that loop stop at the root html element instead of md-content
the old behavior was it stopped at md-content which worked for 99% of people. But I guess it was broken with sidenavs open so @kasiarachwal added that fix which broke it for the 99% usecase
Elad Bezalel
@EladBezalel
so we need to just remove this check?
Ed Pelc
@epelc
while (current && current !== $rootElement[0] && current !== document.body && current.nodeName !== 'MD-CONTENT') { just makes it so it doesn't stop at md-content. I though .toUpperCase() would make it work for both but it doesn't
yes
but I imagine that will piss @kasiarachwal off and he will try to readd it so we need a check in that loop to skip the md-content if a sidenav is open
Elad Bezalel
@EladBezalel
can you create a PR and put all the information you have on this issue in there just to make it clear, tag me and i will review and dive into this when it's ready
it will help us a lot cause right now we have many work thats need to be done asap.
Ed Pelc
@epelc
I'll get a demo from @kasiarachwal first so I can make sure whatever I do fixes his usecase and the regular one then I'll make a pr
I'm not sure if you want to revert angular/material@f62f693 for now as it breaks tooltips for most people. I don't mind as I'm on an internal fork with that reverted anyways. I also have to wait for at least rc6 to get back on the main repo as there are a few issues I found while testing it
Elad Bezalel
@EladBezalel
As always, a PR will be very welcomed. i hope @kasiarachwal will answer soon so we can solve this issue.
Ed Pelc
@epelc
I just sent him a message https://github.com/angular/material/commit/f62f6934c02f4c994f3e9a9157cc0de351dd8c79#commitcomment-14694446 I'll make a PR and mention you when he gets back to me
Elad Bezalel
@EladBezalel
Thank you! :)
Sam Ashley
@kwaledesign
I seem to recall reading somewhere it is possible to generate a standalone app for a single component for debugging purposes. Anyone else remember any such thing?
Mathew Foscarini
@thinkingmedia
is that anyway related to the demos in ngDoc?
Fiorald Ismaili
@Fiorald
Hi
can anyone tell me how to install angular js in html
Mathew Foscarini
@thinkingmedia
you just include it
Fiorald Ismaili
@Fiorald
How can I include it
is it same as installing javascript
?
add that <script> tag to the HTML
it takes more than just that to do anything with angularjs
Fiorald Ismaili
@Fiorald
i never developed with angular
but thank you
Fiorald Ismaili
@Fiorald
That helps
thank you
Angel S. Moreno
@angelxmoreno
any reason md-no-ink can not be used as a class? I am using ui-router and I want to remove the ink effect using ui-sref-active any ideas?
skjorrface
@skjorrface
hi. Anybody got a clue about how to get md-tabs fixed and their contents scrolling? Googling didn't help much
billy clark
@wcjr
I was just curious if anyone else feels like having to add the md-toolbar-tools class to md-toolbar (or its children) seems unnecessarily verbose? Why not just have the directive add the class automatically?
Miloš Stanić
@MilosStanic
@wcjr +1
Angel S. Moreno
@angelxmoreno
@wcjr everything I’ve seen thus far is overly verbose
billy clark
@wcjr
I'll put in request for it then if nobody thinks there's a good reason for it. Thanks @MilosStanic @angelxmoreno
Angel S. Moreno
@angelxmoreno
@wcjr I think that if it is addressed there then it should be addressed everywhere. If md-toolbar can not be used outside of md-toolbar-tools and all of md-toolbar-tools children are md-toolbar, then why so much verbosity? I think there might be a good reason but it eludes me ATM.
billy clark
@wcjr
yeah, I'm assuming the same thing. I put a post in the forum to see if anyone else knows of a good reason: https://groups.google.com/forum/#!topic/ngmaterial/8NDNvJvOeGs
Angel S. Moreno
@angelxmoreno
there is something very weird about angular-material. I look at it and think “Whoa, why so much” but the more I use it the more I am determine to be L33T in it. I’m about to create IonicFramework for Desktop, lol. Amazing work was put into AngularMaterial.