Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Sam Harwell
    @sharwell
    I'm not 100% sure. I would need to see the grammar to know more. Here is the main documentation for v4: https://github.com/antlr/antlr4/blob/master/doc/index.md
    Terence or one of the other users is more likely to be helpful, but they don't visit this room. You'll want to send a message to the google groups mailing list.
    Chrizzly
    @Chris2011
    ok thx
    This was generated from the antlrv3.*
    But ok maybe it would be better to generate the Java files new from the ANTLRv4 right?
    Sam Harwell
    @sharwell
    Oh, they are nothing alike
    Totally different output
    Chrizzly
    @Chris2011
    ok
    Sam Harwell
    @sharwell
    I see you use output=AST. That no longer exists with ANTLR 4 so you'll have a bit of work to convert.
    Chrizzly
    @Chris2011
    I only cloned the repo and changed the Icon for files and change the dependecies. Nothing more
    So maybe it will be better to use the old antlrv3.*
    Sam Harwell
    @sharwell
    Actually maybe not, since the tree is flat from that grammar.
    Maybe. This should all be automatic though
    Chrizzly
    @Chris2011
    Can you summerize the differences between v3 and v4?
    Maybe it is better to revert my modifications and change it back to v3
    Sam Harwell
    @sharwell
    I'm looking at the project now
    Chrizzly
    @Chris2011
    Thx
    Chrizzly
    @Chris2011
    Sry I should had give you the fork of it: can you do the pull request to my repo please? https://github.com/Chris2011/Cetriolo
    If not, I can copy it over manually.
    Sam Harwell
    @sharwell
    Alright I took a look. Are you trying to make changes to the grammar?
    Chrizzly
    @Chris2011
    No, if the grammar is fully functional than everything should be fine. I only wanted to update to the newest antlrv4 version
    Sam Harwell
    @sharwell
    Oh, no. You don't want to update.
    ANTLR 4 is better, but it's not like other projects where you just do a quick update and it's done.
    Chrizzly
    @Chris2011
    Not?
    Ok
    So what are your changes?
    Sam Harwell
    @sharwell
    No, it's taken some projects months
    Chrizzly
    @Chris2011
    :D
    Sam Harwell
    @sharwell
    To create ANTLR 4 we did not start with the ANTLR 3 code
    We started from scratch
    Chrizzly
    @Chris2011
    ok yeah I thought so...
    ok so I should be go back to antlrv3.*?
    Sam Harwell
    @sharwell
    For me, when I opened that project it compiled just fine. I wouldn't make changes to the ANTLR part unless they are broken.
    Chrizzly
    @Chris2011
    Ok, so make the PR to my project and I will add it and will still use the Antlrv3
    Chrizzly
    @Chris2011
    So as I see it right, you removed the ouput package and the java files from the repo and changed the numbers to the enum names?
    Sam Harwell
    @sharwell
    Yes
    Chrizzly
    @Chris2011
    Ok thx.
    Chrizzly
    @Chris2011
    One other questions, it's about the C# lexer. In this tutorial: http://wiki.netbeans.org/New_Language_Support_Tutorial_Antlr at 2) LanguageHierarchy. It says that I should create a enum class from the tokens file, so manually. This is the source of the tokens file of the CSLexer file: https://pastebin.com/ewFec75m. So is it correct, that I need an enum with all that values?
    C. Scott Ananian
    @cscott
    I updated/fixed code rot in the Python and JavaScript targets. Also fixed the Java test suite to work on newer JDK versions (which have slightly different iteration orders for HashSet).