by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
flai
@f-lai
No problem. Appreciate your help though :)
djencks
@djencks
Antora uses isomorphic-git internally, which is pretty wonderful, but it's totally different code from command line git :-)
flai
@f-lai
Yeah : |
djencks
@djencks
This is an area I don't understand well.... do you know why your company doesn't expose the repos via https?
(I don't know if isomorphic-git supports https with client certs, which I think would be pretty much equivalent security to ssh)
flai
@f-lai

This is an area I don't understand well.... do you know why your company doesn't expose the repos via https?

Yeah, corporate policies I guess : | I have no control over it at all. I mean worst case I'd just use git clone + scripts and make Antora read from file system instead.

This seems to be the line that's doing it (transform SSH to HTTPs): https://github.com/isomorphic-git/isomorphic-git/blob/4e66704d05042624bbc78b85ee5110d5ee7ec3e2/src/managers/GitRemoteManager.js#L61

djencks
@djencks
I think I've seen that William Hilton (the isomorphic-git developer) thinks non-https protocols for git are obsolete, so my guess is that supporting ssh is too hard and that it has bizarre quirks. If you do try git clone, I think you can clone to a bare repository and save time by not checking out a corktree.
flai
@f-lai
Yeah I can imagine that happening. Hm, not checking out the worktree? How does Antora read the repos' content? I've never seen a workflow like this. Could you elaborate pls? Is it better than just cloning the repos into the file system?
djencks
@djencks
so.... Antora uses isomorphic-git to make bare clones of remote repos into a cache directory. If you don't specify "--fetch" I think they aren't updated. I don't know how unpacked or compressed the bare clone is. Then Antora reads (only) the relevant files into an in-memory virtual file system, and works with those while doing all the site generation.
I see spell-check turned 'worktree' into 'corktree' :-) sometimes I catch that, sometimes not...
flai
@f-lai

so.... Antora uses isomorphic-git to make bare clones of remote repos into a cache directory. If you don't specify "--fetch" I think they aren't updated. I don't know how unpacked or compressed the bare clone is. Then Antora reads (only) the relevant files into an in-memory virtual file system, and works with those while doing all the site generation.

Oh I see what you mean. Thanks I'd take a look at that : - ) !

Dan Allen
@mojavelinux
OMG, things just won't stay fixed! (just a general sentiment ;))
Guillaume Grossetie
@Mogztter
Asciidoctor Kroki now generates images using the (optional) target positional attribute. Previously we were using an md5sum of the diagram as file name.
We are closer to Asciidoctor Diagram but at the same time we cannot tell if we need to fetch the diagram again from the server
danyill
@danyill
oh hey @Mogztter yes we might need to fix that before the next release or else say users of editors with preview may thrash the server quite a bit
one of the interesting things about Asciidoctor extensions working like this is is that suddenly Asciidoctor "runs" become stateful but there's not really a place to store the state. I saw your idea of a manifest
33 replies
Guillaume Grossetie
@Mogztter
In other words, our poor-man cache does not work anymore. We talked about cache in Antora a few months ago, is there something available for extensions?
Dan Allen
@mojavelinux
nothing more than a convention. you can use the same log used in the content aggregator and UI loader. it would be ANTORA_CACHE_DIR/kroki or something to that affect
Guillaume Grossetie
@Mogztter
ANTORA_CACHE_DIR as in an environment variable? runtime.cache_dir will also set the environment variable?
Hello @danyill :wave:
Dan Allen
@mojavelinux
I was speaking of it as a general placeholder. it's meant to represent the logic that those two components use
there is a sequence that it goes through to find the location
Guillaume Grossetie
@Mogztter
Ok :+1:
desipepova
@desipepova

Hi Everyone! Have anyone faced the following problem where anchor links do not lead to the proper section of the page, but instead load the same from its beginning?

For example https://cloud.restcomm.com/docs/api/usage-records-api.html#_example_of_getting_daily_calls_stats this goes to the top of the page instead of the correct section.

We have recently noticed the issue. I wonder if anyone else faced that too.

Guillaume Grossetie
@Mogztter
Hi, it's working for me on Chrome
djencks
@djencks
It's working for me on Safari
Guillaume Grossetie
@Mogztter
it's also working on Firefox
Dan Allen
@mojavelinux
seems to work fine for me too. can you elaborate?
desipepova
@desipepova
On my side it only works after the page is refreshed. So on the first page load it displays the content from the top of the page. Then if you hit refresh it goes to where the anchor is. I tested that in private mode with Chrome and FF and can replicate the issue on both.
Seems pretty strange to me
Dan Allen
@mojavelinux
keep in mind that there is JavaScript at play here. HTML doesn't natively support jumping to an anchor with a fixed header. so JavaScript intercepts the normal behavior to position it correctly. It's possible this JavaScript isn't working in your browser...though I find that very strange.
also, it would be better if you asked this question in antora/users. this channel is for development of the project itself.
desipepova
@desipepova
Thanks for the input @mojavelinux . I am sorry, I wasn't sure which is correct channel for that. Note taken. :}}
Dan Allen
@mojavelinux
no worries. i just want to make sure you get the best help, and that channel is the one most watched by other users.
desipepova
@desipepova
Thank you!
djencks
@djencks
@mojavelinux I've made some progress documenting asciidoctor 2 changes, and I could push what I have now if you'd like to see it, but it's rather messy. Do you have any examples of "major changes" upgrade docs I could use as a model?
Dan Allen
@mojavelinux
yeah, go ahead and submit. i don't have an example in mind.
djencks
@djencks
OK.... I'll try for tonight. thanks!
djencks
@djencks
@mojavelinux antora/antora!547. I'm not quite sure what direction to go in from here, any orientation or suggestions would be great! I think a few of the descriptions are ok but most could use more work.
Justin Griffin
@griffj_gitlab
is there an easy way to remove the header when extending the default UI? I've tried overriding header.hbs to empty, and overriding the --navbar-height: 0; from vars.css, but can't seem to get the main content to slide up to fill the void where the header content used to be.
djencks
@djencks
probably it won't be different, but have you tried removing header.hbs from whatever includes it?
I think the header height is different from the navbar height.
Justin Griffin
@griffj_gitlab
yes, that's included by the default.hbs in /layouts. Removing the inclusion of {{> header}} from there renders the same result :(
djencks
@djencks
@griffj_gitlab this would actually be better asked on antora/users.... I'm going to see if I can find how the height is set.
what happens if you also remove header.css?
Justin Griffin
@griffj_gitlab
@djencks blanking out header.css seems to have no effect. By "blanking out", I mean I provide an empty header.css in my supplemental_ui/css.
Justin Griffin
@griffj_gitlab

best I've been able to do is override layouts/default.hbs to not include the header. That works for getting the header to not display, but the body still leaves the blank space for the header across the top. I also include a css/site-extra.css from partials/head-meta.hbs that simply sets

:root {
  --navbar-height: 0;
}

I can see this variable override value in the debugger, but it too does not seem to push the body up to the top of the page (to fill in the gap of the missing header.

djencks
@djencks
@griffj_gitlab I thought you had forked the default UI and were modifying the original source rather than adding stuff in supplemental_ui. I don't think you can modify the css in supplemental UI, as it's all glommed together and compressed and ??? into one non-human-readable file. I suppose you might be able to have overrides in some new file, but you'd have to modify the head-styles.hbs to include your modifications after the standard. I think the variables values from vars.css are substituted into their uses, so redefining them isn't going to have any effect. (I might be wrong about this).
Dan Allen
@mojavelinux
the supplemental UI can override handlebars templates, but not the partial CSS files. you can append an additional CSS file like docs.antora.org does, or you can fork the UI and change anything you want
Justin Griffin
@griffj_gitlab
ok thanks @djencks @mojavelinux !
djencks
@djencks
Related to multi-language support, antora/antora#208, I've written up the beginnings of a draft ADR describing all the choices I can think of related to this with, for most, proposals: antora/antora!548. If we get some agreement I might start prototyping it.