Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 14 10:30

    bebraw on master

    fix: Allow unique ids with a + … (compare)

  • Jul 23 2019 16:39
    EugeneHlushko closed #136
  • Jul 23 2019 16:39
    EugeneHlushko commented #136
  • Nov 27 2018 17:48

    bebraw on gh-pages

    Updates (compare)

  • Nov 27 2018 17:45

    bebraw on gh-pages

    Updates (compare)

  • Nov 27 2018 17:45

    bebraw on gh-pages

    Updates (compare)

  • Nov 27 2018 17:31

    bebraw on gh-pages

    Updates (compare)

  • Nov 27 2018 17:30

    bebraw on gh-pages

    Updates (compare)

  • Nov 27 2018 17:30

    bebraw on master

    v0.29.5-alpha.0 (compare)

  • Nov 27 2018 17:30

    bebraw on v0.29.5-alpha.0

    (compare)

  • Nov 27 2018 17:29

    bebraw on master

    fix(antwar): Use deepmerge over… (compare)

  • Nov 27 2018 17:19

    bebraw on master

    fix(antwar): Apply prettier I … (compare)

  • Nov 27 2018 17:12

    bebraw on gh-pages

    Updates (compare)

  • Nov 27 2018 17:12

    bebraw on gh-pages

    Updates (compare)

  • Nov 27 2018 17:12

    bebraw on master

    v0.29.4 (compare)

  • Nov 27 2018 17:12

    bebraw on v0.29.4

    (compare)

  • Nov 27 2018 17:11

    bebraw on master

    fix(antwar): Disable interactiv… (compare)

  • Nov 16 2018 09:22
    bebraw commented #140
  • Nov 16 2018 09:05
    ChibiBlasphem opened #140
  • Oct 14 2018 14:41

    bebraw on master

    chore: Drop a redundant import (compare)

Fernando Montoya
@montogeek
That is a good solution
Juho Vepsäläinen
@bebraw
i tried your patch against webpack site
it fixes the titles :+1:
Fernando Montoya
@montogeek
yeah, me too :D
haha
but only in build time
not while developing
Juho Vepsäläinen
@bebraw
yup, i don't care about the dev mode
it goes through html-webpack-plugin
feels like another, more complicated fix
Fernando Montoya
@montogeek
I could take a look :D
What about using react-helmet?
That would make things easier
Juho Vepsäläinen
@bebraw
iirc i considered that but EJS felt cleaner
Fernando Montoya
@montogeek
Yeah, just plain templates are great
Juho Vepsäläinen
@bebraw
EJS fit straight into html-webpack-plugin so it was a good fit
not perfect, but good enough
Fernando Montoya
@montogeek
oh nice
didn't know that
Juho Vepsäläinen
@bebraw
it was updated to default to EJS some time ago
if you look at a page like http://localhost:3000/loaders/css-loader you can see duplicate title. that's an easy fix
iirc you may want to define a custom layout for plugin/loader pages
there's also some preprocessing going on if you want to dig more info there (stars etc.)
Fernando Montoya
@montogeek
In the webpack site?
Juho Vepsäläinen
@bebraw
it fetches the info through github
yeah
Fernando Montoya
@montogeek
oh yeah, also contributors
Juho Vepsäläinen
@bebraw
see esp. scripts
Fernando Montoya
@montogeek
processPage
Juho Vepsäläinen
@bebraw
it's flexible so you can alter it to your liking
Fernando Montoya
@montogeek
Or at least, I couldnt find where Antwar called it
Juho Vepsäläinen
@bebraw
it's possible i dropped it at some point. not sure
let's see
yeah, gone
Fernando Montoya
@montogeek
haha, thats why
This page doesn't exist in my build http://localhost:8000/loaders/css-loader
Juho Vepsäläinen
@bebraw
if that was added back, i would overload title
yeah, you probably need to run the crawler first
Fernando Montoya
@montogeek
how to?
fetch?
Juho Vepsäläinen
@bebraw
npm run fetch might be the key
Fernando Montoya
@montogeek
:D
Juho Vepsäläinen
@bebraw
it gets more info that is shown
Fernando Montoya
@montogeek
yep, i see
I gotta go
Juho Vepsäläinen
@bebraw
sure. cya
Fernando Montoya
@montogeek
Thanks for the help @bebraw
cya
Juho Vepsäläinen
@bebraw
you can work from there if you want :)