by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Mohsen Azimi
    @mohsen1
    A lot of people are using this tool https://www.npmjs.com/package/swagger-converter
    first of all it should be part of a major release
    Ivan Goncharov
    @IvanGoncharov
    That is why I want to do this in 1.0.0
    Mohsen Azimi
    @mohsen1
    We should also throw proper errors if people are passing arguments based on previous API syntax
    Ivan Goncharov
    @IvanGoncharov
    Ok
    Mohsen Azimi
    @mohsen1
    Awesome!
    Ivan Goncharov
    @IvanGoncharov
    and if you want to use it in swagger-converter
    CLI syntax should be changed
    Mohsen Azimi
    @mohsen1
    in swagger-tools you meant, right?
    ok, those are steps after we release 1.0
    Ivan Goncharov
    @IvanGoncharov
    yes, swagger-tools
    Mohsen Azimi
    @mohsen1
    swagger-tools is kind of being replaced by sway and swagger command line tool (npm i -g swagger)
    Ivan Goncharov
    @IvanGoncharov
    convert [options] <resourceListing> <apiDeclarations...>
    Converts Swagger 1.2 documents to a Swagger 2.0 document
    Mohsen Azimi
    @mohsen1
    but I'll take care of those after the fact
    Ivan Goncharov
    @IvanGoncharov
    ok
    Mohsen Azimi
    @mohsen1
    We should release 1.0 and wait a couple of weeks to fix bugs that usually pop up after releases
    Jose Galisteo
    @ceritium
    Hi! I'm trying to convert a swagger 1.2 to swagger 2.0 with swagger-tools (CLI)
    the problem is that the 1.2 spec has a undocumented param attribute
    any suggestion?
    @ceritium
    would be interesting a pull request that accept custom attributes for params like 2.0
    x-whatever
    ?
    Nuba Princigalli
    @nuba

    Hello folks, I'm getting

    $ api-spec-converter  http://0.0.0.0:3000/explorer/resources --from swagger_1 --to swagger_2  > api-converted.json
    [Error: Exception during convertion: SwaggerConverterError: Second argument(apiDeclarations) should be plain object, see release notes.]

    when running api-spec-converter in a machine but then it's running flawless in another. how should I go about debugging this?

    Ivan Goncharov
    @IvanGoncharov
    First try
    npm update
    on both machines
    Also check node versions: node --version
    Ivan Goncharov
    @IvanGoncharov
    If updating packages didn't help, please open issue in api-spec-converter
    and attach spec that you trying to convert
    Nuba Princigalli
    @nuba
    @IvanGoncharov thank you
    Nuba Princigalli
    @nuba
    @IvanGoncharov ended up moving to a swagger 2.x api spec, so the conversion step became unnecessary. Thanks anyway!
    Mohsen Azimi
    @mohsen1
    Hey @IvanGoncharov I was out of loop for this. Are we doing version 1.0?
    Ivan Goncharov
    @IvanGoncharov
    HI
    yes it mostly documentation changes
    change examples and update README
    One thing that I wanted to do in that scope
    is to make node module in form object containing convert function
    so require('swagger-converter') => require('swagger-converter').convert
    because in future I want to add function that resolve sub-resources
    Ivan Goncharov
    @IvanGoncharov
    function that return {'/pet.json': 'http://test.com/swagger/pet.json', '/store.json': 'http://test.com/swagger/user.json'}
    In any case 1.0.0 will brake API so I think it's good idea to push all breaking changes in it
    @mohsen1 What do you think?
    Ivan Goncharov
    @IvanGoncharov
    @mohsen1 What do you think?
    Mohsen Azimi
    @mohsen1
    I'm okay with those API changes @IvanGoncharov Lets do it! :)
    Jose Galisteo
    @ceritium
    hello! hello!
    Jose Galisteo
    @ceritium
    what about support explicit tags from 1.2 to 2.0?
    1.2 do not support tags but for migrations is useful
    Ivan Goncharov
    @IvanGoncharov
    Hi @mohsen1
    I think about doing new realease
    1.2.0
    What do you think?
    aarontai1607
    @aarontai1607
    hi
    protoc-gen-swagger to generate openapiv3 instead of swagger2