These are chat archives for arenanet/api-cdi

26th
Apr 2016
smiley
@codemasher
Apr 26 2016 00:00
but i still don't know what to think of promises
hey and I was digging through my backlog for things to do
let's fix promises
@codemasher they're really nice when you chain them like the above
Pat Cavit
@tivac
Apr 26 2016 00:00
Promises and I are cool, right until they eat my errors
then I want to launch them into the sun
Nabrok
@Nabrok
Apr 26 2016 00:00
Is characters api still down?
smiley
@codemasher
Apr 26 2016 00:00
well, it's just like moving the callback hell
Pat Cavit
@tivac
Apr 26 2016 00:01
@Nabrok yes
Think @lye had a lead on the fix, dunno timeframe though
I mean Promise.all is basically the same as async.waterfall
Pat Cavit
@tivac
Apr 26 2016 00:01
Promise.all is the same as async.map
async.waterfall passes results between steps
Promise.all is a mad scramble to complete
oh huh, okay, that's good to know
so basically chaining is the only built-in syntax. works for me.
Pat Cavit
@tivac
Apr 26 2016 00:03
function sequence(promises) {
    return new Promise(function(resolve, reject) {
        promises.reduce(function(curr, next) {
            return curr.then(next);
        }, Promise.resolve()).then(resolve, reject);
    });
}
does what you're thinking of (and looks insane)
Eearslya Sleiarion
@Eearslya
Apr 26 2016 00:04
Oh god I just realized the way I'm rendering skill icons just keeps adding classes
never removes them
Pat Cavit
@tivac
Apr 26 2016 00:04
.classList to the rescue
oh yeah that does look pretty gnarly
here I cleaned it up a bit
function sequence(promises) {
    return new Promise((resolve, reject) =>
        promises
            .reduce((curr, next) => curr.then(next), Promise.resolve())
            .then(resolve, reject)
    );
}
there was my first fetch experiment
almost a year ago
Eearslya Sleiarion
@Eearslya
Apr 26 2016 00:06
I think about 75% of what I have written so far needs to be scrapped
David Reeß
@queicherius
Apr 26 2016 00:07

I think about 75% 99% of what I have written so far needs to be scrapped

Every software project ever

Eearslya Sleiarion
@Eearslya
Apr 26 2016 00:08
Okay I cleaned up the skill rendering at least
Eearslya Sleiarion
@Eearslya
Apr 26 2016 00:16
http://build.sleiarion.net/ (ignoring the fact that utility skills are not unique)
windwarrior
@windwarrior
Apr 26 2016 00:18
engineer needs toolbelts!
Eearslya Sleiarion
@Eearslya
Apr 26 2016 00:19
...Huh.
That's an interesting side effect I never noticed.
@lye Every class is currently missing a heal skill..specifically, the heal skill that brand new characters start out with. Since that skill is never trained for..
oof
anyway I just posted on the forums that the current plan for /v2/characters is to hopefully get it hotfixed tomorrow evening
figured I'd post it in here too
@Nabrok ^ since you were asking <3
Nabrok
@Nabrok
Apr 26 2016 00:33
thanks!
Archomeda
@Archomeda
Apr 26 2016 00:42
Cool! I can't live without gw2efficiency anymore for searching my items across characters :>
David Reeß
@queicherius
Apr 26 2016 01:14
@lye yay! <3 :sparkles:
David Reeß
@queicherius
Apr 26 2016 01:19
@Archomeda accoding to my email inbox you are not the only one. I also learned by that that apparently big red warnings do absolutely nothing.
Nabrok
@Nabrok
Apr 26 2016 01:20
People don't read things
Reading is overrated. I prefer emoji :no_entry:
I too need gw2efficiency back in my life
Eearslya Sleiarion
@Eearslya
Apr 26 2016 03:01
@lye You should email @queicherius to ask when the characters will be back
David Reeß
@queicherius
Apr 26 2016 03:32
@Eearslya :angry:
Archomeda
@Archomeda
Apr 26 2016 03:32
Hahaha, nah, you should email him about putting a warning up on the webs- oh wait
David Reeß
@queicherius
Apr 26 2016 03:33
@Archomeda No joke, I got a mail for that already
Archomeda
@Archomeda
Apr 26 2016 03:33
Omg really? :worried:
Maybe next time take down the page and put a big giant red warning on that page instead
But I'm pretty sure that there will still be people emailing you...
David Reeß
@queicherius
Apr 26 2016 03:34
Same! :D
I mean, I think its more on the funny side of things. And I just copy/paste a premade response, so it's not like it takes a lot of time
Archomeda
@Archomeda
Apr 26 2016 03:38
automate it
if (email_body.contains("Y MY CHARACTER NO WORK?!")) { reply("Yes we are aware of it, but the API is currently down..."); }
pretty sure that covers at least one mail :3
David Reeß
@queicherius
Apr 26 2016 03:40
:D
Archomeda
@Archomeda
Apr 26 2016 03:41
Although at this point I think I would actually never want to have an email inbox anyway, just go with an issue tracker.
That will at least filter those people out :D
Since they probably don't know how an issue tracker works either :D
David Reeß
@queicherius
Apr 26 2016 03:41
I use different templates for german/english emails tho, so I think making that reliable would be more work than just copy/pasting the right thing. :D
Archomeda
@Archomeda
Apr 26 2016 03:42
Ouch, localization :P
David Reeß
@queicherius
Apr 26 2016 03:43
Eh, having an email inbox is needed. At least for personal issues with private API keys / password resets / forgotten email and shit like that
Archomeda
@Archomeda
Apr 26 2016 03:43
Ahh, that makes sense yes
David Reeß
@queicherius
Apr 26 2016 03:43
As long as it's not too many emails, it's alright
Archomeda
@Archomeda
Apr 26 2016 03:43
I still wish that GitHub will support PMs at some point...
David Reeß
@queicherius
Apr 26 2016 03:43
My university sends me about 40 emails per day, so there is that
PMs would be neat. I am just glad gitter is a thing. I Iike this chat (and all the people in it <3).
Archomeda
@Archomeda
Apr 26 2016 03:57
A small thing I just noticed on gw2efficiency: if you browse to a different page it apparently doesn't abort the previous request. Meaning that if I go from account overview to account wallet, it will show my wallet; but after a second or two it will display the 503 error atm because of the API that's down.
The reason how I just noticed that, is ironically because the bug #274. @lye, how's progress on that? The API still says 1028 gems for my account while I have 400-something.
David Reeß
@queicherius
Apr 26 2016 04:09
Yeah, that's somewhere on the long list of stuff that's not neat but kind-of-works atm. >_>
Archomeda
@Archomeda
Apr 26 2016 04:10
:D
You're not the only one. It happens in the ingame TP as well :P
I get that every time when I search with the "I am Evon Gnashblade"-mode
Aralicia
@Aralicia
Apr 26 2016 06:56
Reacting on the previous talk about ES2015 : sadly, browser compatibility is a big issue for now. While Edge is doing good (last version as 79% ES6 support), IE 11 is... severly lacking. And the current Safari version is still lacking many fonctionnalities. For example, lye's code wouldn't work on any of them because neither support arrow functions. And since IE & Safari combined usage is still around 15% worlwide usage... well you can't really count on all of that for websites aimed at a wide public. For things like a gw2 app ? Sure, you can say that you only support FF & Chrome. But for a company website ? hell no.
darthmaim
@darthmaim
Apr 26 2016 11:34
(/v1/event_names.json is disabled for today)
:point_up: April 19, 2016 7:29 PM
did you fix this?
smiley
@codemasher
Apr 26 2016 11:52
@Aralicia polyfills ftw!
codemasher @codemasher coughs
Aralicia
@Aralicia
Apr 26 2016 12:29
@codemasher sure, but still, sadly, hard to have such things automatically integrated in new projects. Or maybe it's because my company has too much inertia.
Seriously, it was hard enough to ensure that every new project is on git :s
smiley
@codemasher
Apr 26 2016 12:30
general problem: people.
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:22
alright all up to date, god you guys talk to much while I sleep
got VG down with my guild for the first time last night! Yay US
Nabrok
@Nabrok
Apr 26 2016 13:22
gratz!
windwarrior
@windwarrior
Apr 26 2016 13:41
gratz!
I killed VG/Gors/Sabetha (eternally)/Sloth/Trio yday
Nabrok
@Nabrok
Apr 26 2016 13:42
How did you do on Gorseval?
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:43

hmm we went to him, tried 3 times, we had one that had done it before, but it was new to the rest of us.

We will try him again tonight

windwarrior
@windwarrior
Apr 26 2016 13:43
gors is not a hard fight
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:43
nah, from what we've seen, it's more of a pure dps fight than anything else
windwarrior
@windwarrior
Apr 26 2016 13:43
just a ridiculous DPS check
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:43
yeah
Nabrok
@Nabrok
Apr 26 2016 13:43
That's one thing that annoys me a bit about raids ...
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:44
so for VG I was healer with zealot/cleric
Nabrok
@Nabrok
Apr 26 2016 13:44
When they were being announced a big point was that you'd need different armor sets, berserker wouldn't cut it ...
then everything is a dps check
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:44
should i remove cleric to get zerker
or should I mainly heal?
windwarrior
@windwarrior
Apr 26 2016 13:44
just bezerker wont cut it
there are roles in raids
Nabrok
@Nabrok
Apr 26 2016 13:44
Yeah, you do need a few people with other sets
But still, most are zerker
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:44
^^ yeah
so for VG,
I was the healer in zealot/cleric
3 condi with condi sets
the rest was zerker
windwarrior
@windwarrior
Apr 26 2016 13:45
I think berserker is the biggest compliment to Guild Wars 2 combat system
Aralicia
@Aralicia
Apr 26 2016 13:46
tbh, I don't think that full-offensive or full-defensive statset should exist.
windwarrior
@windwarrior
Apr 26 2016 13:46
No damage is unavoidable, bosses don't randomly kill you and if you really want you can avoid most of the damage
Nabrok
@Nabrok
Apr 26 2016 13:46
In most other content, if you don't take zerker all you're doing is slowing yourself down. You can still do everything, it just takes longer. In raids though if you don't have the dps you're done.
windwarrior
@windwarrior
Apr 26 2016 13:46
makes that you are in control of the fights
and not the other way around
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:48
you know what they need to fix? The Dredge fractls
fractals
windwarrior
@windwarrior
Apr 26 2016 13:48
they did years ago
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:48
when you're interacting with the device to unlock the door
windwarrior
@windwarrior
Apr 26 2016 13:48
it was even worse
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:48
yeah I remember back then
Nabrok
@Nabrok
Apr 26 2016 13:48
I remember all the weird jumping puzzles people came up with to skip that
Half the time they took longer than just doing it properly
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:48
like you should be able to pull dredge aggro
Nabrok
@Nabrok
Apr 26 2016 13:49
Remember when they did that fractal update a year or two back, and they had an achievement to complete each fractal? I tried every single day ... didn't draw Dredge once. I was the only one in the group hoping for it.
Edgar Doiron
@Coffee4cr
Apr 26 2016 13:51
lol
cliffside changes thouhg
wow
It was my favorite before, but it was long. Now it's in line with the rest
and feels amazing
Nabrok
@Nabrok
Apr 26 2016 13:54
I still haven't tried it. Not had a chance to do fractals since the patch.
idivait
@idivait
Apr 26 2016 14:20
@queicherius Just spent way too much time doing this lol: http://puu.sh/owpMc/ad438446c3.png
windwarrior
@windwarrior
Apr 26 2016 14:21
mayday is a single word
darthmaim
@darthmaim
Apr 26 2016 14:21
Or wait 5 days
windwarrior
@windwarrior
Apr 26 2016 14:22
I am trying to create an ember app
but javascript got complicated somewhere
Wow, that embed was large.
Aralicia
@Aralicia
Apr 26 2016 14:29
Well, that way people may see the message.
windwarrior
@windwarrior
Apr 26 2016 14:30
just shutdown the site
Aralicia
@Aralicia
Apr 26 2016 14:30
@windwarrior Nah, he would recieve mail because the site is down.
idivait
@idivait
Apr 26 2016 14:32
lol
Archomeda
@Archomeda
Apr 26 2016 14:33
Just to be sure, you'll need to confirm that message 3 times before you can even remotely use gw2efficiency :smile:
Edgar Doiron
@Coffee4cr
Apr 26 2016 14:33
lol
Archomeda
@Archomeda
Apr 26 2016 14:34
And if the button was clicked within 5 seconds of the page loading, show another warning about "You didn't read what was mentioned, am I right?"
windwarrior
@windwarrior
Apr 26 2016 14:35
just let the user retype the message
and don't allow c/p
Archomeda
@Archomeda
Apr 26 2016 14:35
hahaha :D
idivait
@idivait
Apr 26 2016 14:35
Ala deleting gem store items?
:D
windwarrior
@windwarrior
Apr 26 2016 14:35
so I created an ember app today
Archomeda
@Archomeda
Apr 26 2016 14:35
Or pact crowbars... for some odd reason
windwarrior
@windwarrior
Apr 26 2016 14:36
this is an accomplishment apparantly
I want AP now
idivait
@idivait
Apr 26 2016 14:37
I mean, what kind of joyless person deletes a Box o' Fun, anyhow?
Edgar Doiron
@Coffee4cr
Apr 26 2016 14:37
it's quicker to double click it
:P
idivait
@idivait
Apr 26 2016 14:47
And yet every time, I forget.
windwarrior
@windwarrior
Apr 26 2016 14:48
I hoard them :x
David Reeß
@queicherius
Apr 26 2016 14:49
@idivait Next time something like this happens, I will definitely go that path. But then people will just click the button and still wonder why it's broken. :D
@Archomeda the 5 second wait is a good idea for that. :P
idivait
@idivait
Apr 26 2016 14:50
I'm certain it'll never happen again. :D
windwarrior
@windwarrior
Apr 26 2016 14:51
@queicherius : maybe it doesnt help that your error message is quite generic
smiley
@codemasher
Apr 26 2016 14:51
windwarrior
@windwarrior
Apr 26 2016 14:52
https://gw2efficiency.com/account/characters just shows that the API broke, but it should say that the {{ api_name }} returned {{ api_error }}
David Reeß
@queicherius
Apr 26 2016 14:52
@windwarrior Yeah, I just expected people to read the giant red thing at the top of the page.
windwarrior
@windwarrior
Apr 26 2016 14:52
yeah but iff you miss it
then it just shows a generic sad quaggan
David Reeß
@queicherius
Apr 26 2016 14:53
Yeah. Next time. :D
windwarrior
@windwarrior
Apr 26 2016 14:53
users are stupid
:D
idivait
@idivait
Apr 26 2016 14:54
Yep... Every time I link a guildie to this: http://gw2mathhammer.com/slack.html
"How do I get an API key?"
headdesk
David Reeß
@queicherius
Apr 26 2016 14:56
@idivait But how do you get an API key?
Aralicia
@Aralicia
Apr 26 2016 14:56
Reply : "Ask the ANet support" :p
idivait
@idivait
Apr 26 2016 14:56
loool
windwarrior
@windwarrior
Apr 26 2016 14:59
Running without elevated rights. Running Ember CLI "as Administrator" increases performance significantly.
why would I ever run a webserver with elevated rights
Aralicia
@Aralicia
Apr 26 2016 14:59
Urgh.
windwarrior
@windwarrior
Apr 26 2016 15:00
that is a stupid recommendation
Aralicia
@Aralicia
Apr 26 2016 15:01
More seriously, I can't really see a better place for the keys to be. They are already in the account section, so no really better place. Now, if you want to help your users, you should add to your own site a quick guide. It's not as if it would be long to write.
Eearslya Sleiarion
@Eearslya
Apr 26 2016 15:10
Aralicia
@Aralicia
Apr 26 2016 15:10
Better :)
that said, the "you should" wasn't aimed at @idivait, but generally to the app devs
Eearslya Sleiarion
@Eearslya
Apr 26 2016 15:11

That was more in response to

Yep... Every time I link a guildie to this: http://gw2mathhammer.com/slack.html
"How do I get an API key?"

Christian
@zeeZ
Apr 26 2016 15:35
Just scrolling through and want to say I got the future pun @tivac :P
Promise.
Pat Cavit
@tivac
Apr 26 2016 16:22
:+1:
@Archomeda: re: account gems. I'll have to check on where that patch is; might be on live now, not sure.
@darthmaim, uhh, hmm. That fix might be integrated to live by now too; not sure.
windwarrior
@windwarrior
Apr 26 2016 19:15
api on :fire:?
never mind
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:19
@lye Hate to keep putting things on your plate, but.. bundle skills seem to be somewhat broken. /v2/skills?ids=all has only 2 occurences of "bundle_skills". Things like Bomb Kit, Grenade Kit, Tool Kit.. elemental weapons..all missing.
There might already be an open issue for that
there's a whole host of things wrong with /v2/skills right now it's kinda terrible
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:19
Oh, lemme double check
Closest thing is this: arenanet/api-cdi#254
Bundle skills and transform skills work in roughly the same way -- there's a hardcoded list
It's probably out of date
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:20
Got it
so much work to do orz
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:22
I don't envy you, sheesh
arena.net/#careers -- you get a red tag on your name and stuff man
and like a salary but whatever
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:27
4+ years of professional programming experience (not necessarily in the game industry)
lolnope
Archomeda
@Archomeda
Apr 26 2016 22:27
also a free flight to the USA? ;)
i actually don't know if we can sponsor visas but it doesn't hurt to try
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:28

Strong JavaScript skills

also lolnope

You've seen my JS
Archomeda
@Archomeda
Apr 26 2016 22:28
great when universities teach you java instead
and not even c++
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:29
C++ was actually my second language
Archomeda
@Archomeda
Apr 26 2016 22:29
oh, and don't forget a course that teaches you how to scala in javascript...
I need to learn Scala at some point.
Pat Cavit
@tivac
Apr 26 2016 22:30
We can sponsor visas, it's just a hugely involved process so you'd better really want it
Archomeda
@Archomeda
Apr 26 2016 22:30
i was half joking btw :) but that's nice to know
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:30
If you guys actually had the API code on github I could probably help, but I'm horribly underqualified to get paid for it
Pat Cavit
@tivac
Apr 26 2016 22:31
We could probably put the JS that fronts the API up, but all the C++ code would get lye and I so :fire:d
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:31
Just share it with me, I won't tell :shipit:
Archomeda
@Archomeda
Apr 26 2016 22:34
that actually sounds cool, but will it be useful for us to contribute then?
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:34
That's the only problem; I can imagine only having the JS isn't as useful since a lot of backend support is needed
Pat Cavit
@tivac
Apr 26 2016 22:36
yeah the JS stuff is more or less settled at this point, lighting up new endpoints is mostly a C++ task now
it's why I'm not able to contribute as much as I'd like :-\
Eearslya Sleiarion
@Eearslya
Apr 26 2016 22:36
@lye does most of the C++ then?
Pat Cavit
@tivac
Apr 26 2016 22:39
Out of the two of us, he writes all of it
some is actually done by the server programming team, but he does most of it from an API perspective
Archomeda
@Archomeda
Apr 26 2016 23:21
@lye, when is the character api fix being pushed out? in 10 minutes?
not a clue, a bit after whenever the next hotfix goes out
okay I just got the email
windwarrior
@windwarrior
Apr 26 2016 23:24
scala feels... poor man haskell
haskell for the faint hearted
@Archomeda yeah figure like 10-15 minutes
windwarrior
@windwarrior
Apr 26 2016 23:26
nice, gj!
Archomeda
@Archomeda
Apr 26 2016 23:28
yeah, figured as 8 minutes ago there was the ingame announcement :P
and you mentioned next hotfix
yeah
I honestly didn't plan to be able to get in for a hotfix, but it made it through
windwarrior
@windwarrior
Apr 26 2016 23:30
the worst that can happen is that the character api still stays broken right?
man my unit tests are not happy at all
Archomeda
@Archomeda
Apr 26 2016 23:32
xD
windwarrior
@windwarrior
Apr 26 2016 23:36
a parser for Javascript must look horrible, since ES6 funcName() {} is a shorthand for funcName: function () {}, how does that not clash with normal function calls : '(
context sensitivity
windwarrior
@windwarrior
Apr 26 2016 23:38
I was seriously confused by that code btw, I was li ke, why are you calling a function here
there's a lot of weird new syntax for object literals in ES2015
computed property names really threw me for a loop
anyway, made the config switch; it should be turning back on soon
Pat Cavit
@tivac
Apr 26 2016 23:41
yeah those were fun to try out
{
    [omg + what] : "is-happening"
}
windwarrior
@windwarrior
Apr 26 2016 23:42
not sure whether I think that is fancy, or horrible
nothing you can do about it now, it's standardized
windwarrior
@windwarrior
Apr 26 2016 23:45
great!
Archomeda
@Archomeda
Apr 26 2016 23:46
calling @queicherius
eh the red text is only advisory
it's still making API requests, they're just working now
windwarrior
@windwarrior
Apr 26 2016 23:49
efficiency works great again
and I still didnt put my staff back on my rev apparantly