These are chat archives for arenanet/api-cdi

6th
Dec 2016
:fire:
 * /v2 - add auth flags to enumerated endpoints.
 * (not live) /v2/adventures/:id/leaderboards, /v2/pvp/seasons/:id/leaderboards - adjust output format to make more sense.
 * /v2/professions - forward an unhandled error properly.
 * /v2/characters/:id/backstory - remove legacy bits.
 * /v2/account - add guild_leader field.
 * (not live) /v2/wvw/matches - add points_tick, points_capture, yaks_delivered and upgrades fields to objective objects.
windwarrior
@windwarrior
Dec 06 2016 01:20
I like how some words get syntax highlighted
hmm didn't realize gitter had a cutoff for editing messages; i was gonna make that a text blob
not to error
David Reeß
@queicherius
Dec 06 2016 01:49

* /v2/account - add guild_leader field.

<3

@lye Btw out of interest, why does the guild api return a 400 error when you are not a guild leader instead of a 403? It's not really a bad request, just not the right permissions. [Just interested, I wouldnt change it, who knows what that breaks]
Eearslya Sleiarion
@Eearslya
Dec 06 2016 05:50
Day   Rank  Score   Rank  Score
  6    721      0    699      0
I spent way too long debugging a solution that was working perfectly
Pat Cavit
@tivac
Dec 06 2016 09:02
@queicherius likely because it goes through the standard error-handling code
which probably only returns a 200, 400, or 500 because we're lazy programmers
Michael Dougall
@madou
Dec 06 2016 09:48
if you ever do want to fix up some api error handling, fix up the token one first so it doesn't return 403/400's when it shouldn't :)
smiley
@codemasher
Dec 06 2016 13:16
blob
403 != 404
darthmaim
@darthmaim
Dec 06 2016 13:18
why do we waste so much time on discussing http status code in here :/
!= 2xx => error
smiley
@codemasher
Dec 06 2016 13:18
what?
"so much time" vs. "because we're lazy programmers"
...
@queicherius hmm
            if(thisMember.rank !== data.guild_leader_rank.name) {
                return reply.error({ reason : "access restricted to guild leaders" });
            }
I can make that a 403
I was just lazy when I wrote the code
windwarrior
@windwarrior
Dec 06 2016 17:36
programmers are lazy by design right, we write code so that we dont have to do annoying repetitive tasks by hand ever again
that's such a pipe dream
windwarrior
@windwarrior
Dec 06 2016 17:38
hehe perhaps
(everyone saw that)
Pat Cavit
@tivac
Dec 06 2016 18:30
@codemasher tiles.guildwars2.com is a cloudfront endpoint
I've got no simple control over that one
smiley
@codemasher
Dec 06 2016 18:30
ah
Pat Cavit
@tivac
Dec 06 2016 18:31
S3 bucket returns a 403 not authorized for non-existant files
Eearslya Sleiarion
@Eearslya
Dec 06 2016 18:31
That's just..silly.
Pat Cavit
@tivac
Dec 06 2016 18:31
Not really
telling someone w/o access that a file doesn't exist is technically an information disclosure leak
Looks like I can fix it w/ a change to the bucket policy
smiley
@codemasher
Dec 06 2016 18:32
but a 403 tells that there is something
Eearslya Sleiarion
@Eearslya
Dec 06 2016 18:32
But does S3 actually have permissions? How do you put permissions on a web-accessible file other than IPs?
Pat Cavit
@tivac
Dec 06 2016 18:32
Everyone can read, but since public doesn't have list perms you get a 403 instead of a 404
a 403 tells you that you don't have access
smiley
@codemasher
Dec 06 2016 18:32
yea
Pat Cavit
@tivac
Dec 06 2016 18:32
it doesn't say anything about whether or not the resource exists
@tivac if you change it can you add that step to the "regenerating map tiles" wiki page
because I'll forget otherwise when I create a new bucket
Eearslya Sleiarion
@Eearslya
Dec 06 2016 18:33
But my question is, what scenario would there be where the file DOES exist, but still returns a 403?
Pat Cavit
@tivac
Dec 06 2016 18:33
you don't have access
Eearslya Sleiarion
@Eearslya
Dec 06 2016 18:33
Based on what policies?
the bucket policies :>
Pat Cavit
@tivac
Dec 06 2016 18:33
the S3 bucket policies
that control who has access
Eearslya Sleiarion
@Eearslya
Dec 06 2016 18:34
But how are people identified as someone with access?
Pat Cavit
@tivac
Dec 06 2016 18:34
Your AWS account?
Or a pre-signed URL
@Eearslya it's very uncommon but people do use it for things
Pat Cavit
@tivac
Dec 06 2016 18:44
anybody got a valid tiles.guildwars2.com link handy?
Pat Cavit
@tivac
Dec 06 2016 18:45
thanks, looks like I didn't take down the world just yet
:<
Pat Cavit
@tivac
Dec 06 2016 18:47
(or the CDN cache is covering up that I blew up the world
blob
fixed
smiley
@codemasher
Dec 06 2016 18:53
blob
thank you @tivac <3
(don't ask why i get so many tile errors... spoiler: google.maps.Projection)
Pat Cavit
@tivac
Dec 06 2016 18:54
lol
Our internal docs for releasing new tiles are updated, so in theory @lye will remember to apply these settings to the bucket in the future
smiley
@codemasher
Dec 06 2016 18:55
yay :D
David Reeß
@queicherius
Dec 06 2016 20:05
@darthmaim Eh, I just noticed because I was ignoring some errors (e.g. loading guilds). Not a big deal, was just curious :D
Edgar Doiron
@Coffee4cr
Dec 06 2016 20:14
@lye is the pvp endpoint ready for the changes next week?
with the new season and new way everything works?
@Coffee4cr no not yet
the pvp team has all the backend bits in-place so it's really easy for me to implement, thankfully
just need to spend a couple of hours plumbing through the last mile
will probably have a pull request detailing the changes to /v2/pvp/standings (and maybe /v2/pvp/games) later today
Edgar Doiron
@Coffee4cr
Dec 06 2016 20:50
cool
smiley
@codemasher
Dec 06 2016 22:09
the redesign of the google maps reference is just the worst
i hate it so much
how is one supposed to find anything in there except with CTRL+F?
Archomeda
@Archomeda
Dec 06 2016 22:12
oh my
that's a terrible doc page lol
wtf is wrong with just multiple pages instead of dumping it on 1 page?
David Reeß
@queicherius
Dec 06 2016 22:14
You now its bad when the navigation has a extra scrollbar lol
smiley
@codemasher
Dec 06 2016 22:14
well, it was one page before, but it was usable
Archomeda
@Archomeda
Dec 06 2016 22:14
even collapsing/expanding things would be good if they insist on having it on 1 page
smiley
@codemasher
Dec 06 2016 22:15
the layout of the php docs are still my favourite
followed by the prototype API docs
Archomeda
@Archomeda
Dec 06 2016 22:15
i'm used to the .net docs
they are awesome
but haven't done anything .net related for more than a year now
plain & simple
Archomeda
@Archomeda
Dec 06 2016 22:15
i like mozilla too for javascript
smiley
@codemasher
Dec 06 2016 22:16
mozilla is ok, but the pages are messy
Archomeda
@Archomeda
Dec 06 2016 22:16
although they really have to update the compatibility with browsers
smiley
@codemasher
Dec 06 2016 22:16
(i'm talking just about the layout)
Archomeda
@Archomeda
Dec 06 2016 22:16
it's better than the first website result that keeps popping up when i search for something on google
w3schools
smiley
@codemasher
Dec 06 2016 22:17
ugh, yeah haha
Archomeda
@Archomeda
Dec 06 2016 22:17
i still don't know why w3schools is so popular that google places it first
smiley
@codemasher
Dec 06 2016 22:17
"SEO"
Archomeda
@Archomeda
Dec 06 2016 22:18
anyhow, despite that the .net docs are great... the c++ docs from microsoft aren't that good
smiley
@codemasher
Dec 06 2016 22:18
no really, they should be removed from the catalog like some other fake result sites
Archomeda
@Archomeda
Dec 06 2016 22:18
i should read up the new pvp ranking system
just came home again
we did not get a patch right?
next tuesday
Archomeda
@Archomeda
Dec 06 2016 22:20
alright, so you moved the release to next week
i assume to let it line up better with the holidays
I dunno if/when/why they adjust release dates, tbh
takes awhile to get back into the loop since the release process is pretty long
Archomeda
@Archomeda
Dec 06 2016 22:21
last one was 21 november
with a small bug fix patch on 28 or 29
the general 2 week release schedule has had some weird dates this year actually, there were a lot of skipped weeks
not that i mind, as long as it works for you guys :)
Archomeda @Archomeda drools over the revamped pvp ui
Archomeda
@Archomeda
Dec 06 2016 22:32
it looks amazing
but i'm assuming that the icons of those ascended shards of glory are placeholders :D
they look the same as the magnetite shards
:shrug:
not sure when the video was made but seems kind of late for art assets? not really sure what that process looks like
Archomeda
@Archomeda
Dec 06 2016 22:36
well... the localizations aren't in this video either
so i think it's at least a couple weeks old?
windwarrior
@windwarrior
Dec 06 2016 23:32
I just dont like nameplate tags :O
Archomeda
@Archomeda
Dec 06 2016 23:33
what? those in wvw?
windwarrior
@windwarrior
Dec 06 2016 23:33
I end up playing a few matches of PvP and then I am stuck with an amber or emerald tag for 3 months
Archomeda
@Archomeda
Dec 06 2016 23:33
wait
you mean the pvp badges...
what am i thinking
from what i saw in the UI, you can disable it
windwarrior
@windwarrior
Dec 06 2016 23:33
I am a very casual pvp'er
Archomeda
@Archomeda
Dec 06 2016 23:33
it was a much requested feature afaik
windwarrior
@windwarrior
Dec 06 2016 23:36
nice :D now I can do my max 10 matches a month in ranked :D
David Reeß
@queicherius
Dec 06 2016 23:39
@Coffee4cr Thanks for recommending Kingdom Death: Monsters. It's super fun. <3 Already started with doing Excel tables for weapon efficiency (which is the point I know I like a game)
smiley
@codemasher
Dec 06 2016 23:39
cool, now that i got the projection working in gmaps, i still need to unproject the ingame coordinates <.<
blob
Y U MAEK IT SO HARD GOOGLE
last time i used geojson w/gmaps it wasn't that messy