so.... really looking at mysql for the first time... that looks like a terribly annoying way to store information from the API. I guess that's why no on recommended it :/
I'm storing my data in postgres (which, uses almost exactly the same syntax, really.)
hum then I must be missing something, will keep looking
oh... for one there's a json data type which I hadn't noticed
that already changes things greatly
well, putting a database in a database is a bit unadvisable
I think @lye once made a fully normalised database scheme of 50+ tables
they should rather write a new client from scratch instead of doing crap like this...
lol
i do agree, steam is in need of a revamp
Am I the only one who totally hates the latest interface?
no
the latest interface? you mean the one that exists for years now? :P
the current one, is only like a year old at most
do you mean the store interface?
yep
i barely used it after they changed it
mostly because of all the trash that's shown there
yep
I just use the search now
you're right though, it's been more than 2 years
how time fly
thank you waybackmachine
i used to ignore the steam store most of the time but since the latest changes i've lost any interest to use it at all. i just go there for games i heard of somewhere else...
it's become something like amazon recommendations (which, in all fairness, are still worse than steam's)
steam still doesn't know what i like to play
it just tends to find games with similar tags to what i've played, but those games are shite
amazon still doesn't know what i like to buy
it tends to offer the same type of articles i just bought
see the similarities? :D
:P
me: just bought an expensive digital camera
amazon: here's a gazillion other digicams you probably want to buy
amazon: here's a gazillion other digicams you probably want to buy
i mean, who's even responsible for such shitty ideas?
marketing department
probably
it would be smarter if it would recommend accessories or additions to what you've bought
don't you think they realized how wrong they are? amazon hasn't changed much in like... 15 years? steam almost the same
i want to know a single customer who buys another digicam just because that recommendation popped up after they just bought one.
for steam it might be a little different. there might be someone who spends $0.99 on a budget game - either way, this is a sub-optimal way of advertising.
unrelated but this is the craziest thing humans have done so far https://twitter.com/CassiniSaturn/status/859902178642640896
what a time to be alive
I liked the philae saga too
trying to land a bot on an asteroid
:blue_book: today is my friday so who's ready for a live deploy :red_car:
:tada:
- /v2/wvw/stats/guild: impl.
- /v2/wvw/stats/team: impl.
- /v2/vendors: impl (needs backend support).
- /v2/achievements: add lifetime flag (needs backend support).
- /v2/pets: add .skills (needs backend support).
- /v2/professions: add thief stolen skills to .skills (needs backend support).
- /v2/characters: add .dyes to item stacks (needs backend support).
- /v2/pvp/heroes: add .unlock_items (needs backend support).
- /v2/skins: add dye_slots (needs backend support).
That's up now or going up today?
planning on turning on
/v2/wvw/stats/team today -- it doesn't have good data this week though
since backend bugs only got fixed on tuesday, this match's data is totally broken
will do
/v2/wvw/stats/guild probably next week so if I'm here to put out fires
impl
and
(needs backend support)
Archomeda @Archomeda cries
yeah... welcome to microservices where there's three different deployment schedules
did something actually get added between today and 19 april?
uhhhh
probably not
For NA tier 1 that would be
/v2/wvw/matches/stats/1-1/teams/green/top?
should be
that should return
["kills", "kdr"]
okay good, then i didn't miss anything the past weeks :D
ok, and then
/v2/wvw/matches/stats/1-1/teams/green/top/kdr
HMM this data doesn't look correct at all
this doesn't even look sorted what the hell
PLEASE BEAR WITH ME IN THESE TRYING TIMES
yay, new endpoint for scraping guild ids
results[team] = {
kills : entries
.sort((a, b) => a.kills - b.kills)
.slice(0, numTopResults),
wilson : entries
.sort((a, b) => a.wilson - b.wilson)
.slice(0, numTopResults)
};
i'm dumb as a rock
hmm maybe
Array.prototype.sort does what I want there; I thought it maybe returned the original array
Returns the sorted array, but don't you want b - a for descending?
uhh
confirmed dumb as a rock then
yeah that was it derp derp, I'll get that fixed up
anyway, this week's data for this is rotten -- I goofed and was tracking the wrong team values
so if you were on team blue, every kill would give +1 for blue, every death +1 death for blue, etc
rather than tracking who you killed/who killed you
anyway this is probably going to be more of a disaster than usual so horray
So kills would be ok, but kdr is off?
they're both off
the endpoint is set up to query from the perspective of a given team
such that
/v2/wvw/stats/1-1/teams/blue doesn't count kills/deaths caused to the blue team
like,
{
"deaths": {
"red": 12,
"blue": 34,
"green": 421
},
"kills": {
"red": 56,
"blue": 72,
"green": 1405
}
}Means that this guild was:
- Killed by the red team 12 times.
- Killed by the blue team 34 times.
- Killede by the green team 421 times.
- Killed someone on the red team 56 times.
- Killed someone on the blue team 72 times.
- Killed someone on the green team 1405 times.
So if you're looking at it from the blue team's perspective, it basically strips out the "killed by the blue team" and "killed someone on the blue team" for KDR considerations
in retrospect
this was a pretty dumb way to implement it
wait that data is per guild?
the new endpoint's data is, yeah
that's neat
well
hold off on judgements for now
because it's a piece of work at the moment
(1) current data is corrupt, (2) frontend needs at least one bugfix
hmm
I wonder if this endpoint is going to knock over something
the community e-peen contest
wuh-oh
actually that might be unrelated
(it's probably not unrelated)
Hmmm. Our Discord bot is having issues since the past 40 minutes or so
Socket timed out
Possibly related
I'm probably maxing out something
might be fixed in half an hour, need to fiddle this change through
:fire_engine: deploying fixes to live
:fire: something seems broken
I somehow broke
/v2/professions, not entirely sure how
:fire_engine:
:fire_engine: deployed fix for
/v2/professions
I'm gonna think about the KDR code and revisit it maybe after next week
I'm not really that happy with it ATM
moreover I'm slightly concerned that the implementation is wrong
like, awarding points to the wrong team or something
the numbers aren't looking anywhere close to right
so I'm pretty sure something is just botched
ahhh shame, I was just about to start writing my tracking code ;p
oh, I'm probably not going to change the API
just the implementation a bit
right now it tracks per-match per-guild
(and it tracks a tuple)
might change it to track a tuple per-match per-guild per-team
so that when you hit
/v2/wvw/matches/stats/1-1/teams/blue/top/kills the returned objects have {kills:{blue:0}, deaths:{blue:0}} because you can't kill or be killed (hopefully) by your own team
and your kills/deaths from the same guild on a different world would show up on the appropriate
/$team/
yeah that seems to make more sense, I think that's more what I was getting at with my comment on the PR, the fact you shouldn't be able to kill your own team
honestly
it would not surprise me if you were able to kill your own team
xD
given that the kdr endpoint only tracks kills where warscore is awarded, this may lead to a new meta
how do neutrals get handled?
(but at least it won't be the condi meta)
anything but the condi meta :(
NPC kills don't award warscore
or plague signet from nearby players? :P
like, if that gets you killed
ahh I think that's fair tho, it's better not tracking that anyway right, NPC's are decoration
the guild KDR stuff is only tracking last hit
ah, so condis don't count?
I'm actually not sure how that works
also do signet passives still work while you're downed?
I was under the impression they didn't, since the skill bar switched
don't think so
but people can still bleed out
hmm
I'm not sure about plague signet actually (and also save yourselves -- same dealy)
last hit huh, that seems like it should be fine for roaming guild groups, I guess rando blobs guilds could be getting points for whoever spams AOE
I would assume it would keep the original condi's owner
even blob guilds usually have a majority repping the same guild
so it should come out on average I think
like the pugblobs are whatever
so... necros put condis on themselves (or any class), and another necro kills himself with plague signet
how does that work out? :P
:tada:
you're asking questions that I have no interest in answering, unfortunately
haha
there are warscore floaters for points awarded on kill though
so I encourage you to grab some friends and find the bugs :>
(no API necessary)
can you imagine it would award points to your own team
which vendor sells friends? ;p
that would be so broken :P
hmm, the henchman vendor is dev-only isn't it
oh that sounds rad
@Archomeda there's probably some code in there that just awards to no one
i do hope so
that bump is changing the KDR cache mechanism from "once per DC" to "once per V8 instance (e.g. 32 per DC)"
hueeeeeeee
fail fast, agile, devops
I have worked in industry too long :(
actually it might not have been that
/shrug
¯\_(ツ)_/¯
You had one job lye !
;_;
:smile:
How much of your API code is tested
i don't know i'm not using any coverage tools
let's say like 30%
there's a lot of error paths that aren't tested
also some endpoints have such a complex output format that I haven't written tests for them because ughghghghgh
Future lye is not impressed
😜
past lye can die in a fire
i've seen his garbage
Hehe
its always sad to see that "carreers" involves a million years of experience
not just at anet