These are chat archives for arenanet/api-cdi

15th
May 2017
Michael Dougall
@madou
May 15 2017 01:15
:eyes:
Eearslya Sleiarion
@Eearslya
May 15 2017 17:41
@lye https://api.guildwars2.com/v2/wvw/matches/stats/1-2/guilds/ returns a 200 with nothing? o: (I know it's not a valid request but shouldn't it be a 400?)
huh, lemme take a look
Eearslya Sleiarion
@Eearslya
May 15 2017 17:41
Actually, wait, even with a guild ID it's blank
maybe it's totally bork
I actually don't recall why I didn't turn it on originally
maybe it was just broken when I tested it and needs a deploy or something
Eearslya Sleiarion
@Eearslya
May 15 2017 17:42
oh wait
Eearslya Sleiarion
@Eearslya
May 15 2017 17:42
the guild I was requesting isn't in that matchup
    (req, state) => {
        reply.json(state.stats.all[req.params.guild_id]);
    }
That should probably return an error if the guild_id has no data.
Eearslya Sleiarion
@Eearslya
May 15 2017 17:47
Also still seems to be only using 1 color for both kills and deaths, not sure if you had fixed that
I thought I had, but apparently not.
on my local server I'm seeing them logged out correctly
(and I checked the deployed code -- and it's th wait let me double-check it)
darthmaim
@darthmaim
May 15 2017 17:48

that should either be

    (req, state) =>
        reply.json(state.stats.all[req.params.guild_id]);

or

    (req, state) => {
        return reply.json(state.stats.all[req.params.guild_id]);
    }
(missing the return)
our eslint config doesn't complain
darthmaim
@darthmaim
May 15 2017 17:49
oh wait, reply.json() does the output stuff, its not what you return
but I added an if statement above it so it's moot
yeah
Yeah, the deployed code is what I'm running locally:
    CLogWvwKillTxn::LogDeath(
        GetParamValueInt(body, "MapId"),
        GetParamValueInt(body, "KillerShardId"), // team that did the killing
        GetParamValueGuid(body, "VictimCharGuid") // character (translated to guild) that got the killed
    );
Eearslya Sleiarion
@Eearslya
May 15 2017 17:51
got the killed
oh.
Yeah, LogDeath/LogKill have a bug
when resolving the character GUID to a guild, it overwrites the shardId passed in
I'll see if I can get a fix in the pipeline today
Michael Dougall
@madou
May 15 2017 20:13
Hey lye, sharable achievements are available. Improvements will come over time ;-)
yeah I saw your reddit post
looks pretty sweet :>
Michael Dougall
@madou
May 15 2017 20:30
Thx :-)
I really wanted the average colour haha, turned out to be really easy
Definitely the icing on the cake I think
(spoiler: the company is Cloudflare)
Darrian
@rikkuness
May 15 2017 21:27
which patch did the ecto gambler move?
windwarrior
@windwarrior
May 15 2017 21:32
the patch that conveniently added the ecto reward to black lion chests
I fell for it
lost 140g in 6 clicks
@codemasher what I kinda dislike about this article is how it has to be so extreme to get the point across. In no circumstances Cloudflare should give private information about anyone to anyone
unless they are legally required to
smiley
@codemasher
May 15 2017 21:36
ofc they shouldn't AT ALL
either way, CF died for me
Are there any elite specialization traits that affect non-elite spec skills?
Archomeda
@Archomeda
May 15 2017 22:34
possibly
skills.filter((s) => (s.traited_facts || []).some((f) => f.requires_trait && eliteTraits.indexOf(f.requires_trait) !== -1) && eliteSpecs.indexOf(s.specialization) === -1)
hmm
yep, there's 40 of 'em
ah probably less than that since /v2/skills.specialization doesn't appear to be live yet
windwarrior
@windwarrior
May 15 2017 23:14
wait wasnt there the thief trait that worked for engis
yeah there was a couple like that, but those are already culled
was looking for other edge cases
windwarrior
@windwarrior
May 15 2017 23:15
well my organic neural network seems to recall something like that ^^