These are chat archives for arenanet/api-cdi

7th
Feb 2018
windwarrior
@windwarrior
Feb 07 2018 10:19
NASA is a research institute that uses rockets as a transport system to space
SpaceX is a
Transport company
(Not a dramatic pause, gitter being mediocre on mobile)
smiley
@codemasher
Feb 07 2018 10:23
yea, right, getting to mars has absolutely nothing to do with science.
my point still stands
/shrug
Quaggan BooOOoot
@QuagganBooOOoot
Feb 07 2018 12:34
¯\_(ツ)_/¯
Eearslya Sleiarion
@Eearslya
Feb 07 2018 14:46
I remember when this chat used to be about the API
smiley
@codemasher
Feb 07 2018 14:56
you gotta get that on a shirt
Edgar Doiron
@Coffee4cr
Feb 07 2018 15:18
lol
Archomeda
@Archomeda
Feb 07 2018 15:33

@ChieftainAlex, someone mentioned somewhere that the table of available prefixes on https://wiki.guildwars2.com/wiki/Experimental_Envoy_Helmet is actually missing the PoF stats, which made me think about the API having those itemstats available and also how you're using the API in several widgets.

Do you think that something like this PoC fiddle would be worth it as a widget? https://jsfiddle.net/71ncqaLn/

I have actually no clue if multiplying the returned attribute value with 182, and then rounding it down, is actually stable or not
Also, I realized that the wiki is using jQuery 1.11.3, which is kinda outdated...
ChieftainAlex
@ChieftainAlex
Feb 07 2018 18:41
Honestly I don't think a widget call is the right thing to do that with
there's a couple of cases here: (i) with legendary armor it should always have every stat available - we have a parameter for that, (ii) for HoT/LWS3 ascended choice stuff it should be all of LWS3 - we haven't got anything to cater for that at the moment, (iii) for common stuff it's somewhere between everything and nothing
updating it is just tedious :<
windwarrior
@windwarrior
Feb 07 2018 18:44
but @Archomeda's code fetches based on the listed itemstats in the item definition
which is always consistent with that ingame (except for bugs obv)
also @Archomeda, 182 seems to only work for headgear
the API sadly doesnt expose any 'stat weight' does it
ChieftainAlex
@ChieftainAlex
Feb 07 2018 18:54
apart from the current item prices on the TP + dailies, I think very few wiki pages use api data directly
I wouldn't really want to have unnecessary uncached data retrieval on every page if I can avoid it
Archomeda
@Archomeda
Feb 07 2018 19:40
that's fair ^^
afaik the wiki uses the api for at least the tp, dailies, cats (on demand), and worlds
and it's sad that 182 only works for headgear, i forgot that every item has different scaling
Archomeda
@Archomeda
Feb 07 2018 19:49
also, it only works for ascended >_>
ChieftainAlex
@ChieftainAlex
Feb 07 2018 19:50
also prevents us from using SMW stuff for wiki lookups from other pages
I'm doing a query for all multiprefix items in the api and just reviewing them now
Archomeda
@Archomeda
Feb 07 2018 19:54
hmm, yeah it requires more changes than i initially thought :(
ChieftainAlex
@ChieftainAlex
Feb 07 2018 19:55
Any idea what prefix 1430 (e.g. from https://api.guildwars2.com/v2/items?ids=81462 ) is?
giver's + bringers (1436)?
but i do have that backpiece myself
lemme check ingame
ChieftainAlex
@ChieftainAlex
Feb 07 2018 19:57
I'm guessing it's just bringers with the built-in upgrade slot
and it hasn't been whitelisted
Archomeda
@Archomeda
Feb 07 2018 19:57
it probably is some weird stat introduced with recent stat changes
ChieftainAlex
@ChieftainAlex
Feb 07 2018 19:57
@lye / @apoch - could we please have (v2/itemstats) prefixes 1430 and 1436 whitelisted?
Archomeda
@Archomeda
Feb 07 2018 19:58
image.png
image.png
image.png
these are the selections on the ascension ingame
ChieftainAlex
@ChieftainAlex
Feb 07 2018 19:59
thanks for confirming
Archomeda
@Archomeda
Feb 07 2018 19:59
38 stats
ChieftainAlex
@ChieftainAlex
Feb 07 2018 19:59
yeah, trinkets are the next highest (36), with armor having 34
Archomeda
@Archomeda
Feb 07 2018 19:59
api also shows 38 stats, so yeah, something needs to be whitelisted
wait, there's that fiddle i created that enumerates them
wait... i just realized, since when are the stat selections ordered alphabetically ingame? O_O
ChieftainAlex
@ChieftainAlex
Feb 07 2018 20:02
since always
Archomeda
@Archomeda
Feb 07 2018 20:02
and yeah, bringer's and giver's are missing as you said
oh wait... clicking the left and right arrows are not going through them alphabetically
windwarrior
@windwarrior
Feb 07 2018 20:04
why is there even a whitelist on itemstats
quite convenient on mesmer, Berserker and Commander are high up in the alphabet
now we just need Viper renamed to Aviper
ChieftainAlex
@ChieftainAlex
Feb 07 2018 20:05
better use multiple AAA's to be sure
Archomeda
@Archomeda
Feb 07 2018 20:05
🙃
@ChieftainAlex 1430,1436 are whitelisted, should show up in a few minutes
ChieftainAlex
@ChieftainAlex
Feb 07 2018 20:14
cheers
Archomeda
@Archomeda
Feb 07 2018 20:17
:+1:
ChieftainAlex
@ChieftainAlex
Feb 07 2018 21:16
so many older versions of items in amongst the API -- trying to weed out the odd stat prefix selection groups
ChieftainAlex
@ChieftainAlex
Feb 07 2018 22:09
I wonder if it was intentional that the envoy t1/t2 and the PvP trinkets/hateful sworl were not given the bringer/giver options
otherwise my list of things to update would be: legendary and gen 2 precursors, plus raid assaulter/healer/defender/malicious items
windwarrior
@windwarrior
Feb 07 2018 22:50
When they update stat tables on ascended they reset I think?
So maybe that’s why they didn’t on precursor armor
Archomeda
@Archomeda
Feb 07 2018 23:47
the precursor armor did reset when PoF was released, so it's indeed possible that stats reset whenever they add new ones
and they might have forgotten to include bringer's and giver's for them, i dunno