These are chat archives for arenanet/api-cdi

21st
Mar 2018
smiley
@codemasher
Mar 21 2018 12:55
ohai, so many new anet-faces here!
also, i've been told by some people that they've been missing my occasional tweet posts
Daniel Snider
@dsnider-anet
Mar 21 2018 16:19
huh. so ES6's const is like java's final then
isn't there also Object.freeze(...) in ES6?
darthmaim
@darthmaim
Mar 21 2018 16:19
yes there is
but freeze != const
const a = {};
a.foo = 'bar'; // works
a = { foo: 'bar' }; // doesn't work

let b = { foo: 'bar' };
Object.freeze(b);
b.test = 123; // doesn't work
b = { test: 123 }; // works
freeze prevents the mutation of the object, const prevents changing the reference
(you can still change properties of const objects, but can't assign a new value to the variable)
smiley
@codemasher
Mar 21 2018 16:23
i've never dared to use JS const in any other way than i'd do in php... :D
(not guilty)
Daniel Snider
@dsnider-anet
Mar 21 2018 16:24
const u = {v: {}};
Object.freeze(u);
u.v.test = 123
// u is {v: {test: 123}}
yikes
darthmaim
@darthmaim
Mar 21 2018 16:24
freeze is not recursive
Daniel Snider
@dsnider-anet
Mar 21 2018 16:24
yeah
also, it's failing silently which is obnoxious
darthmaim
@darthmaim
Mar 21 2018 16:25
are you in strict mode?
it shouldn't fail silently
Daniel Snider
@dsnider-anet
Mar 21 2018 16:25
ah good point, I just had a console open

either silently or by throwing a TypeError exception (most commonly, but not exclusively, when in strict mode).

From MDN

darthmaim
@darthmaim
Mar 21 2018 16:27
VM266:1 Uncaught TypeError: Cannot add property test, object is not extensible
just tested it in strict mode
Daniel Snider
@dsnider-anet
Mar 21 2018 16:27
well, at least that's something
darthmaim
@darthmaim
Mar 21 2018 16:27
thats the error chrome is giving me
Daniel Snider
@dsnider-anet
Mar 21 2018 16:29
"most commonly in strict mode" doesn't inspire confidence
darthmaim
@darthmaim
Mar 21 2018 16:30
does that mean the most common runtimes throw that error when in strictmode (but not all), or that the type error is most commonly thrown when in strict mode (but sometimes even when not in strict mode)
Daniel Snider
@dsnider-anet
Mar 21 2018 16:40

@windwarrior

sensible rendering of tooltips/skillbars

skills tooltip

Do you mean rendering each block in this list, or determining what goes in this list in the first place?
I assume you mean the former
darthmaim
@darthmaim
Mar 21 2018 16:41
thats all working already
I think
The only thing currently missing the stealthed tactical strike
smiley
@codemasher
Mar 21 2018 16:42
umm hey @dsnider-anet, may i ask cautiously about #61 and #62?
haven't touched map stuff in ages, but i'd really like to see some of these changes
oh, also #582, which includes/supercedes these
Daniel Snider
@dsnider-anet
Mar 21 2018 17:03
@codemasher I won't lie, I am not 100% familiar with everything in the api right now, and I haven't figured out where the priorities are yet. I'll have to give thorough read-through and grok the code behind it.
smiley
@codemasher
Mar 21 2018 17:04
no hurry :D
Daniel Snider
@dsnider-anet
Mar 21 2018 17:05
I actually thought fixing AED in #560 would be an easy first fix to dive into the api code, but it's a bit of a rabbit hole
smiley
@codemasher
Mar 21 2018 17:07
pretty much like i thought it'd be not too hard to backport the World of Padman gamecode into the current ioquake3 branch... rabbit holes everywhere
(turns out it'd be more viable to rewrite it piece by piece and clean it up in the process)
codemasher @codemasher laughs hysterically
Archomeda
@Archomeda
Mar 21 2018 17:17
map endpoints are something you might not want to look into at the beginning, if i have to believe lye
he was also struggling with it
@ChieftainAlex i do see a bunch of PoF maps showing up on my (really outdated) map viewer, do you remember what was wrong with it again?
(besides the part that the tiles are still outdated; i mean /v2/maps etc)
btw, do we have an issue for the outdated tiles already?
right, #589
Archomeda
@Archomeda
Mar 21 2018 17:43
then again, that seems to be just as hard :joy:
ChieftainAlex
@ChieftainAlex
Mar 21 2018 20:07
@Archomeda I think at one point all the map data was available on floor 0,1,2,3 for PoF
seems it might now be available on floor 49 only
(why 49? :( )
also default floor is "1" according to the top level information
(second one is broken)
Archomeda
@Archomeda
Mar 21 2018 21:34
right, that's something that i totally don't remember being that way
or was it... urgh i really don't know
Archomeda
@Archomeda
Mar 21 2018 21:40
#586
oh, you found it as well :joy: