These are chat archives for arenanet/api-cdi

11th
May 2018
Archomeda
@Archomeda
May 11 2018 01:00
Alright, updated my userscript for this gitter chat.
It should mark developers that have left the API scene, and also other ArenaNet people that came in at some point.
https://cdn.discordapp.com/attachments/278086929013014528/444301670055149578/unknown.png
David Reeß
@queicherius
May 11 2018 06:35
@darthmaim @Eearslya I think I picked those ids by random
@darthmaim That PR is super nice btw
Official schemas would be super sick, could also use them for the status page (atm they are approximations because I am lazy)
Archomeda
@Archomeda
May 11 2018 09:53
@darthmaim that output for the skills looks pretty nice actually
darthmaim
@darthmaim
May 11 2018 09:54
:)
Archomeda
@Archomeda
May 11 2018 11:05
going over the wvw endpoints, it seems that the stats for guilds and teams is broken
  /v2/wvw/matches/stats/:id/guilds/:guild_id
  /v2/wvw/matches/stats/:id/teams/:team/top/kdr
  /v2/wvw/matches/stats/:id/teams/:team/top/kills
wait, maybe only teams, i was stupid on guilds to not enter a guild id
btw, what was the actual output for these endpoints again? i remember them working at some point, but the code that hold it together was just quickly made i believe
@Eearslya do you remember it?
Werdes
@werdes
May 11 2018 11:12
iirc they never really worked except some small period of time. iirc they were "turned off" due to the values being not correct?
Archomeda
@Archomeda
May 11 2018 11:12
🤔
i honestly can't remember
i can only remember something along the lines that lye made this quickly after talking about the possibility with eearslya
so it being broken after a small period of time is not unlikely
But seems like lye fixed it 100 messages below that
Archomeda
@Archomeda
May 11 2018 11:42
(on an unrelated note: /v2/vendors: impl (needs backend support) a little bit up from that :cry:)
darthmaim
@darthmaim
May 11 2018 11:42
I think even that is done now
It's just not turned on
Archomeda
@Archomeda
May 11 2018 11:43
#235 and #507 (aonwy closed the first one)
darthmaim
@darthmaim
May 11 2018 11:45
Can we get that reopened @Aonwy ? Or a reason why that was closed?
Archomeda
@Archomeda
May 11 2018 12:18
image.png
so far i got this as a nav
some links are red because the wiki doesn't follow the same endpoint style everywhere
ChieftainAlex
@ChieftainAlex
May 11 2018 17:26
I feel like we should automate the nav but i guess we're not going to get any new endpoints anytime soon
Eearslya Sleiarion
@Eearslya
May 11 2018 17:29
Yeah, I would just link all of the character endpoints to API:2/character anyway, everything is just on that page
the only thing the sub-endpoints do is filter down the data
Archomeda
@Archomeda
May 11 2018 17:33
personally i like them divided, because that endpoint is pretty big for 1 page
Eearslya Sleiarion
@Eearslya
May 11 2018 17:34
well, it becomes a weird thing if it's separated, because if you request /v2/characters/Harbinger Tryssa it gives you all the data
so why would you not document all the data on that endpoint?
Archomeda
@Archomeda
May 11 2018 17:34
there's also the main "Characters" that's a link
Eearslya Sleiarion
@Eearslya
May 11 2018 17:35
Either we break it up so that people have to view multiple pages to get all of the documentation, or we repeat a lot of it
Archomeda
@Archomeda
May 11 2018 17:35
pretty sure that the wiki has some sort of include another page mechanic
ChieftainAlex
@ChieftainAlex
May 11 2018 17:35
{{:page title}}
hmm why are pages for example called "API:2/wvw/matches/stats:id/teams" instead of "API:2/wvw/matches/stats/:id/teams"?
Archomeda
@Archomeda
May 11 2018 17:37
and otherwise you link the subendpoints to the same characters page with a different heading each time
lol, probably a typo
ChieftainAlex
@ChieftainAlex
May 11 2018 17:38
well it might also be mediawiki page naming rules
ChieftainAlex
@ChieftainAlex
May 11 2018 17:39
moved it
Archomeda
@Archomeda
May 11 2018 17:40
anyway, i don't really mind if characters is split up or kept on the same page, but i do feel like it should be in the nav
ChieftainAlex
@ChieftainAlex
May 11 2018 17:41
we could just link to a section on the page instead of redlinks btw
[[page title#section]]
Archomeda
@Archomeda
May 11 2018 17:41
yeah, that's what i meant with the heading
forgot how they were called in mediawiki terms
ChieftainAlex
@ChieftainAlex
May 11 2018 17:41
lemme know if you want me to sprinkle that template at the end of all the api pages, might as well bot it, no point wasting human time
Archomeda
@Archomeda
May 11 2018 17:42
it's still on a local edit right now :P
ChieftainAlex
@ChieftainAlex
May 11 2018 17:42
always save your edits :P
Archomeda
@Archomeda
May 11 2018 17:42
meh, i copied it to a txt locally
i wish mediawiki syntax was easier
darthmaim
@darthmaim
May 11 2018 17:43
eh, that is still pretty simple stuff you are doing there
wait until you make some smw templates or so
Archomeda
@Archomeda
May 11 2018 17:44
lol no tnx
ChieftainAlex
@ChieftainAlex
May 11 2018 17:47
can confirm it gets easier.. 80000 edits later
Archomeda
@Archomeda
May 11 2018 17:47
hah
should i actually bother with v1?
ChieftainAlex
@ChieftainAlex
May 11 2018 17:48
nah
darthmaim
@darthmaim
May 11 2018 17:48
It's like writing regexp, when you know what you are doing it's pretty easy to write, but don't try to understand/edit it later
ChieftainAlex
@ChieftainAlex
May 11 2018 17:48
it might be worth including the v1/event_details and v1/maps bits
since those are the only bits without a v2 equivalent (srs anet)
I still get confused writing wikicode to do spawn timers and stuff :/
e.g. Zeghai
Archomeda
@Archomeda
May 11 2018 17:55
right, those ones
also, instead of explicitly linking to the subsections, we can use redirects instead as well right?
i'm not sure what's widely used on the wiki
Eearslya Sleiarion
@Eearslya
May 11 2018 17:57
@darthmaim About a week ago I looked back at a sorting program I wrote in x86 as a proof of concept. No comments. The hell was I thinking.
darthmaim
@darthmaim
May 11 2018 17:57
:D
Eearslya Sleiarion
@Eearslya
May 11 2018 17:57
Same concept; never understand it again later XD
ChieftainAlex
@ChieftainAlex
May 11 2018 17:58
yeah redirect would be fine, can redirect to a section
Archomeda
@Archomeda
May 11 2018 17:59
basically what i have in mind, is that it would be easier to see what's documented and what's not, if the wiki links reflect the api endpoint urls
i guess it also makes it easier to maintain
if they redirect you to the correct place
@Eearslya lol... were you drunk when you wrote it? (because no comments :P)
Eearslya Sleiarion
@Eearslya
May 11 2018 18:01
I had SOME comments. Like, my subroutines had documented parameters. But that was it.
All of the code inside the subroutines was just by itself.
ChieftainAlex
@ChieftainAlex
May 11 2018 18:16
I'm kinda tempted to create endpoint pages for inaccessible middleman endpoints like "2/guild"
Archomeda
@Archomeda
May 11 2018 18:16
seems reasonable in my opinion
pity i started thinking about a nav and ended up making an indented tree..
Archomeda
@Archomeda
May 11 2018 18:41
:')
ChieftainAlex
@ChieftainAlex
May 11 2018 18:42
I'm going to switch the https://wiki.guildwars2.com/wiki/API:2 page to use that style
do i need to present the inaccessible middleman pages differently or something?
looks like the order is random at the moment on that page..
Eearslya Sleiarion
@Eearslya
May 11 2018 19:10
Where does the (Inaccessible) part come from?
ChieftainAlex
@ChieftainAlex
May 11 2018 19:34
not sure how to phrase that, it's from a template that styles the result
Eearslya Sleiarion
@Eearslya
May 11 2018 19:54
Aha, got it.
ChieftainAlex
@ChieftainAlex
May 11 2018 20:59
obviously rephrase to anything that doesn't make the descendents look also inaccessible
question, is there a button on gw2efficiency to compare total AP vs everyone else? closest thing I can find is https://gw2efficiency.com/account/statistics/statistics.achievementCount
finishedAchievements looks a lot like a count of achievements instead of a count of AP
darthmaim
@darthmaim
May 11 2018 21:01
It's just a count
There is no statistic for AP
gw2efficiency/issues#835
Archomeda
@Archomeda
May 11 2018 21:10
and the total AP is often wrong