Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 30 2019 11:45
    Tolkyria commented #646
  • Jan 30 2019 11:44
    Tolkyria commented #646
  • Jan 16 2019 14:09
    patrickboesch starred arenanet/api-cdi
  • Jan 16 2019 03:23
    isand3r starred arenanet/api-cdi
  • Dec 09 2018 14:11
    queicherius commented #567
  • Dec 05 2018 16:57
    apoch closed #433
  • Dec 05 2018 16:57
    apoch commented #433
  • Dec 05 2018 16:53
    wafflebot[bot] unlabeled #527
  • Dec 05 2018 16:53

    apoch on master

    /v2/pvp/seasons: add .ranks. Merge pull request #535 from ar… (compare)

  • Dec 05 2018 16:53
    apoch closed #535
  • Dec 05 2018 16:53
    apoch closed #527
  • Dec 05 2018 16:45

    apoch on master

    add missing name tag to /v2/rac… Merge pull request #609 from Th… (compare)

  • Dec 05 2018 16:45
    apoch closed #609
  • Dec 04 2018 19:18
    darthmaim commented #640
  • Dec 04 2018 18:17
    apoch commented #640
  • Dec 04 2018 09:43
    darthmaim commented #640
  • Dec 03 2018 17:50
    Aonwy unlabeled #640
  • Dec 03 2018 17:49
    Aonwy closed #640
  • Dec 03 2018 17:47
    Aonwy labeled #645
  • Dec 01 2018 18:36
    strigefleur edited #645
darthmaim
@darthmaim
meh, changing the colors to look better on light background isn't bad
smiley
@codemasher
it's not for sure, but then again you know the usual nitpicking over there
so i wonder that this change even took place XD
Archomeda
@Archomeda
Another question, is there a nice API way of getting the food buff icon? Like the one that shows up in a consumable tooltip?
And I don't mean the actual food icon, but the food buff icon
darthmaim
@darthmaim
didn't @lye add this yesterday?
Archomeda
@Archomeda
Uhh

Oh..

/v2/items: add support for buff icons (when backend support lands).

darthmaim
@darthmaim
so there is your answer: soon™
Archomeda
@Archomeda
@Iye, I'm going to assume this will be added in details -> icon?
Yeah, thanks, I overlooked it when I was reading that 30 minutes ago...
Nabrok
@Nabrok
darthmaim
@darthmaim
@lye: why does /v2/pvp require authentication but /v2/pvp/seasons does not?
Nabrok
@Nabrok
seasons is just information on the season
standings has the user information
darthmaim
@darthmaim
I know, still weird that the parent endpoint requires auth, but the child does not
Nabrok
@Nabrok
It's all public data
Nothing account specific
darthmaim
@darthmaim
I know
/v2/pvp also doesn't have any account specific info
it just lists the sub endpoints (games/stats)
/v2/pvp shouldn't be authenticated, but games/stats/standings/... should
Pat Cavit
@tivac
Looking at the code it's probably a bug
file an issue please
darthmaim
@darthmaim
will do
Pat Cavit
@tivac
module.exports.index = troll(
    token.requireScopes([ "account", "pvp" ]),

    function(req) {
        return reply.json([
            "stats",
            "games"
        ]);
    }
);
since all it can ever do is reply json, I'm not sure why it should require auth at all
assuming copy/paste error
oh it's because at one point it did return user info
darthmaim
@darthmaim
opened #259
that was fast :D
Pat Cavit
@tivac
easy fix, especially after I walked backwards to see why it ever had that
darthmaim
@darthmaim
ran into the issue when writing my wrapper, because my fluent interface required an api key for pvp ($api->pvp('API_KEY')->seasons()), which makes no sense, since seasons doesn't need the API_KEY
Nabrok
@Nabrok
I'm wondering ... cache season data in perpetuity or clear it on new builds?
Existing seasons shouldn't really change at all.
Pat Cavit
@tivac
afaik seasons are just in a config file right now
because they aren't really in content in a queryable way
and change basically almost never
lye
@lye
@Nabrok they can technically change between builds; the only hardcoded bit are the start/end dates
but I doubt they'll change -- it would cause some interesting things to happen
Nabrok
@Nabrok
Yeah, I'm thinking I might as well keep it. If something does change I can always wipe the cache manually.
lye
@lye
Erk, /v2/guild/:id/teams isn't actually bulk-expanded
I should probably stop doing that
lye
@lye
If anyone has a few spare minutes, looking for some opinions on arenanet/api-cdi#260 because I'm unhappy with that
idivait
@idivait
Making a ./epeen slack command forthwith now that we have wvw rank stats. :D
lye
@lye
heh
idivait
@idivait
I prob shouldn't be as excited as I am about that lol.
windwarrior
@windwarrior
@lye: I agree that /v2/guild/:id1/teams/:id2/games/ looks horrible, especially when you can also go with ?ids=. But what are the options other then seperating the namespace of guilds and guild teams
so I think its either that, or /v2/guild/guildteams/:id2/, assuming a guild teams id is unique