Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jul 19 2018 18:18

    alexbarnsley on aip11-dev

    Add our security@ark.io email o… Merge pull request #128 from j-… (compare)

  • Jul 19 2018 18:18

    alexbarnsley on aip11-dev

    Add our security@ark.io email o… Merge pull request #128 from j-… (compare)

  • Jul 19 2018 18:18
    alexbarnsley closed #128
  • Jul 19 2018 18:18
    alexbarnsley closed #128
  • Jul 18 2018 17:14
    ciband commented #127
  • Jul 18 2018 17:14
    ciband commented #127
  • Jul 18 2018 17:12
    Moustikitos commented #127
  • Jul 18 2018 17:12
    Moustikitos commented #127
  • Jul 18 2018 17:12
    Moustikitos commented #127
  • Jul 18 2018 17:12
    Moustikitos commented #127
  • Jul 18 2018 16:59
    ciband commented #127
  • Jul 18 2018 16:59
    ciband commented #127
  • Jul 18 2018 16:48
    Moustikitos commented #127
  • Jul 18 2018 16:48
    Moustikitos commented #127
  • Jul 17 2018 01:01
    ciband opened #129
  • Jul 17 2018 01:01
    ciband opened #129
  • Jul 16 2018 09:35
    j-a-m-l review_requested #128
  • Jul 16 2018 09:35
    j-a-m-l review_requested #128
  • Jul 16 2018 09:35
    j-a-m-l opened #128
  • Jul 16 2018 09:35
    j-a-m-l opened #128
Rok Haluzan
@roks0n
UTC+1, yours?
Moustikitos
@Moustikitos
Paris
UTC+1 i guess
Have to go now
GN
Rok Haluzan
@roks0n
have a good one, cya
Moustikitos
@Moustikitos
thx
Rok Haluzan
@roks0n
these nodes are so called lisk seeds right: https://lisktools.io/pNodes.php ?
managed to get the test actually running, eventho it fails at the end
Rok Haluzan
@roks0n
ArkEcosystem/arky#66
Rok Haluzan
@roks0n
in the future I'd really like to change how the def load and also cfg.py are used.
Moustikitos
@Moustikitos
what s your idea about it ?
@roks0n
Rok Haluzan
@roks0n
I don’t think we need a separate file to store cfg attributes, we can have a global variable with all those settings most likely, current solution feel very hacky. Same goes for doing sys.modules[__package__].core = …. I need to have a think how to make it more robust. Also from understanding the current code it seems all networks do (will do) very similar things and handle things in a similar way, which enables us to write a base Network class from where all networks would inherit from.
oh and, about the broadcast in lisk, I didn’t really change anything after you commented on the code … I need to understand it better how we do handle things if broadcast is set or if it isn’t.
Rok Haluzan
@roks0n
one more thing, regarding the selectPeers function. Currently arky rotates peers every 30seconds in a separate thread. What if we would stop doing that every 30 seconds and just do it after every request that’s done? Not sure what’s the exact usecase so it might be totally reasonable to rotate them in a thread every 30 seconds I guess.
Moustikitos
@Moustikitos
@roks0n for the network behaviour, i agree. Based on RESTfull api, it is easy to configure a base network class
thing with core was the simpler i found to create a unique interface
could do
...
try :
    del core
except:
    pass
from arky import <ark or lisk> as core
using selectPeers in a thread allow a smoother CLI experience :)
Rok Haluzan
@roks0n
re core module - maybe, I need to have better think about it
re selectPeers, how do you mean smoother CLI experience? Because it’s less likely for peer to be down?
Moustikitos
@Moustikitos
idea is to be able to develop separately BC packages but using it the same way
Rok Haluzan
@roks0n
I agree, it should be done like that :)
Moustikitos
@Moustikitos
when selectPeers is encapsuled in a thread and when network is hard, the command line interface does'n freeze
ah ok :)
Rok Haluzan
@roks0n
what exactly does it mean when network is hard?
Moustikitos
@Moustikitos
when the ping for the BC network is high
Rok Haluzan
@roks0n
ah gotcha
ok, you’re right, it is better to have that run in a separate thread
btw, what are some of the next steps you’re trying to do with arky, if you have a plan of some sorts I can check, so I can be more helpful and not only work on random things and don’t do same/similar things you’re doing?
Moustikitos
@Moustikitos
i'm on code documentation using docstring
i started to write a wiki on the github page
next step is to allow ledger to sign transaction as secondSignature so account will be healthy against meltdown and spectre backdoors
I'm waiting for ARK V2 deployed on testnet to test the aip11 code
should be deployed in about 2 month i think
so here are the tasks :
  • finish docstring doc
  • create second signature using ledger
  • tweak the aip11-ark familly
Moustikitos
@Moustikitos
if you have any idea for optimization of curent code i'll take it
i have to go, familly time :)
thanks for your work
Rok Haluzan
@roks0n
not sure how could i could to anything for ledger, because I don’t have one. Also can’t find any tests in their codebase - I was hoping I could use what they use for mocking.
no worries, enjoy! :)
I’d love to make some tweaks to the code. If it’s fine with you, I’d also like to make the code follow pep8 style guide along the way.
Moustikitos
@Moustikitos
green light !
Rok Haluzan
@roks0n
perfecto :ok_hand:
Rok Haluzan
@roks0n

long time to chat, had busy days at work

I’m just looking at rest.py and wondered if it’s intentional that every time we call arky.rest.use() it changes the ndpt, which means if you want to make requests to lisk and ark at the same time, you can’t because it doesn’t create a new instance?

Rok Haluzan
@roks0n
ah I see, it’s would be hard to make it work differently because that initiates the .core module with either ark or lisk atm.
Rok Haluzan
@roks0n
did some things and wrote some tests: ArkEcosystem/arky#74
Moustikitos
@Moustikitos
hello there
nice havinng some juicy PR since a while !
reading your PR