Development discussion & coordination for the Arvados project. For Q&A, support and general discussion see https://gitter.im/arvados/community
I don't think adding it to Call() (or CallRaw as a matter of fact) is what we want
so I separated it in 2 commits and you can see the different results
ba87b0cb04e4a7e8e837567d9a6e317f3d5fa0b2 still has the 60s delay, because of retries
oopps somthign in sdk/go/keepclient/keepclient.go was not commited. give me asec
(tests passed)
@tomclegg if we only have CallRaw() that will be the behaviour but since we have both changes, from arvados-client wont happen.
but if rawcall() is called will show that warning
does it make sense?
@nicocesar https://dev.arvados.org/issues/17437#note-21 ... add Content-Length to "dropHeaders" doesn't cause any failures. Reading through the ticket history I'm not sure you ever tested whether that makes WEBrick work, but either way I think we should do it, because there's no need to interfere with Go's automatic handling of Content-Length, encoding, etc... WDYT?
https://dev.arvados.org/projects/arvados/repository/revisions/ba6c20de92c9821c2d674001ce0663c6d8ed9aa8/diff/lib/controller/proxy.go if that diff is all we need, let's cherry pick that and merge it to master
@ldipenti https://dev.arvados.org/issues/17415?issue_count=4&issue_position=1&next_issue_id=17337#note-8 I think it should be ok now
it required upgrade of cypress to latest as this issue was fixed recently
Great!, on it. Related note: while working on the cypress tests flakyness I discovered a bug in the
cy.loginAs() call: when called with 2 different users on the same test, the 1st session leaked some data into the 2nd session (this may be also a sign that a bug exists on the /token?api_token=xxx handling code), and one of the favorites tests was relying on that bug to sometimes pass :)
@DannyNs You may want to fix this and re-run the tests :)
[lucas:~/Devel/git/arvados-workbench2] 17415-Mountainduck-Bookmark-files+* 3s ± git grep 'it\.only'
cypress/integration/collection.spec.js:35: it.only('allows to download mountain duck config for a collection', () => {
[lucas:~/Devel/git/arvados-workbench2] 17415-Mountainduck-Bookmark-files+* 3s ±
sorry
@tomclegg I realized I have a pending review from you, sorry.
@nicocesar https://dev.arvados.org/issues/17204 is up for review... and replied on https://dev.arvados.org/issues/17566
yeap I was reviewing https://dev.arvados.org/issues/17204
