Development discussion & coordination for the Arvados project. For Q&A, support and general discussion see https://gitter.im/arvados/community
Which, again, makes sense, the instance of the method
manifest_text that's bound to c1 obviously can't be the same as the one bound to c2
I have to admit I'm getting a bit of a "how did this ever work" vibe
print(c1.manifest_text, c2.manifest_text, c1.manifest_text == c2.manifest_text) -> <bound method RichCollectionBase.manifest_text of <arvados.collection.Collection object at 0x7f1fc77b6ac8>> <bound method RichCollectionBase.manifest_text of <arvados.collection.Collection object at 0x7f1fc6468940>> True
Hmm, what I said earlier about method instances "obviously" being different is only true when the names
c1 and c2 refer to different objects. If they were the same object, the test would pass...
Well okay now I have two questions
Based on that output, I don't think what the test is doing is what the test intended
But also how the heck is that comparison true
the method definition
manifest_text is the same which means possibly the comparison is of function pointers and not taking the bound object id into account which seems odd but this might be a box of horrors best left unopened
I agree 100% that the intended behavior was to test the value returned by the manifest_text() m ethod
Your "box of horrors" is my "unexplored lower depths of the iceberg"
But yeah for now I can just adjust the text. Should I prep a small branch for that?
FWIW arvbox uses Python 3.7, should double check what version jenkins uses
that python 3.7 and 3.9 might have different opinions about this corner case seems most likely
Peter Amstutz: I have confirmed that the obvious fix of just calling those methods is the only fix necessary to get the tests passing. OK to just push directly?
1 reply
Peter Amstutz: For the structure of the
create body, the API docs make it look like update should follow the same pattern. Is that right?
@stephen304: HTTP URL rendering works great, scrolling is fixed, but I'm still seeing empty JSON tab for inputs (but not outputs), ummm, what would you suggest doing to debug it?
I'm seeing this when I visit the process page while it is in the "Running" state
right, I think it's loaded, but something about the Running state is different
try launching a job and then visiting it
see if you can reproduce it that way
It has been getting compute node startup failures I haven't chased down
@tomclegg: 18842-arv-mount-disk-config was back to you a few days ago, do you have time to look at it today?
ticket ready to be reviewed https://dev.arvados.org/issues/19786 by whoever takes the review task :)
thank you @stephen304 for the test hint :)