Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 16 2021 05:19
    dhirajdhule commented #100
  • Oct 15 2020 06:23
    Just1045523143 commented #100
  • Jul 23 2019 15:41
    asmodehn opened #70
  • Jul 23 2019 15:39
    asmodehn closed #69
  • Jul 23 2019 15:39
    asmodehn commented #69
  • Jul 23 2019 15:38

    asmodehn on 0.3.0

    (compare)

  • Jul 23 2019 15:35

    asmodehn on master

    forcing pip upgrade in venv se… (compare)

  • Jul 23 2019 15:28

    asmodehn on master

    v0.3.0 (compare)

  • Jul 18 2019 19:29
    cjds closed #131
  • Jul 18 2019 14:36
    cjds closed #47
  • Jul 17 2019 16:19
    asmodehn commented #69
  • Jul 17 2019 16:14
    alankritapathak opened #69
  • Jul 04 2019 16:38
    asmodehn commented #47
  • Jul 04 2019 16:37
    asmodehn commented #131
  • Jul 04 2019 16:36
    asmodehn commented #47
  • Jul 04 2019 16:33
    asmodehn closed #68
  • Jul 04 2019 16:33
    asmodehn commented #68
  • Jul 04 2019 16:32

    asmodehn on pipenv

    (compare)

  • Jul 04 2019 16:32

    asmodehn on master

    adding pipenv Pipfile for envir… adding more python versions for… adding melodic to travis tests and 18 more (compare)

  • Jul 04 2019 16:32
    asmodehn closed #65
Dhiraj D
@dhirajdhule
will look into it
AlexV
@asmodehn
thanks a lot !
Dhiraj D
@dhirajdhule
I will take a look at links provided
then might have small discussion to make sure that I understand what is actually required
AlexV
@asmodehn
Sure, I currently made hte very quick solution. And I have in mind the very long term solution (raft). But there might be a middle way that would be good enough for you now without going all the way to raft... not sure about how though...
Dhiraj D
@dhirajdhule
hmm
What I want right now is that I should be able to run client from any machine on lan with just pyzmp installed and it should connect the pyros_ros node
AlexV
@asmodehn
feel free to make a PR to link the tutorials repo to the doc/readme in pyzmp when you get some time ;-) would be useful for newcomers.
but you also want dynamic discovery of services, correct ?
Dhiraj D
@dhirajdhule
yeah sure!
yes
AlexV
@asmodehn
so that means there needs to be "consensus" on what the list of services is between the different clients and nodes...
either one "wellknown" source of truth, or a distributed algorithm implementing consensus...
at the moment, hte multiprocessing.Manager is hte one "well known" source of truth...
Dhiraj D
@dhirajdhule
just to clear in misunderstanding do you mean https://github.com/asmodehn/pyros/blob/master/pyros/basenode.py#L70 by services
?
AlexV
@asmodehn
yes, hte pyzmp concept of services (not ROS services)
Dhiraj D
@dhirajdhule
yeah, then we can have a wellknown truth
thats no problem
it will do for now
AlexV
@asmodehn
well known truth in LAN means a specific node that should always be there and never go down.
and all other nodes should register themselves and their providers when they start/stop
Dhiraj D
@dhirajdhule
yes, that can be done
AlexV
@asmodehn
maybe you ll need some API changes in pyzmp, just let me know ;)
or PR :)
Dhiraj D
@dhirajdhule
ohh..sure :) will let you know when I reach there ;)
AlexV
@asmodehn
:+1:
Dhiraj D
@dhirajdhule
Btw in pyros_client I think recv_timeout should be added to the service calls
current timeout is 5sec and some services take more time than that to respond
its better to give the user control of this timeout
I myself faced this problem
AlexV
@asmodehn
oh yes I had this thinking too at some point...
Dhiraj D
@dhirajdhule
anyway underlying pyzmp routines have this configurable timeout built into them
its just about passing on control to usres
users
AlexV
@asmodehn
yeah... here I heard hte argument of "Devs dont want to care about timeouts, just break if something is wrong, or keep trying for ever...". the point being that the timeout depends on the robot, so there is no way to get a "good timeout"...
so I was thinking about putting that ina aconfiguration or smthg...
anyway passing control to user is a good and simple solution right now, but not the final answer I think.
Can you make an issue for this please ?
Dhiraj D
@dhirajdhule
yes
AlexV
@asmodehn
I will have to fix a few issues in pyros in the next week... some are becoming annoying here. I can have a look at that at the same time.
Dhiraj D
@dhirajdhule
sure..I too thought that 'some' timeout is always dependent on robot
AlexV
@asmodehn
like the slow discovery of ROS services/topics when using rostful...
Dhiraj D
@dhirajdhule
I will put it under issue
AlexV
@asmodehn
or feelf ree to PR if oyu have some time
Dhiraj D
@dhirajdhule
ok
AlexV
@asmodehn
Last time I had a look at pyros, I have been working on autobuild and continous testing : https://travis-ci.org/asmodehn/pyros/builds/157793482 So this should help making sure the PR doesnt break anything important.
didnt have time to do it for rostful yet, I am just in the middle of finalizing pyros package...