These are chat archives for assetgraph/assetgraph

6th
Aug 2016
Munawwar
@Munawwar
Aug 06 2016 14:11
How goes the progress on skrin and fusile?
Peter Müller
@Munter
Aug 06 2016 14:12
I've diverted my energy to fixing my garden at the moment, so not really any progress.
Munawwar
@Munawwar
Aug 06 2016 14:17
:) Good to take a break. (I was just reading an extremely long article on "burnout" btw - https://www.1843magazine.com/features/minds-turned-to-ash )
Peter Müller
@Munter
Aug 06 2016 16:00
@papandreou Nice one in assetgraph/assetgraph@c7389fe
Seems to also have the side effect that we now no longer need:
it('should do something', function (done) { new AssetGraph({ root: 'foo' }).run(done); })
returning the transform queue seems to be enough now. At least I see my tests run
It that pure luck because mocha ducktypes the transformQueue as a Promise since it has a .then() ?
Andreas Lind
@papandreou
Aug 06 2016 16:58
@Munter That's exactly the intention. I've used that syntax for all new tests I've added since, but haven't bulk-converted all the existing ones. Would be nice to do that now that ag is fully promisified.
Peter Müller
@Munter
Aug 06 2016 17:40
Is the tranform queue actually a full promise implementation? It only seems to expose a .then. We might want to consider extending a bluebird promise to enable .catchet al
Peter Müller
@Munter
Aug 06 2016 17:56
Does this look sane to you? assetgraph/assetgraph#582
Andreas Lind
@papandreou
Aug 06 2016 18:00
Right, it's not a full impl, it's just kind of a hack that just provides then. Haven't tried extending Promise before, but let's try :)
Peter Müller
@Munter
Aug 06 2016 18:01
I haven't either. But it might be worth a shot
If we don't have any method naming conflicts