These are chat archives for assetgraph/assetgraph

8th
Oct 2016
Munawwar
@Munawwar
Oct 08 2016 08:23
Does docs include both guides and API reference?
Munawwar
@Munawwar
Oct 08 2016 09:26
Wow, I just found this -> https://mikewest.org/2013/09/xss-no-the-other-s-cssconfeu-2013. CSS-only "XSS".
Doesn't affect ag-b. But still...scary stuff.
Andreas Lind
@papandreou
Oct 08 2016 09:31
Realistically not API reference. I'm pretty keen on changing the ag API radically for the next major version, and would rather spend the time documenting the result of that.
I think we'll have to come to terms with ag-b being the main (only) product until we figure out how to simplify the main load/query/add/remove asset+relation story. Also, I think @Munter is right that we need to support lifecycle hooks before ag core can fit a wide spectrum of use cases.
Munawwar
@Munawwar
Oct 08 2016 10:27
Yea, I had high hopes for fusile...but lifecycle hooks might turn out to be more flexible and ultimately easier to add/integrate to the build compared to fusile.
Andreas Lind
@papandreou
Oct 08 2016 10:33
I still have high hopes for fusile. Just needs to be completed.
Munawwar
@Munawwar
Oct 08 2016 11:40
But it may not be easy to integrate. Since it relies on FUSE...which would have to be installed on dev machines and build machines. And also should cater to multiple OSes.
hmm the first one not may not be a problem.. Maybe it just needs an API that can be called through a grunt task/gulp task/ag-b plugin
Peter Müller
@Munter
Oct 08 2016 11:50
A hook into the file reading could call tolk when assetgraph populates. Then fusile is not needed
Peter Müller
@Munter
Oct 08 2016 12:49
Regarding font subsetting, we should remember to take css content: "foo" into account
Andreas Lind
@papandreou
Oct 08 2016 12:52
Good point. Got a little discouraged from that after @gustavnikolaj hunted down a bug that came down to very bad an inconsistent fallback behavior of unicode-range.
Peter Müller
@Munter
Oct 08 2016 12:56
Hmm :(
Isn't this something we could ask for help figuring out the best practice for if we poke some dev rels?
Andreas Lind
@papandreou
Oct 08 2016 13:04
Maybe, but I don't think it can work without duplicating the fallback @font-face declaration without unicode-range as IE and old Safari will pick the last definition and others the first.
iirc
Peter Müller
@Munter
Oct 08 2016 13:04
If it doesn't add extra overhead I guess that is still fine. And can be auto generated
Peter Müller
@Munter
Oct 08 2016 13:16
I asked Addy if he knows anything we can read up on
Munawwar
@Munawwar
Oct 08 2016 15:19
Do you have any documentation tool in mind for ag-b?
Andreas Lind
@papandreou
Oct 08 2016 15:20
README.md? :)
Munawwar
@Munawwar
Oct 08 2016 15:21
hmm..the README has become huge. It needs a "table of contents" at least.
^ my bad. That's for assetgraph. And not for assetgraph-builder.