These are chat archives for assetgraph/assetgraph

27th
Mar 2017
Andreas Lind
@papandreou
Mar 27 05:04
Awesome! Doesn't look that untested :)
Very tempted to try this with One.com's Website Builder.
Peter Müller
@Munter
Mar 27 05:08
I'm pretty confident with the inlining, since it's just the built in functionality. I'm missing a test for weights, which also need changes in the text discovery function
Andreas Lind
@papandreou
Mar 27 06:26
That sounds good.
I think I want to cover the fallback case as well, in case someone injects more characters on the page.
at runtime
Peter Müller
@Munter
Mar 27 06:44
Then we need to specify in the selector what characters are in the font and leave the original link there I think.
Andreas Lind
@papandreou
Mar 27 06:45
Yes, and maybe duplicate the original link due to different fallbacks in old IE and Safari, as I described the other day :(
Peter Müller
@Munter
Mar 27 07:25
Safari has woff support down to 5.1?
It's basically only if you still want to hit IE8 and below you need .eot
Andreas Lind
@papandreou
Mar 27 07:25
I'm talking about unicode-range: http://caniuse.com/#feat=font-unicode-range
The fallback for that is totally graceless :(
Peter Müller
@Munter
Mar 27 07:29
So worst case is we add more initial download and still do the double roundtrips for the css and webfont :(
But I guess that's only in the case where we want to retain support for dynamic content
Andreas Lind
@papandreou
Mar 27 07:30
The extra initial download should only amount to those two extra @font-face blocks, not the fonts themselves. Both old and new browsers will only fetch one of the fonts.
Andreas Lind
@papandreou
Mar 27 07:51
@Munter, damn, I have a module that uses await as a variable name, and esprima's sourceType: 'module' mode doesn't permit that. I wonder if we should fall back to trying non-module mode when that's encountered.
Or of we should try to infer the correct mode from the context (seems much harder)
Eg. how tf would we do that when following a SourceMapSource relation from a source map?
Andreas Lind
@papandreou
Mar 27 14:11
"Currently, subsets produce minimal fonts designed for PDF embedding that may not work as standalone files. They have no cmap tables and other essential tables for standalone use. This limitation will be removed in the future."
devongovett/fontkit#40