These are chat archives for assetgraph/assetgraph

11th
Apr 2017
Peter Müller
@Munter
Apr 11 07:17
I have no clue why assetgraph/assetgraph#728 is failing on travis :'(
Works great on both my home and my work machine
Andreas Lind
@papandreou
Apr 11 07:33
It fails consistently for me when I check out the branch.
Both when I run the entire test suite and with mocha -g 'transforms/bundleRelations with the oneBundlePerIncludingAsset strategy should insert a CSS bundle at the point of the first incoming relation'
Peter Müller
@Munter
Apr 11 07:43
wtf
Clearing node_modules
Nope. Still passing
node 6.10.0
Andreas Lind
@papandreou
Apr 11 07:46
7.8.0 here
Peter Müller
@Munter
Apr 11 07:46
travis is failing on both 4 and 6
So what do I have that is different, but still common on my work and home laptop...
Andreas Lind
@papandreou
Apr 11 07:47
I don't have anything linked in atm. I can try with a fresh npm install
Still fails
Peter Müller
@Munter
Apr 11 07:48
I cleared all caches on travis. Still fails. So I assume you won't see a difference with a fresh install
Andreas Lind
@papandreou
Apr 11 07:49
Confirmed
Peter Müller
@Munter
Apr 11 07:50
Fuck. filename casing
CURSE YOU OSX!!!
Andreas Lind
@papandreou
Apr 11 07:50
Ah, is it that Htmlstyle.js thing?
I noticed that but it seemed like too much of a nit to mention :)
Peter Müller
@Munter
Apr 11 08:31
Merged. I guess this is a patch release?
Andreas Lind
@papandreou
Apr 11 08:31
I'd say minor
Peter Müller
@Munter
Apr 11 08:32
alright. I'll go ahead with that
Andreas Lind
@papandreou
Apr 11 08:44
Awesome. That reminded me of adding the changelog entry for 3.0.0
Peter Müller
@Munter
Apr 11 08:47
I'm always having difficulty figuring out semver when it's about changes in the produced artifacts. So in assetgraph-builder, minor or patch?
Andreas Lind
@papandreou
Apr 11 08:48
Minor. This is a new feature.
And it's backwards compatible (at least semantically and for non-bogus input)
Peter Müller
@Munter
Apr 11 08:49
Could be seen as a bugfix as well. But I'd rather err on the side of caution and use a minor :)
Andreas Lind
@papandreou
Apr 11 08:50
So you think of it as a bug that the feature wasn't previously implemented? :)
Peter Müller
@Munter
Apr 11 08:51
It's a bug in relation to "If it works in the browser it works in assetgraph"
I had working code in the brower, and the build broke it
I actually had another thing break in the build yesterday: svg/svgo#705
Andreas Lind
@papandreou
Apr 11 08:52
Hmm, yeah, ok. It would be a bit risky to release patch versions in all situations like that.
Peter Müller
@Munter
Apr 11 08:55
builder v5.1 released
Andreas Lind
@papandreou
Apr 11 08:55
Urgh, that's an annoying one
We ran into another svgo issue the other day -- updating svgo lost the dot between "one" and "com" in our apps. Good thing our QA dept is awake :)
Peter Müller
@Munter
Apr 11 08:56
I ended up just adding , path to the selector, just to move on
Yeah, I saw Gustavs face on the issues list just before I opened mine :)
Andreas Lind
@papandreou
Apr 11 08:57
heh
Got mitigated by assetgraph/assetgraph@bf5edf5
Peter Müller
@Munter
Apr 11 11:29
Switched to assetgraph-builder 5.1.0 and it fixed my problem
Andreas Lind
@papandreou
Apr 11 11:29
Yay :+1: