These are chat archives for assetgraph/assetgraph

22nd
May 2017
Peter Müller
@Munter
May 22 12:21
schema.org... That's going to be fun to model
Andreas Lind
@papandreou
May 22 12:23
From the description it sounds like a very rapidly moving target :)
@Munter We have an upgrade path to jsdom 11, including a feature that I got to work the other day (map scripts and stylesheets that originally occurred inline in HTML back to the location in that HTML): assetgraph/assetgraph#742
It's still blocked on killing node.js 4 support and sorting out the unexpected-dom issues
Peter Müller
@Munter
May 22 12:37
Looks good to me. I' fine with killing node 4 support. What are the unexpected-dom issues?
Andreas Lind
@papandreou
May 22 12:39
@Munter The unexpected-dom issue is that it doesn't support the newest versions of jsdom. I've fixed that in Munter/unexpected-dom#181
@Munter This PR adds to that by also bumping jsdom-the-dev-dep: Munter/unexpected-dom#182
(which means that unexpected-dom can't run with node.js < 6 on CI, but it still supports much earlier jsdoms)
I think the right thing is to just merge Munter/unexpected-dom#182
Can't do much about the coverage drop, that's due to the dual paths for old and new jsdom
Peter Müller
@Munter
May 22 13:03
Let's merge all of it
Andreas Lind
@papandreou
May 22 13:03
:+1: :)
Then you'll also stop the wave of greenkeeper PRs
Peter Müller
@Munter
May 22 13:06
I haven't been able to keep up with my notifications. So they just go on the pile
Andreas Lind
@papandreou
May 22 13:41
@Munter Any objections against assetgraph/assetgraph#747 ?
I found out that WSB publishes some text components as divs that have have white-space: pre-wrap applied via an external stylesheet, which html-minifier of course doesn't detect. That's why I need some knobs to customize the options.
Seemed like a good occasion to get rid of our own extra HTML minification step.
Peter Müller
@Munter
May 22 13:48
HTML will still be minified though, right?
Andreas Lind
@papandreou
May 22 13:49
Yes, I promise :)
When we introduced html-minifier, it had some shortcomings, so we kept our own DOM-based minification alongside it.
Seems like those shortcomings have been fixed and/or are irrelevant
Peter Müller
@Munter
May 22 13:50
Awesome
Andreas Lind
@papandreou
May 22 13:52
Let me know if it's OK to merge it. I need to backport it to v2 as well btw.
Peter Müller
@Munter
May 22 13:54
Looks good to me
Andreas Lind
@papandreou
May 22 13:54
Thanks a lot, sorry for the urgency :)
Peter Müller
@Munter
May 22 13:55
btw I tried getting assetgraph-builder to build with our june setup again. Couldn't make it work
I basically need to merge a harp build and a webpack build. And assetgraph can't handle getting the harp build as root, but having the webpack build have a different root to resolve modules from
Maybe assuming assetgraph.root as a resolution root is wrong. The same data should be available in the webpack config?
Andreas Lind
@papandreou
May 22 17:29
Hmm, would running assetgraph-builder twice solve it?
I need your help with getting those unexpected-dom things released btw. I don't have any permissions to the repo
Peter Müller
@Munter
May 22 18:31
I thought I gave you that a long time ago. Now you have it. And publish rights
Andreas Lind
@papandreou
May 22 18:41
Great, thanks :)
Andreas Lind
@papandreou
May 22 18:53
Cleaned up all the greenkeeper cruft and released 4.0.0
Didn't think of that for browserified stuff
Andreas Lind
@papandreou
May 22 19:02
I think that's... yeah
Peter Müller
@Munter
May 22 23:01
I think I cracked the pseudo element case for font subsetting
Peter Müller
@Munter
May 22 23:10
assetgraph/assetgraph@eb79022