These are chat archives for assetgraph/assetgraph

21st
Jul 2017
Munawwar
@Munawwar
Jul 21 15:56
@papandreou Lebab gives a good start for ESification - http://lebab.io/try-it
however some cases where lebab conservatively uses var and the extendsWithGetterAndSetter replacement with classes will have to be done manually.
Andreas Lind
@papandreou
Jul 21 15:58
@Munnawar, I'm almost done with a manual sweep over the codebase
Sorry, I mean @Munawwar :)
Munawwar
@Munawwar
Jul 21 15:59
hmm..yea. Too late then. Could have saved good amount of time
I tried it on assets/Html.js
Andreas Lind
@papandreou
Jul 21 16:02
Probably could, I've probably spent a day and a half on it in total. But as you said there's some stuff that needed to be fixed up manually.
Especially the Asset#upgrade stuff introduced by assetgraph/assetgraph#755
Apparently es6 classes prohibit Function#call of the constructor, new is required. That ruined the strategy to subclass after the fact.