These are chat archives for astropy/astropy

8th
Jun 2014
Pritish Chakraborty
@PritishC
Jun 08 2014 04:52
How does SkyCoord parse string arguments like "1h12m43.2s +1d12m43s"? Need to know if I am to test string arguments to SkyCoord.
I've created a list of input tuples which I provide to the SkyCoord initializer. I hadn't thought of string inputs then.
Now if I add a string input tuple, it will break the tests.
Hmm..Sunday is not the ideal day to hope that people will be around, but if someone has any inputs for me, please do write them.
Pritish Chakraborty
@PritishC
Jun 08 2014 05:09
The _parse_coordinate_arg() method is incredibly helpful.
Solid logic to separate the string into proper arguments.
Pritish Chakraborty
@PritishC
Jun 08 2014 06:24
If anyone is around, could they please advise me on what I've done so far: taldcroft/astropy#9
Pritish Chakraborty
@PritishC
Jun 08 2014 12:32
@taldcroft, could you review the SkyCoord tests please?
Pritish Chakraborty
@PritishC
Jun 08 2014 13:12
@astrofrog, I didn't make that astropy_helpers change. It's been there since the rebase.
Thomas Robitaille
@astrofrog
Jun 08 2014 14:34
@VaticanCameos - it was somehow included in VaticanCameos/astropy@afbf747 - I think you will need to rebase and edit that commit to remove the change.
Pritish Chakraborty
@PritishC
Jun 08 2014 16:57
@astrofrog - Could I not just revert the file to its previous state?
Thomas Robitaille
@astrofrog
Jun 08 2014 17:10
Yes, you could do that - and in fact if you do it in a standalone commit, it will make it easy to later rebase and cancel out that change (just for a cleaner history)
Stuart Mumford
@Cadair
Jun 08 2014 17:10
@astrofrog your git ocd is showing again ;)
Thomas Robitaille
@astrofrog
Jun 08 2014 17:25
it's just that in this case it's a submodule and I don't like messing with going back and forward with the submodule versions
but ok, I guess it doesn't really matter
just curious how it got there
Stuart Mumford
@Cadair
Jun 08 2014 17:28
I agree it is a silly thing to have in the hisstory