These are chat archives for astropy/astropy

11th
Nov 2015
Thomas Robitaille
@astrofrog
Nov 11 2015 06:30
@bsipocz - I think we are almost there! See my latest comment and commits in bsipocz/photutils#2
Thomas Robitaille
@astrofrog
Nov 11 2015 06:49
Indeed - it worked!
Brigitta Sipocz
@bsipocz
Nov 11 2015 13:41
@astrofrog i'm off to a seminar now, but after that can work on a PR for core
Thomas Robitaille
@astrofrog
Nov 11 2015 13:42
@bsipocz - ok, great! :)
Thomas Robitaille
@astrofrog
Nov 11 2015 17:23
@bsipocz - let me know if I can do anything to help - I could write up the instructions for ci-helpers about the environment variables if you like?
Brigitta Sipocz
@bsipocz
Nov 11 2015 18:00
@astrofrog - yes, that would be great if you could write the instructions.
also a question: both photutils and astroquery installed pytest-xdist in their travis, but it's very independent of the test suite anyway, so should we do it in ci-helpers, right?
psutil is a similar case. Do we need it, and if yes can it go into ci-helpers?
Brigitta Sipocz
@bsipocz
Nov 11 2015 18:07
@astrofrog - also if you're here, please cancel my latest core build https://travis-ci.org/astropy/astropy/builds/90571544 as it's pure docs change.
(edited it on github and forgot the skip-ci tag)
Thomas Robitaille
@astrofrog
Nov 11 2015 18:15
@bsipocz - build cancelled
pytest-xdist: I'm not actually sure what it's used for - are you saying we should just always install it?
psutil: which packages install it?
Ah it's used for the --open-files thing (psutil)
so you are suggesting we should just always install it?
I'd be fine with that
Brigitta Sipocz
@bsipocz
Nov 11 2015 18:57
as I see the pytest-xdist is for parallel builds
not sure that any of the packages uses it in their travis though http://docs.astropy.org/en/stable/development/testguide.html#running-tests-in-parallel
same with psutils
so maybe include a conditional in ci-helpers for --parallel or --open-file and then install it there?
Thomas Robitaille
@astrofrog
Nov 11 2015 19:07
@bsipocz - yes, we could do that, but only if it's not too tricky
If it ends up being difficult to do in the bash script, we can just always install them
btw just to let you know, I'm working on the instructions for the README.md in the mean time
Thomas Robitaille
@astrofrog
Nov 11 2015 19:37
I'll finish this tomorrow while traveling, maybe we can plan to email the astropy-dev list tomorrow evening once it's all ready for review?
Brigitta Sipocz
@bsipocz
Nov 11 2015 19:38
Sure. I try to finish both the core and astroquery tonight, they are almost there now.
I think parallel and open-file is easy, basically we do the same with build_spinx already
Thomas Robitaille
@astrofrog
Nov 11 2015 19:42
Yes, just saw your fixes for that, looks good! :)
thanks for working on this!
I'll finish up the docs tomorrow while traveling
and once that's done, you could send the email to the list if you like, since you've done most of the work? :)
Brigitta Sipocz
@bsipocz
Nov 11 2015 19:46
ok, we can do that :)
Thomas Robitaille
@astrofrog
Nov 11 2015 19:47
great, thanks!
Brigitta Sipocz
@bsipocz
Nov 11 2015 19:54
now I'm off to go home and dinner, but will ping you on the PRs when they're ready.
Thomas Robitaille
@astrofrog
Nov 11 2015 20:56
thanks!
Brigitta Sipocz
@bsipocz
Nov 11 2015 21:31
@astrofrog - we had wcsaxes for the docs build for core, and it's imported in one place too (wcs.WCS._as_mpl_axes), so even if not now but we may want to test against it at some point, don't we?
Thomas Robitaille
@astrofrog
Nov 11 2015 21:31
Right, but to some extent it gets tested in WCSAxes
I think it could get confusing if we allow astropy to get pip installed in Travis
Brigitta Sipocz
@bsipocz
Nov 11 2015 21:32
ok, that makes life easier :)
Thomas Robitaille
@astrofrog
Nov 11 2015 21:32
We can cross that bridge at some point if needed but let's definitely not make changes like that while also switching to ci-helpers
:)
Brigitta Sipocz
@bsipocz
Nov 11 2015 21:33
:)