These are chat archives for astropy/astropy

10th
May 2016
Thomas Robitaille
@astrofrog
May 10 2016 15:20
@MSeifert04 @mirca - I think this time we'll be much more strict though, so Friday is the freeze! :snowflake:
Michael Seifert
@MSeifert04
May 10 2016 16:21
@astrofrog Oh no! That means I really have to make @mwcraig review my PRs soon. :smile: Maybe another question: Is there someone else who wants to review some NDData PRs? I have quite a list of those. :smile:
Michael Seifert
@MSeifert04
May 10 2016 16:53
does the freeze include documentation-PRs? Do I have some time after the freeze (when I know what made it) to finish it?
Thomas Robitaille
@astrofrog
May 10 2016 17:20
In general documentation improvements/fixes are fine after the feature freeze
Adrian Price-Whelan
@adrn
May 10 2016 17:39
anyone have any ideas why this reference to rotation_matrix isn't resolving with Sphinx? https://github.com/astropy/astropy/pull/4734/files#diff-b922e5f47422c662c73330bb7320d929R111
Michael Seifert
@MSeifert04
May 10 2016 17:44
I think because it's not public
Adrian Price-Whelan
@adrn
May 10 2016 17:44
ah
Adrian Price-Whelan
@adrn
May 10 2016 17:53
thanks
Matt Craig
@mwcraig
May 10 2016 18:05
No worries @MSeifert04 it will happen today (there will be many rebases involved because of chabgelog conflicts unfortunately)
Michael Seifert
@MSeifert04
May 10 2016 18:15
I love rebasing :-/ But thank you for offering to review them. :+1:
jehturner
@jehturner
May 10 2016 19:32
@MSeifert04, @mwcraig : My time is pretty limited but I can have a quick look at one or more of these if it helps.
Michael Seifert
@MSeifert04
May 10 2016 20:51
@jehturner I'll let @mwcraig decide which PRs could use another set of eyes. There are two PRs that are non-trivial in terms of code: #4799 and #4851 and several others (all of them are listed in a comment in #4538) that require "just" a decision. I think the latter ones will be the hard ones :smile:
Michael Seifert
@MSeifert04
May 10 2016 22:19
is it ok if a PR fixing a Bug contains two commits both triggering the test build. The first to show the bugs and the second one to fix them? Or is that "unnecessary" wasting of testing ressources?
@mwcraig This question is about the planned PR you mentioned in https://github.com/astropy/astropy/issues/4825#issuecomment-218294761
Matt Craig
@mwcraig
May 10 2016 22:59
@jehturner the more the merrier! Will ping you on a couple tonight, but jump right in in the meantime....
Michael Seifert
@MSeifert04
May 10 2016 23:40
@mwcraig I did some updates and I thank you for all the feedback on the reader/writer :+1: I hope it's okay that I haven't adressed some of your comments there (yet).