These are chat archives for astropy/astropy

11th
May 2016
Thomas Robitaille
@astrofrog
May 11 2016 13:13
@eteq - it would be great if you give go/no go comments on astropy/astropy#4860 astropy/astropy#4697 astropy/astropy#4848 - these are ones that won't take long to review
Ole Streicher
@olebole
May 11 2016 15:28
@astrofrog - I am looking to complete #4659
Since this is not visible for the user: do you really think it needs a changelog entry?
Thomas Robitaille
@astrofrog
May 11 2016 15:58
@olebole - yes, please still add a changelog entry, because it will still matter for users who may have run the tests and run into failures like astropy/astropy#4647
the changelog is also for us developers, so it's still helpful to know this was fixed
Ole Streicher
@olebole
May 11 2016 16:23
Where do I find the changelog? And how do I put fixes for different branches into the PR?
Thomas Robitaille
@astrofrog
May 11 2016 16:35
The changelog is the CHANGES.md file - you only need to put it in the oldest version you want it to apply to
so if you want to backport the fix to e.g 1.0.x then you put it in the latest 1.0.x entry
if you want to backport it only to 1.1.x then in the latest 1.1.x entry
just put it under 'bug fixes' in the relevant version
Ole Streicher
@olebole
May 11 2016 16:44
OK, Thanks!
Michael Seifert
@MSeifert04
May 11 2016 18:05
Does anyone have a suggestion for a parameter-value that indicates that the first-not-None-not-empty value given 2 properties is taken? I'm really bad at providing unambiguous and clear names and currently I propose "first_found" or "ff" (as abbreviation of first_found). Relevant PR: #4789
Ole Streicher
@olebole
May 11 2016 18:05
Sorry to disturb again with a triviality: do I need to rebase the PR branch to the 1.0 resp. 1.1 branch then? Or how do I apply the changes "in" a certain branch?
Adrian Price-Whelan
@adrn
May 11 2016 20:17
Working on documentation for a package built off of the package-template and making use of automodapi from the astropy core. I'd like classes to show inherited methods/attributes on their API pages. The way I knew to do this with autodoc is to use :inherited-members: (e.g., http://www.sphinx-doc.org/en/stable/ext/autodoc.html#confval-autodoc_default_flags) but when I turn this on globally in my conf.py i get tons of sphinx warnings like: /Users/adrian/projects/gary/build/lib.macosx-10.5-x86_64-3.5/gary/util.py:docstring of gary.util.rolling_window:0: WARNING: duplicate object description of gary.util.rolling_window, other instance in /Users/adrian/projects/gary/docs/util.rst, use :noindex: for one of them. Any one have any ideas? cc @bsipocz @eteq
Brigitta Sipocz
@bsipocz
May 11 2016 21:21
@olebole - AFAIK, all PRs should be against master, and the backporting will be done by the person doing the release.
(If it's for testing only, I think you could either cherry-pick the changes on top of the bugfix branch, or rebase it).
@adrn - which helpers do you use? The current master has a fix for the inherited-members, and also some sphinx fixes. I wonder whether those solve your issue.
Adrian Price-Whelan
@adrn
May 11 2016 21:24
ah, ok i'll give that a try - i'm using 1.1.2 i think
Adrian Price-Whelan
@adrn
May 11 2016 21:52
@bsipocz strange - even with master it doesn't seem to work. do i need to enable inherited members?
Thomas Robitaille
@astrofrog
May 11 2016 22:02
@olebole - @bsipocz is right, you only need to rebase against master, and we'll take care of backporting later
Thomas Robitaille
@astrofrog
May 11 2016 22:16
@eteq - just to check, are you around?
Brigitta Sipocz
@bsipocz
May 11 2016 22:49
@adrn - Yes, include automodsumm_inherited_members = True in docs/conf.py
Michael Seifert
@MSeifert04
May 11 2016 22:52
@bsipocz Is it possible to only enable this for one subpackage?