These are chat archives for astropy/astropy

2nd
Mar 2017
VSN Reddy Janga
@janga1997
Mar 02 2017 10:59
Hi, is anyone free to review the last part of #5839 ? Its been sitting ducks for a couple days, and over a very minute issue .
Thanks!!
Brigitta Sipocz
@bsipocz
Mar 02 2017 11:19
@janga1997 - Patience is a virtue, most maintainers are volunteers in the project and will do the review in their spare time.
VSN Reddy Janga
@janga1997
Mar 02 2017 11:20
Sorry about that @bsipocz . I was just wondering if it had been lost under so many PRs right now.
The maintainers have been great till now, and I meant no offense. thanks for the reply !
Brigitta Sipocz
@bsipocz
Mar 02 2017 14:14
Sure. Sometimes PRs are lost, but usually due to combination of different factors (being a long complicated PRs or not having agreement about the details). Finished up bugfixes hardly ever fall into this category, and I'm sure your one will be merged soon.
Mohan Agrawal
@mohanagr
Mar 02 2017 18:44
Is there any reason that pytest has not been used extensively in testing? I am mostly seeing custom boilerplate code for eg. in FitsTestCase
matrixbot
@matrixbot
Mar 02 2017 18:46
Cadair I would guess that a lot of the fits code pre dates pytest
Cadair Astropy policy is to use pytest
Mohan Agrawal
@mohanagr
Mar 02 2017 19:13
I was writing tests for fitsheader and other scripts. Felt the need for more of pytest since this is my first major testing experience
Issue #5799
shouldn't we re-write some tests using pytest. fixtures like capsys, tmpdir, monkeypatch reduce almost all boilerplate code and make things simpler.