These are chat archives for astropy/astropy
def _populate_table_keywords(self): """Populate the new table definition keywords from the header.""" for idx, column in enumerate(self.columns): for keyword, attr in six.iteritems(KEYWORD_TO_ATTRIBUTE): val = getattr(column, attr) if val is not None: keyword = keyword + str(idx + 1) self._header[keyword] = val for key in self._header_column.keys(): if key.endswith(str(idx + 1)): self._header[key] = self._header_column[key] self._header_column.remove(key)
bsipocz@austerecuriosity - I'm around in the next few hours, so happy to help to set up travis on your fork
bsipoczlet me know when you're there
bsipoczso right hand corner, click on your name
bsipoczthat should bring up a list of your repositories
bsipoczyou should be able to find astropy there
bsipoczclick on the slider to enable travis on it
bsipoczinside setting you want to have "Build branch updates" on
bsipocz(also having the pull request on can be helpful if someone opens a PR against your fork)
bsipoczbasically that's it
bsipoczif you have it on it wil run travis for each and every push you make, so you can play around with it to switch off and on from time to time
bsipocznow you have that WIP pull request open
bsipoczsince we are close to feature freeze and would be nice not to have travis run for it on the astropy repo, I suggest to open a copy branch and do the development there
bsipoczonce you're happy with a commit, you can use
git cherry-pick <commit-hash>on your original branch of the PR to copy over the changes from the copy branch, and add the
[ci skip]to the commit message
bsipoczit sounds a bit messy, but sometimes these workarounds are very useful
bsipoczand also provides much faster testing as you don't need to wait for the whole CI queue
bsipoczohh, each commit has a hash, I just meant that
git cherry-pickis very useful to move commits around between branches.
bsipoczwe will be out of freeze soon, so everything can go back to normal after that :)
bsipoczThat's is a deadline for adding new features to the new release.
bsipoczusually means that many people are trying to finish up their work t the same time
bsipoczit's rather fun as there are lots of activity, but it also means that we have a huge traffic jam on CIs that holds back work
bsipocze.g. if you go to the contribution graphs, there are those larger peaks with a period of ~half year, those are usually around these dates: https://github.com/astropy/astropy/graphs/contributors
bsipoczyes, your mentors are heavily involved
ctype=["RA---AZP-SIP", "DEC--AZP-SIP"]and tricking it by substituting az,alt for ra,dec when I fit the WCS. While it works, it's going to confuse the hell out of anyone else that tries to use my WCS solution. Is there a proper way of saving a WCS in an Alt,Az frame?
bsipocz@austerecuriosity - yes, adding
[ci skip]to the last commit message should be fine. Unless it's something that should/can go into 2.0, in that case let CI run on it.