Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Mar 04 04:01
    Blacksmoke16 synchronize #106
  • Mar 04 04:01

    Blacksmoke16 on view-layer-enhancements

    View specs (compare)

  • Mar 04 02:02
    Blacksmoke16 synchronize #106
  • Mar 04 02:02

    Blacksmoke16 on view-layer-enhancements

    Add FormatNegotiator spec Prop… (compare)

  • Mar 04 00:01
    Blacksmoke16 synchronize #106
  • Mar 04 00:01

    Blacksmoke16 on view-layer-enhancements

    Add spec for format listener (compare)

  • Mar 03 17:05
    Blacksmoke16 synchronize #106
  • Mar 03 17:05

    Blacksmoke16 on view-layer-enhancements

    Test request format methods Ad… (compare)

  • Mar 03 04:45
    Blacksmoke16 synchronize #106
  • Mar 03 04:45

    Blacksmoke16 on view-layer-enhancements

    Cleanup some format resolution … (compare)

  • Mar 02 03:39
    Blacksmoke16 synchronize #106
  • Mar 02 03:39

    Blacksmoke16 on view-layer-enhancements

    Add `#get` and `#get?` with fre… (compare)

  • Mar 02 03:13
    Blacksmoke16 opened #106
  • Mar 01 00:33
    Blacksmoke16 edited #34
  • Mar 01 00:33
    Blacksmoke16 edited #34
  • Mar 01 00:33
    Blacksmoke16 edited #34
  • Feb 25 23:52

    Blacksmoke16 on view-layer-enhancements

    First pass at view layer enhanc… Second pass Scaffold out helper controller … and 5 more (compare)

  • Feb 23 00:59

    Blacksmoke16 on gh-pages

    Fully deprecate legacy API docs (compare)

  • Feb 23 00:19

    Blacksmoke16 on gh-pages

    Create 404.html (compare)

  • Feb 19 01:44

    Blacksmoke16 on regex-cors-origins

    (compare)

Andrew
@andrewc910
I can see the reason for a single endpoint handling many format types. Rails/amber have a method " responds_to" which accepts a block and in the block you do json my_data.to_json and html Kilt.render x (sorry on mobile). Why isn't that good enough? Or rather, when would you actually "negotiate".
George Dietrich
@Blacksmoke16
iirc its implemented via a listener. I.e. there is a FormatListener that would do the negotiation and set the expected format on the request
then the view listener changes to moves things behind a ViewHandler
which that thing knows all the view handlers and invokes the right one based on the request's format
essentially the same as rails thing, but it keeps your controller agnostic of the format
as it just returns the data and rest is handled/customizable in the view layer
Andrew
@andrewc910
Oh so the controller would just return the data and the negotiator would handle the serializing. Instead of having responds_to in every controller action, we have 1 listener that handles the serialization.
I really like that!
Thank you! I was having a hard time seeing the use case. Much appreciated <3
George Dietrich
@Blacksmoke16
yea exactly
np
negotiator just handles knowing what format the response should be in
it would be up to the user to handle the seralization for custom types other than like json
George Dietrich
@Blacksmoke16
oprypin
@oprypin:matrix.org
[m]

@Blacksmoke16: so regarding the docs. the way to link [Foo::Bar--stuff][] is here to stay.

regarding the anchors being /Foo/Bar#Foo::Bar--baz that remains non-viable to change, unfortunately.

regarding duplicated top-level headings: that will indeed be eliminated in the upcoming release. although you'll be forced to use H1 headings instead of the current H2, which means all heading font sizes become larger.

was there anything else?

George Dietrich
@Blacksmoke16
nice good stuff!
bummer about the anchors tho :/ but oh well
oprypin
@oprypin:matrix.org
[m]
@Blacksmoke16: what's the reason that those particular 2 files are chosen from the directory? https://github.com/athena-framework/athena/blob/cc379958d006447827218229b3afaa0db665dcf9/Makefile#L9-L10
do you think there would be a loss of functionality if only a wildcard on a directory was supported?
George Dietrich
@Blacksmoke16
the first is the main file, i.e. entrypoint into the component. The other isnt included in the main file, but is intended for use in specs. However i still want it to show up in the docs so i explicitly require that one too
oprypin
@oprypin:matrix.org
[m]
what i'm doing now is making [View source] links work for your site :3
-          rendering:
-            show_source_links: false
+          source_locations:
+            lib/athena-spec: https://github.com/athena-framework/spec/tree/v{shard_version}/{file}#L{line}
+            lib/athena-event_dispatcher: https://github.com/athena-framework/event-dispatcher/tree/v{shard_version}/{file}#L{line}
+            lib/athena-config: https://github.com/athena-framework/config/tree/v{shard_version}/{file}#L{line}
+            lib/athena-dependency_injection: https://github.com/athena-framework/dependency-injection/tree/v{shard_version}/{file}#L{line}
+            lib/athena-serializer: https://github.com/athena-framework/serializer/tree/v{shard_version}/{file}#L{line}
+            lib/athena-validator: https://github.com/athena-framework/validator/tree/v{shard_version}/{file}#L{line}
+            lib/athena: https://github.com/athena-framework/athena/tree/v{shard_version}/{file}#L{line}
+            lib/athena-negotiation: https://github.com/athena-framework/negotiation/tree/v{shard_version}/{file}#L{line}
mm
George Dietrich
@Blacksmoke16
:heart:
George Dietrich
@Blacksmoke16
i just did that change you linked btw
oprypin
@oprypin:matrix.org
[m]
@Blacksmoke16: but you'd need to actually delete the files that are there :o
all correct otherwise, but without that small detail it basically doesnt do anything
George Dietrich
@Blacksmoke16
Fair point
fixed
oprypin
@oprypin:matrix.org
[m]
so i released those features and sent a pull request to you
but there's anothing interesting development.
version selectors work well now :o
George Dietrich
@Blacksmoke16
:0 oh nice!
that's super useful
image.png
:heart_eyes: it's beautiful
oprypin
@oprypin:matrix.org
[m]
😋
George Dietrich
@Blacksmoke16
image.png
:0 is that new too?
1 reply
game changer
yea this is good stuff. Bummer about the URL fragments, but meh not a hugely noticeable thing
:heart:
George Dietrich
@Blacksmoke16
do you do something special to get the dep list to be the minified version?
4 replies
@oprypin:matrix.org
oprypin
@oprypin:matrix.org
[m]
i don't know, but it could be that i installed it once and never updated. can't check now
George Dietrich
@Blacksmoke16
np
oprypin
@oprypin:matrix.org
[m]

i don't know, but it could be that i installed it once and never updated. can't check now

yes, that was it, sry

George Dietrich
@Blacksmoke16
Np, I like it better the minified way.
So I'll guess you'll need to run it every time for me :laughing: