I can see the reason for a single endpoint handling many format types. Rails/amber have a method " responds_to" which accepts a block and in the block you do
json my_data.to_json and html Kilt.render x (sorry on mobile). Why isn't that good enough? Or rather, when would you actually "negotiate".
then the view listener changes to moves things behind a
ViewHandler
which that thing knows all the view handlers and invokes the right one based on the request's format
essentially the same as rails thing, but it keeps your controller agnostic of the format
as it just returns the data and rest is handled/customizable in the view layer
I really like that!
Thank you! I was having a hard time seeing the use case. Much appreciated <3
np
negotiator just handles knowing what format the response should be in
it would be up to the user to handle the seralization for custom types other than like json
https://symfony.com/doc/current/bundles/FOSRestBundle/format_listener.html are the symfony docs on it
@Blacksmoke16: so regarding the docs. the way to link [Foo::Bar--stuff][] is here to stay.
regarding the anchors being /Foo/Bar#Foo::Bar--baz that remains non-viable to change, unfortunately.
regarding duplicated top-level headings: that will indeed be eliminated in the upcoming release. although you'll be forced to use H1 headings instead of the current H2, which means all heading font sizes become larger.
was there anything else?
https://gitter.im/athena-frameworkcr/community?at=5ffb65ce5562a61e9a994634 - i believe this is still not done
bummer about the anchors tho :/ but oh well
@Blacksmoke16: what's the reason that those particular 2 files are chosen from the directory? https://github.com/athena-framework/athena/blob/cc379958d006447827218229b3afaa0db665dcf9/Makefile#L9-L10
do you think there would be a loss of functionality if only a wildcard on a directory was supported?
what i'm doing now is making [View source] links work for your site :3
- rendering:
- show_source_links: false
+ source_locations:
+ lib/athena-spec: https://github.com/athena-framework/spec/tree/v{shard_version}/{file}#L{line}
+ lib/athena-event_dispatcher: https://github.com/athena-framework/event-dispatcher/tree/v{shard_version}/{file}#L{line}
+ lib/athena-config: https://github.com/athena-framework/config/tree/v{shard_version}/{file}#L{line}
+ lib/athena-dependency_injection: https://github.com/athena-framework/dependency-injection/tree/v{shard_version}/{file}#L{line}
+ lib/athena-serializer: https://github.com/athena-framework/serializer/tree/v{shard_version}/{file}#L{line}
+ lib/athena-validator: https://github.com/athena-framework/validator/tree/v{shard_version}/{file}#L{line}
+ lib/athena: https://github.com/athena-framework/athena/tree/v{shard_version}/{file}#L{line}
+ lib/athena-negotiation: https://github.com/athena-framework/negotiation/tree/v{shard_version}/{file}#L{line}
@Blacksmoke16: but you'd need to actually delete the files that are there :o
all correct otherwise, but without that small detail it basically doesnt do anything
fixed
but there's anothing interesting development.
version selectors work well now :o
version selectors work well now :o
that's super useful
:heart_eyes: it's beautiful
:0 is that new too?
1 reply
game changer
yea this is good stuff. Bummer about the URL fragments, but meh not a hugely noticeable thing
:heart:
@oprypin:matrix.org
i don't know, but it could be that i installed it once and never updated. can't check now
i don't know, but it could be that i installed it once and never updated. can't check now
yes, that was it, sry
So I'll guess you'll need to run it every time for me :laughing: